This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [0/4] C-SKY port V2
On 05/27/2018 09:52 PM, Alan Modra wrote:
Thanks. I can't say I gave the patches a really thorough review as I
might do for new contributors, but the good news is that I didn't
notice anything obviously wrong in the code itself.
That's my impression as well from the time I've spent tidying up the
port. The original patches we received from C-SKY needed work on
configury, coding style, and English, but modulo some FIXMEs the actual
code seems reasonably solid and functional to me.
The testsuite fails do need some analysis on your part.
FAIL: ld-elf/merge
FAIL: DT_TEXTREL map file warning
FAIL: pr20995
FAIL: pr20995-2
I haven't looked at why these are failing, but it seems likely the
DT_TEXTREL fail is simply that the csky support isn't up to date with
current binutils. That one should be easy to fix.
I actually did do some triage on the ld failures already and took care
of some that had obvious fixes that could be adapted from other targets.
I saw the DT_TEXTREL failure on Nios II as well and assumed that one
was generic. :-S The root cause of the pr20995 failures seemed to be
that support for copy relocations is incomplete, so I'm leaving that one
for Lifang and Yunhai to fix as port maintainers. It's marked as a
FIXME in the HOWTO table as a reminder.
-Sandra