This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [0/4] C-SKY port
On Thu, May 24, 2018 at 01:23:34PM +0930, Alan Modra wrote:
> On Wed, May 23, 2018 at 05:49:55PM -0600, Sandra Loosemore wrote:
> > This patch series is a new binutils port for C-SKY processors, including
>
> Here's an immediate cursory review, courtesy of git. You can
> reproduce it by adding the following to your .git/config under [core]
> whitespace = indent-with-non-tab,space-before-tab,trailing-space
> git diff should then highlight the errors for you.
Also, please compile with gcc-8 and fix any errors such as the
following:
/home/alan/src/binutils-gdb/bfd/elf32-csky.c: In function ‘csky_elf_relocate_section’:
/home/alan/src/binutils-gdb/bfd/elf32-csky.c:4440:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
else if (bfd_csky_arch (output_bfd) == CSKY_ARCH_810
^
/home/alan/src/binutils-gdb/bfd/elf32-csky.c:4450:2: note: here
case R_CKCORE_ADDR_HI16:
^~~~
/home/alan/src/binutils-gdb/bfd/elf32-csky.c:4813:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
relocation
~~~~~~~~~~
= (htab->elf.sgot->output_section->vma
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ htab->elf.sgot->output_offset + off
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- (input_section->output_section->vma
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ input_section->output_offset
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ rel->r_offset));
~~~~~~~~~~~~~~~~~
/home/alan/src/binutils-gdb/bfd/elf32-csky.c:4819:2: note: here
default:
^~~~~~~
/home/alan/src/binutils-gdb/bfd/elf32-csky.c: In function ‘csky_relocate_contents’:
/home/alan/src/binutils-gdb/bfd/elf32-csky.c:3788:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
signmask = ~(fieldmask >> 1);
~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/home/alan/src/binutils-gdb/bfd/elf32-csky.c:3790:2: note: here
case complain_overflow_bitfield:
^~~~
/home/alan/src/binutils-gdb/bfd/elf32-csky.c: In function ‘csky_elf_check_relocs’:
/home/alan/src/binutils-gdb/bfd/elf32-csky.c:2505:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
if (r_symndx == 0)
^
/home/alan/src/binutils-gdb/bfd/elf32-csky.c:2507:2: note: here
case R_CKCORE_ADDR32:
^~~~
--
Alan Modra
Australia Development Lab, IBM