This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PR22458, failure to choose a matching ELF target

From: Alan Modra <amodra at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>, "Francois H. Theron" <francois dot theron at netronome dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Thu, 17 May 2018 09:27:57 +0930
Subject: Re: PR22458, failure to choose a matching ELF target
References: <20180516121542.GJ23663@bubble.grove.modra.org> <CAMe9rOqDbWY1_zTKvnqE31xP7Seq3Xj_HD-6o4FQO8RrpGhc2g@mail.gmail.com>

On Wed, May 16, 2018 at 06:45:57AM -0700, H.J. Lu wrote:
> On Wed, May 16, 2018 at 5:15 AM, Alan Modra <amodra@gmail.com> wrote:
> > --- a/bfd/libbfd-in.h
> > +++ b/bfd/libbfd-in.h
> > @@ -53,6 +53,9 @@ struct section_hash_entry
> >    asection section;
> >  };
> >
> > +/* Unique section id.  */
> > +extern unsigned int _bfd_section_id;
> > +
> 
> Should it be marked as hidden?

True.  Every variable or function declaration in that file should be
hidden.  Looks like we could do with an ATTRIBUTE_HIDDEN macro.

Also, opcodes/nfp-dis.c should not be including libbfd.h.

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: PR22458, failure to choose a matching ELF target
  - From: Alan Modra

References:
- PR22458, failure to choose a matching ELF target
  - From: Alan Modra
- Re: PR22458, failure to choose a matching ELF target
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]