This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][Binutils][AArch64] Allow non-fatal errors to be emitted and for disassembly notes be placed [Patch (2/3)]


Hi Tamar,

> This patch adds a new platform option "notes" that can be used to indicate if
> disassembly notes should be placed in the disassembly as comments.

> Ok for master?

Almost.  Please could you:

  * Add an entry in the binutils/NEWS file about this new feature.

  * Add a test case to check that the new feature works.  (Either to
    the gas or binutils testsuites, whichever you prefer).

  * Fix a minor spelling typo:

+  /* The way errors are collected in the back-end if a bit non-intuitive.  But
+     essentially, because each operand template is tried recursively you may

   "...back-end if..." should be "...back-end is..."

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]