This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Silence gcc-8 warnings

From: Martin Sebor <msebor at gmail dot com>
To: Michael Matz <matz at suse dot de>, Alan Modra <amodra at gmail dot com>
Cc: binutils at sourceware dot org
Date: Mon, 14 May 2018 17:06:07 -0600
Subject: Re: Silence gcc-8 warnings
References: <20180423084836.GA18288@bubble.grove.modra.org> <alpine.LSU.2.21.1804231534290.23081@wotan.suse.de> <20180423141514.GC18288@bubble.grove.modra.org> <alpine.LSU.2.21.1804231626520.23081@wotan.suse.de> <20180423151131.GD18288@bubble.grove.modra.org> <20180423161131.GE18288@bubble.grove.modra.org> <alpine.LSU.2.21.1804231702270.23081@wotan.suse.de> <20180423235829.GF18288@bubble.grove.modra.org> <alpine.LSU.2.21.1804241202530.23081@wotan.suse.de>

On 04/24/2018 06:07 AM, Michael Matz wrote:

Hi,

On Tue, 24 Apr 2018, Alan Modra wrote:

The elf-linux-core.h header is regarded as system header with the #line
directives, and that disables the warning.


Horrible.


I'm not claiming otherwise :-)

#include <string.h>
#define strncpy(dest, src, n) __builtin_strncpy (dest, src, n)

Remove the #define and there's no warning!


Probably not the intent of the warning, which should depend on the place
of the original call not on the place of some intermediate defines.


Right.  There is a way to make it work that way but it's easy to
forget.  I just submitted a patch for a different GCC problem
(bug 85259) that also enables the truncation warning irrespective
of system header macros.

Martin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]