This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gas: xtensa: fix literal movement
- From: Max Filippov <jcmvbkbc at gmail dot com>
- To: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- Cc: binutils at sourceware dot org, Eric Tsai <erictsai at cadence dot com>, linux-xtensa at linux-xtensa dot org
- Date: Wed, 9 May 2018 12:45:22 -0700
- Subject: Re: [PATCH] gas: xtensa: fix literal movement
- References: <20180509175011.28815-1-jcmvbkbc@gmail.com> <CAGSvup_JZW7-AJ==Y8zGHLBfvK04LHvAoFwqbFvxfYNwjM-HpQ@mail.gmail.com>
On Wed, May 9, 2018 at 11:56 AM, augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
> On Wed, May 9, 2018 at 10:50 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>> gas/
>> 2018-05-09 Max Filippov <jcmvbkbc@gmail.com>
>>
>> * config/tc-xtensa.c (xtensa_is_init_fini): New function.
>> (xtensa_move_literals): Only attempt to assign literal pool to
>> literals with tc_frag_data.is_literal mark and not in .init or
>> .fini sections.
>> Join nested 'if' conditions to simplify function structure.
>> (xtensa_switch_to_non_abs_literal_fragment): Use
>> xtensa_is_init_fini to test for .init/.fini sections.
>> * testsuite/gas/xtensa/all.exp (auto-litpools-3)
>> (auto-litpools-4, text-section-literals-1): New tests.
>> * testsuite/gas/xtensa/auto-litpools-3.d: New test results.
>> * testsuite/gas/xtensa/auto-litpools-3.s: New test source.
>> * testsuite/gas/xtensa/auto-litpools-4.d: New test results.
>> * testsuite/gas/xtensa/auto-litpools-4.s: New test source.
>> * testsuite/gas/xtensa/text-section-literals-1.d: New test results.
>> * testsuite/gas/xtensa/text-section-literals-1.s: New test source.
>
> This is fine. Please apply.
Thank you. Applied to master.
-- Max