This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] i386: Append ".p2align 4,0" to gas tests
>>> On 07.05.18 at 13:17, <hjl.tools@gmail.com> wrote:
> On Sun, May 6, 2018 at 11:40 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 07.05.18 at 04:11, <hjl.tools@gmail.com> wrote:
>>> Append ".p2align 4,0" to i386 assembler tests to support mingw targets.
>>>
>>> * testsuite/gas/i386/avx512f-plain.s: Append ".p2align 4,0".
>>> * testsuite/gas/i386/avx512vl-plain.s: Likewise.
>>> * testsuite/gas/i386/bnd.s: Likewise.
>>> * testsuite/gas/i386/stN.s: Likewise.
>>> * testsuite/gas/i386/avx512f-plain.l: Updated.
>>> * testsuite/gas/i386/avx512vl-plain.l: Likewise.
>>> * testsuite/gas/i386/bnd.l: Likewise.
>>> * testsuite/gas/i386/stN.l: Likewise.
>>
>> Thanks here too for taking care of it, but if this is a recurring thing that all
>> tests need, is this really something each and every test should repeat?
>
> We need it for tests with error or waning. Do you have any suggestions?
Well, I'm not a DejaGnu/expect specialist, but I would think it ought to be
possible to have run_dump_test / run_list_test deal with this, e.g. by adding
an extra small assembly file to the end of respective "as" command lines (it
allows for multiple inputs after all).
Jan