This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v4] BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables
- From: "Maciej W. Rozycki" <macro at mips dot com>
- To: Simon Atanasyan <simon at atanasyan dot com>
- Cc: <binutils at sourceware dot org>
- Date: Thu, 3 May 2018 17:21:22 +0100
- Subject: Re: [PATCH v4] BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables
- References: <20180429065756.bvponxkyyqtmdrbg@debian64.galaxy.int> <alpine.DEB.2.00.1804300946270.11756@tp.orcam.me.uk> <CAGyS+DTmBt3k-bU+KYNdJZ+akqCgK1vqaWPDB9TkgXQMW3sOew@mail.gmail.com>
Hi Simon,
> > To speed up upstreaming your change here's an update patch I have made to
> > address my concerns that I will fold into your change and push in the next
> > couple of days. Please let me know if you disagree with any of the
> > changes I propose.
>
> I agree with all the changes. The patch becomes really better. Thank you
> for all notes and suggestions. Feel free to push it upstream.
I have committed your change now with the update included, and having
fixed the description in a couple of places to follow the requirement to
have two spaces between a full stop and the next sentence.
Thank you for your contribution and your patience through the review.
Maciej