This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH][Binutils][AArch64] fix unintialized memory
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: Tamar Christina <Tamar dot Christina at arm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "Marcus Shawcroft" <Marcus dot Shawcroft at arm dot com>
- Date: Tue, 1 May 2018 14:57:00 +0000
- Subject: RE: [PATCH][Binutils][AArch64] fix unintialized memory
- Nodisclaimer: True
- References: <20180425100254.GA12098@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Ping
> -----Original Message-----
> From: binutils-owner@sourceware.org <binutils-owner@sourceware.org>
> On Behalf Of Tamar Christina
> Sent: Wednesday, April 25, 2018 11:03
> To: binutils@sourceware.org
> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> Subject: [PATCH][Binutils][AArch64] fix unintialized memory
>
> Hi All,
>
> This patch fixes an issue where the memory for the opcode structure is not
> zero'd before the first exit branch. So there is one failure mode for which
> uninitialized memory is returned.
>
> This causes weird failures when the return code is not checked before inst is
> used.
>
> Regtested with check on aarch64-none-elf and no issues.
>
> Ok for master?
>
> Thanks,
> Tamar.
>
> opcodes/
> 2018-04-25 Tamar Christina <tamar.christina@arm.com>
>
> * aarch64-dis.c (aarch64_opcode_decode): Moved memory clear
> code.
>
> --