This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PR22887, null pointer dereference in aout_32_swap_std_reloc_out
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Wed, 28 Feb 2018 22:18:37 +1030
- Subject: PR22887, null pointer dereference in aout_32_swap_std_reloc_out
- Authentication-results: sourceware.org; auth=none
PR 22887
* aoutx.h (swap_std_reloc_in): Correct r_index bound check.
diff --git a/bfd/aoutx.h b/bfd/aoutx.h
index 4cadbfb..525e560 100644
--- a/bfd/aoutx.h
+++ b/bfd/aoutx.h
@@ -2289,10 +2289,12 @@ NAME (aout, swap_std_reloc_in) (bfd *abfd,
if (r_baserel)
r_extern = 1;
- if (r_extern && r_index > symcount)
+ if (r_extern && r_index >= symcount)
{
/* We could arrange to return an error, but it might be useful
- to see the file even if it is bad. */
+ to see the file even if it is bad. FIXME: Of course this
+ means that objdump -r *doesn't* see the actual reloc, and
+ objcopy silently writes a different reloc. */
r_extern = 0;
r_index = N_ABS;
}
--
Alan Modra
Australia Development Lab, IBM