This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] x86: Add .nop directive to assembler

From: Alan Modra <amodra at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: "Maciej W. Rozycki" <macro at mips dot com>, Michael Matz <matz at suse dot de>, Jan Beulich <JBeulich at suse dot com>, Andrew Cooper <andrew dot cooper3 at citrix dot com>, Binutils <binutils at sourceware dot org>
Date: Sat, 17 Feb 2018 11:19:49 +1030
Subject: Re: [PATCH] x86: Add .nop directive to assembler
Authentication-results: sourceware.org; auth=none
References: <alpine.LSU.2.21.1802151358270.825@wotan.suse.de> <5A85B4AC02000078001A81EE@prv-mh.provo.novell.com> <alpine.LSU.2.21.1802151543270.825@wotan.suse.de> <5A85BE8002000078001A823C@prv-mh.provo.novell.com> <CAMe9rOrPPZd9R3x4JhrPgCM8PTYD+F46dPoKsBQ1rKcY8ErRvQ@mail.gmail.com> <CAMe9rOqFKtc3zpsT_CCBgH6Zc1QXM1=3D48bmngyPpcG6H6yPA@mail.gmail.com> <alpine.LSU.2.21.1802161347500.825@wotan.suse.de> <CAMe9rOpbM8ZpWaYvv723fS6+w6FqKHgQjN2f+2qf0SFyRfmsFw@mail.gmail.com> <alpine.DEB.2.00.1802161531370.3553@tp.orcam.me.uk> <CAMe9rOo89mpdnPRrj+_VxqosnSmP=LFkfO5OFJ11CvRUwtNBbQ@mail.gmail.com>

On Fri, Feb 16, 2018 at 08:07:50AM -0800, H.J. Lu wrote:
> Good points.  Here is the updated patch.   OK for master?

OK, except for one quibble with the default md_generate_nops.  I think
that should error rather than filling with zeros (which is likely to
be an illegal instruction or trap).

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: H.J. Lu
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: Maciej W. Rozycki

References:
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: Michael Matz
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: Jan Beulich
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: Michael Matz
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: Jan Beulich
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: H.J. Lu
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: H.J. Lu
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: Michael Matz
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: H.J. Lu
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: Maciej W. Rozycki
- Re: [PATCH] x86: Add .nop directive to assembler
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]