This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCHv3 1/7] gas/arc: Fix test for big-endian arc
- From: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Claudiu dot Zissulescu at synopsys dot com" <Claudiu dot Zissulescu at synopsys dot com>, "Cupertino dot Miranda at synopsys dot com" <Cupertino dot Miranda at synopsys dot com>, "noamca at mellanox dot com" <noamca at mellanox dot com>, Nick Clifton <nickc at redhat dot com>, Andreas Schwab <schwab at suse dot de>
- Date: Wed, 16 Mar 2016 10:56:41 +0000
- Subject: RE: [PATCHv3 1/7] gas/arc: Fix test for big-endian arc
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1456947552 dot git dot andrew dot burgess at embecosm dot com> <cover dot 1458082098 dot git dot andrew dot burgess at embecosm dot com> <ca6d70d936ec886af4d3d13317d298f4624b1487 dot 1458082098 dot git dot andrew dot burgess at embecosm dot com>
This test was failing for a while in our nightly, good you fix it.
//Claudiu
> -----Original Message-----
> From: Andrew Burgess [mailto:andrew.burgess@embecosm.com]
> Sent: Wednesday, March 16, 2016 12:02 AM
> To: binutils@sourceware.org
> Cc: Claudiu.Zissulescu@synopsys.com; Cupertino.Miranda@synopsys.com;
> noamca@mellanox.com; Nick Clifton; Andreas Schwab; Andrew Burgess
> Subject: [PATCHv3 1/7] gas/arc: Fix test for big-endian arc
>
> The inline-data test checks the specific bytes laid down by the
> assembler, and so relies on the endianness of the target. I could
> change the expected results to be endian agnostic, however, I worried
> that a bug in the assembler that gets the endianness wrong would then
> slip through. Instead I add a new test for big-endian arc, and restrict
> the existing test to little-endian arc.
>
> gas/ChangeLog:
>
> * testsuite/gas/arc/inline-data-1.d: Add target restriction.
> * testsuite/gas/arc/inline-data-2.d: New file.
> ---
> gas/ChangeLog | 5 +++++
> gas/testsuite/gas/arc/inline-data-1.d | 1 +
> gas/testsuite/gas/arc/inline-data-2.d | 9 +++++++++
> 3 files changed, 15 insertions(+)
> create mode 100644 gas/testsuite/gas/arc/inline-data-2.d
>
> diff --git a/gas/ChangeLog b/gas/ChangeLog
> index d67d752..ec65c57 100644
> --- a/gas/ChangeLog
> +++ b/gas/ChangeLog
> @@ -1,3 +1,8 @@
> +2016-03-15 Andrew Burgess <andrew.burgess@embecosm.com>
> +
> + * testsuite/gas/arc/inline-data-1.d: Add target restriction.
> + * testsuite/gas/arc/inline-data-2.d: New file.
> +
> 2016-03-15 Ulrich Drepper <drepper@gmail.com>
>
> * doc/c-i386.texi (Register Naming): Update to details of the
> diff --git a/gas/testsuite/gas/arc/inline-data-1.d
> b/gas/testsuite/gas/arc/inline-data-1.d
> index ce5c272..9b5e442 100644
> --- a/gas/testsuite/gas/arc/inline-data-1.d
> +++ b/gas/testsuite/gas/arc/inline-data-1.d
> @@ -1,4 +1,5 @@
> #as: -mcpu=arc700
> +#target: arc-*
> #objdump: -sj .text
>
> .*: +file format .*arc.*
> diff --git a/gas/testsuite/gas/arc/inline-data-2.d
> b/gas/testsuite/gas/arc/inline-data-2.d
> new file mode 100644
> index 0000000..60435d4
> --- /dev/null
> +++ b/gas/testsuite/gas/arc/inline-data-2.d
> @@ -0,0 +1,9 @@
> +#as: -mcpu=arc700
> +#target: arceb-*
> +#objdump: -sj .text
> +#source: inline-data-1.s
> +
> +.*: +file format .*arc.*
> +
> +Contents of section .text:
> + [0-9a-f]+ aabbccdd eeff .*
> --
> 2.5.1