This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: Re: [PATCH] cpu/opcodes: Sync up fr30.cpu and generated opcodes files

On Wed, Mar 02, 2016 at 12:22:58AM +0000, Andrew Burgess wrote:
> Ping!
> * Andrew Burgess <> [2016-02-14 00:44:15 +0000]:
> > In commit b6518b3 (Fix compile time warnings generated when compiling
> > with clang.) the generated fr30-ibld.c file was modified, but the
> > underlying fr30.cpu file, from which it is generated was not.
> > 
> > This commit updates the fr30.cpu file in such a way that the C code
> > generated in fr30-ibld.c avoids the undefined behaviour that b6518b3 was
> > trying to avoid, while also being something that CGEN can handle without
> > any changes.

Sorry, I had this email queued up to answer in my inbox, and then
totally forgot about it.  I didn't see it again until I'd worked my
way through my email backlog.

> > 	* fr30.cpu (f-m4): Adjust extract handler to avoid shifting a
> > 	negative value (undefined behaviour in C).

This is fine, but I've already committed a slightly different patch,
in a quest to have no local patches to all the generated files in
opcodes.  See

Alan Modra
Australia Development Lab, IBM

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]