This is the mail archive of the
mailing list for the binutils project.
Re: PING: Re: [PATCH] cpu/opcodes: Sync up fr30.cpu and generated opcodes files
- From: Alan Modra <amodra at gmail dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 2 Mar 2016 18:33:41 +1030
- Subject: Re: PING: Re: [PATCH] cpu/opcodes: Sync up fr30.cpu and generated opcodes files
- Authentication-results: sourceware.org; auth=none
- References: <26ed35ad6217386ff606faa9b3020d58cc6dbfd0 dot 1455410562 dot git dot andrew dot burgess at embecosm dot com> <20160302002258 dot GV9275 at embecosm dot com>
On Wed, Mar 02, 2016 at 12:22:58AM +0000, Andrew Burgess wrote:
> * Andrew Burgess <firstname.lastname@example.org> [2016-02-14 00:44:15 +0000]:
> > In commit b6518b3 (Fix compile time warnings generated when compiling
> > with clang.) the generated fr30-ibld.c file was modified, but the
> > underlying fr30.cpu file, from which it is generated was not.
> > This commit updates the fr30.cpu file in such a way that the C code
> > generated in fr30-ibld.c avoids the undefined behaviour that b6518b3 was
> > trying to avoid, while also being something that CGEN can handle without
> > any changes.
Sorry, I had this email queued up to answer in my inbox, and then
totally forgot about it. I didn't see it again until I'd worked my
way through my email backlog.
> > * fr30.cpu (f-m4): Adjust extract handler to avoid shifting a
> > negative value (undefined behaviour in C).
This is fine, but I've already committed a slightly different patch,
in a quest to have no local patches to all the generated files in
opcodes. See https://sourceware.org/ml/cgen/2016-q1/msg00002.html
Australia Development Lab, IBM