This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] ld: Add '--defined' command line option.
- From: Nick Clifton <nickc at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, binutils at sourceware dot org
- Date: Thu, 30 Jul 2015 16:59:26 +0100
- Subject: Re: [PATCH] ld: Add '--defined' command line option.
- Authentication-results: sourceware.org; auth=none
- References: <1437426340-25537-1-git-send-email-andrew dot burgess at embecosm dot com> <55B0CF5A dot 1030901 at redhat dot com> <20150728122751 dot GB20589 at embecosm dot com>
Hi Andrew,
In this revised version of the patch:
- Option has been renamed to --require-defined=SYMBOL.
- Added a NEWS entry.
- The docs for '--undefined' now reference '--require-defined'.
- I've added a few more tests, which I hope will be extensive enough
for now.
Thanks for making these changes. Unfortunately the new tests fail for
some targets:
tic30-unknown-aout
ns32k-netbsd
pdp11-dec-aout
powerpc-ibm-aix5.2.0
rs6000-aix4.3.3
i586-aout
arm-aout
These targets all complain about the ".section .text.1" directive. If
you replace it with just ".text" the problem should go away.
+If this option is being used to force additional modules to be pulled
+into the link, and if it is an error for the symbol to remain
+undefined, then the option @samp{--require-defined} can be used instead.
Personally I would word this as
...then the option @option{--require-defined} should be used instead.
Note the use of @option{} and replacement of 'can' with 'should'.
Cheers
Nick