RE: [PATH] AMD MWAITX enablement

["Pawar, Amit" <Amit dot Pawar at amd dot com>]

PFA MWAITX patch. Thank you.

-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com] 
Sent: Friday, June 26, 2015 10:14 PM
To: Pawar, Amit
Cc: binutils@sourceware.org; Jan Beulich
Subject: Re: [PATH] AMD MWAITX enablement

On Fri, Jun 26, 2015 at 9:39 AM, Pawar, Amit <Amit.Pawar@amd.com> wrote:
> PFA MWAITX updated patch. Is it OK?
>

+      for (x = 0; x < 2; x++)
+          if (register_number (i.op[x].regs) != x)
+              goto bad_register_operand;

Please fix indentation.

+
+      /* Check for third operand for mwaitx/monitorx insn*/
+      if (register_number (i.op[2].regs) !=
+          ( 2 + (i.tm.extension_opcode == 0xfb)))
             ^^ Remove extra space before 2.

Please use "x" instead of "2".

+        {
+bad_register_operand:
+          as_bad (_("can't use register '%s%s' as operand %d in '%s'."),
+                  register_prefix, i.op[x].regs->reg_name, x+1,
+                  i.tm.name);
+        }


OK with those changes.

Thanks.

-- 
H.J.

Attachment: mwaitx_v6.patch
Description: mwaitx_v6.patch