This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [PATH] AMD MWAITX enablement

From: "Pawar, Amit" <Amit dot Pawar at amd dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Jan Beulich <JBeulich at suse dot com>
Date: Fri, 26 Jun 2015 11:09:33 +0000
Subject: RE: [PATH] AMD MWAITX enablement
Authentication-results: sourceware.org; auth=none
Authentication-results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; gmail.com; dkim=none (message not signed) header.d=none;
References: <0428E25D138CAA4D819A6FED9429E51AF4A29C at SCYBEXDAG02 dot amd dot com> <556D83DE02000078000800CE at mail dot emea dot novell dot com> <0428E25D138CAA4D819A6FED9429E51AF4A96C at SCYBEXDAG02 dot amd dot com> <55755AD50200007800081CE1 at mail dot emea dot novell dot com> <0428E25D138CAA4D819A6FED9429E51AF4CB28 at SCYBEXDAG02 dot amd dot com> <CAMe9rOocBnj6cEvcPLOg1cqm69bQgv1hC+9z-PP28TW3YCJRVA at mail dot gmail dot com> <0428E25D138CAA4D819A6FED9429E51AF4CBC5 at SCYBEXDAG02 dot amd dot com> <CAMe9rOpA=cZLNeAE0-kag8oU8hOJLubArHFZFEbmFnT7VeYrzQ at mail dot gmail dot com>

Operand check is required at that line as instructions MONITORX/MWAITX are accepted without operands also.


-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com] 
Sent: Friday, June 26, 2015 3:34 PM
To: Pawar, Amit
Cc: binutils@sourceware.org; Jan Beulich
Subject: Re: [PATH] AMD MWAITX enablement

On Thu, Jun 25, 2015 at 10:46 PM, Pawar, Amit <Amit.Pawar@amd.com> wrote:
> PFA MWAITX fixed patch. OK to apply?
>

Please change the operand check to

if (i.tm.cpu_flags.bitfield.cpumwaitx)
{
  if ( i.operands != 3)
abort

for (i = 0, i< 2; i++)
...

if (register_number (i.op[2].regs) != 2 + (opcode ==mwaitx ) ...
}

--
H.J.

Attachment: mwaitx_v4.patch
Description: mwaitx_v4.patch

Follow-Ups:
- Re: [PATH] AMD MWAITX enablement
  - From: H.J. Lu

References:
- [PATH] AMD MWAITX enablement
  - From: Pawar, Amit
- Re: [PATH] AMD MWAITX enablement
  - From: Jan Beulich
- RE: [PATH] AMD MWAITX enablement
  - From: Pawar, Amit
- RE: [PATH] AMD MWAITX enablement
  - From: Jan Beulich
- RE: [PATH] AMD MWAITX enablement
  - From: Pawar, Amit
- Re: [PATH] AMD MWAITX enablement
  - From: H.J. Lu
- RE: [PATH] AMD MWAITX enablement
  - From: Pawar, Amit
- Re: [PATH] AMD MWAITX enablement
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]