This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] MIPS: Make the CODE10 operand code consistent between ISAs
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: <binutils at sourceware dot org>
- Date: Mon, 25 Aug 2014 22:03:31 +0100
- Subject: Re: [PATCH] MIPS: Make the CODE10 operand code consistent between ISAs
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1408211234210 dot 2958 at tp dot orcam dot me dot uk>
"Maciej W. Rozycki" <firstname.lastname@example.org> writes:
> This was perhaps more important with the old code that had to handle
> separate standard MIPS and microMIPS variants of operands explicitly with
> macros, but even now I think it makes sense to keep alphanumerical codes
> consistent between the two instruction sets, to make it a bit easier to
> the reader.
> This change therefore moves the microMIPS 10-bit immediate code embedded
> at bits 25..16 in the SYSCALL, WAIT, SDBBP and HYPCALL instructions from
> `B' over to `+J' which is the operand code used in the standard MIPS
> instructions set for the same instruction field, used by HYPCALL only in
> that set.
Well, it seems like matching by purpose vs. matching by field position.
E.g. "s"/RS is in a different position for microMIPS vs. MIPS, so if we
were going to apply that logic consistently, the microMIPS RS fields
would use "t"/RT instead.
But I suppose I don't mind either way, so if you feel strongly about it,
the patch is OK.