This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH,i386] Add -momit-lock-prefix option.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Tue, 12 Aug 2014 15:54:48 -0700
- Subject: Re: [PATCH,i386] Add -momit-lock-prefix option.
- Authentication-results: sourceware.org; auth=none
- References: <20140806145436 dot GA48509 at msticlxl7 dot ims dot intel dot com> <CAMe9rOoKaLm6GbzsZUQDAnKPR1HqojZych1Hj4fgtN-0cvk22A at mail dot gmail dot com> <20140812224644 dot GO7047 at bubble dot grove dot modra dot org>
On Tue, Aug 12, 2014 at 3:46 PM, Alan Modra <amodra@gmail.com> wrote:
> On Wed, Aug 06, 2014 at 08:34:07AM -0700, H.J. Lu wrote:
>> On Wed, Aug 6, 2014 at 7:54 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> > Hi,
>> >
>> > Some processors (e. g. current revision of Intel Quark) fail on
>> > lock prefix. As a workaround for them this patch introduces new
>> > -momit-lock-prefix option, which makes gas ignore lock prefix.
>> > Ok for trunk?
>>
>> I checked it for you with some cosmetic changes.
>
> i386-darwin +FAIL: i386 omit lock = yes
> i386-darwin +FAIL: i386 omit lock = no
> i586-coff +FAIL: i386 omit lock = yes
> i586-coff +FAIL: i386 omit lock = no
> i686-pe +FAIL: i386 omit lock = yes
> i686-pe +FAIL: i386 omit lock = no
> x86_64-mingw32 +FAIL: i386 omit lock = yes
> x86_64-mingw32 +FAIL: i386 omit lock = no
>
I checked in this patch to remove type directive.
--
H.J.
---
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index 44e3c34..8bf2121 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2014-08-12 H.J. Lu <hongjiu.lu@intel.com>
+
+ * gas/i386/omit-lock.s: Remove type directive.
+
2014-08-06 Ilya Tocar <ilya.tocar@intel.com>
* gas/i386/i386.exp: Run new tests.
diff --git a/gas/testsuite/gas/i386/omit-lock.s
b/gas/testsuite/gas/i386/omit-lock.s
index b267ebe..248a9be 100644
--- a/gas/testsuite/gas/i386/omit-lock.s
+++ b/gas/testsuite/gas/i386/omit-lock.s
@@ -1,6 +1,5 @@
- .code32
+ .text
.globl main
- .type main, @function
main:
lock
lock addl $0x1,(%eax)