This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: binutils-2.24 and HEAD: patch for gas/config/tc-i386.c
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: Thomas Klausner <tk at giga dot or dot at>, Binutils <binutils at sourceware dot org>
- Date: Wed, 8 Jan 2014 08:27:33 -0800
- Subject: Re: binutils-2.24 and HEAD: patch for gas/config/tc-i386.c
- Authentication-results: sourceware.org; auth=none
- References: <20140106192333 dot GG14484 at danbala dot tuwien dot ac dot at> <52CBE1C20200007800110FC9 at nat28 dot tlf dot novell dot com>
On Tue, Jan 7, 2014 at 2:15 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 06.01.14 at 20:23, Thomas Klausner <tk@giga.or.at> wrote:
>> Hi!
>>
>> When compiling binutils-2.24 on NetBSD-6.99.28/amd64 with
>> clang-3.4rc1, the build stops in gas/config/tc-i386.c:
>>
>> config/tc-i386.c:1668:32: error: unused variable 'regbnd'
>> [-Werror,-Wunused-const-variable]
>> static const i386_operand_type regbnd = OPERAND_TYPE_REGBND;
>> ^
>> config/tc-i386.c:1669:32: error: unused variable 'vec_disp8'
>> [-Werror,-Wunused-const-variable]
>> static const i386_operand_type vec_disp8 = OPERAND_TYPE_VEC_DISP8;
>> ^
>>
>> The attached patch comments out these variables, but perhaps they
>> should be used instead? I don't know, so I thought I'd just report
>> this issue.
>
> Commenting them out (and even with C++ style comments) is surely
> not the right thing - they indeed look to be unused, so they should
> just get deleted.
I checked this into trunk and 2.24 branch.
--
H.J.
--
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 0ed7b2d..0bb31f5 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,10 @@
2014-01-08 H.J. Lu <hongjiu.lu@intel.com>
+ * config/tc-i386.c (regbnd): Removed.
+ (vec_disp8): Likewise.
+
+2014-01-08 H.J. Lu <hongjiu.lu@intel.com>
+
* as.c (parse_args): Update copyright year to 2014.
2014-01-07 Tom Tromey <tromey@redhat.com>
diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index c6e1dba..147acdf 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -1,7 +1,7 @@
/* tc-i386.c -- Assemble code for the Intel 80386
Copyright 1989, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011,
- 2012
+ 2012, 2013, 2014
Free Software Foundation, Inc.
This file is part of GAS, the GNU Assembler.
@@ -1667,8 +1667,6 @@ static const i386_operand_type imm16_32 =
OPERAND_TYPE_IMM16_32;
static const i386_operand_type imm16_32s = OPERAND_TYPE_IMM16_32S;
static const i386_operand_type imm16_32_32s = OPERAND_TYPE_IMM16_32_32S;
static const i386_operand_type vec_imm4 = OPERAND_TYPE_VEC_IMM4;
-static const i386_operand_type regbnd = OPERAND_TYPE_REGBND;
-static const i386_operand_type vec_disp8 = OPERAND_TYPE_VEC_DISP8;
enum operand_type
{