This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][ARM][GAS] Fix internal error on badly shaped VMOV

From: "Kyrylo Tkachov" <kyrylo dot tkachov at arm dot com>
To: <binutils at sourceware dot org>
Cc: "Richard Earnshaw" <Richard dot Earnshaw at arm dot com>, "'nick clifton'" <nickc at redhat dot com>
Date: Wed, 13 Feb 2013 11:50:29 -0000
Subject: [PATCH][ARM][GAS] Fix internal error on badly shaped VMOV

Hi all,
This patch fixes an internal error that gas throws when dealing with a
misformed VMOV instruction of the form:
vmov    q0, d0.
Internally, the function neon_select_shape recognises that the instruction
is misformed and sets the error message, but the caller (do_neon_mov)
takes the (NS_NULL) result, fails to recognise it and aborts (with an
internal error message). This patch catches the case where neon_select_shape
returns NS_NULL and doesn't fall-through to abort.

A new testcase is added to make sure that the proper error message is
emitted.
No regressions for check-gas.

Ok for trunk?

Thanks,
Kyrill

gas/ChangeLog

2013-02-13  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

        * config/tc-arm.c (do_neon_mov): Break on NS_NULL.



gas/testsuite/ChangeLog

2013-02-13  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

        * gas/arm/neon-vmov-bad.d: New file.
        * gas/arm/neon-vmov-bad.s: Likewise.
        * gas/arm/neon-vmov-bad.l: Likewise.

Attachment: gas-vmov.txt
Description: Text document

Follow-Ups:
- Re: [PATCH][ARM][GAS] Fix internal error on badly shaped VMOV
  - From: nick clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]