Re: [patch] ld: optimize vfinfo output slightly

[Mike Frysinger <vapier at gentoo dot org>]

On Friday 30 March 2012 12:16:52 nick clifton wrote:
> >> Write errors should either be handled or ignored, but aborting is not
> >> the right thing (it's not an internal error).
> > 
> > so just do something like the following ?
> > 
> > 	if (fwrite (str, 1, len, fp) != len)
> > 	
> > 	  {
> > 	  
> > 	    /* Ignore.  */
> > 	  
> > 	  }
> 
> Yes.  Although it would be simpler to just remove the whole if (...)
> statment block and just call fwrite without testing its return value.
> 
> A patch modified in this way is approved.

the reason i didn't do that is it causes warnings since fwrite() is marked as 
"warn on unused result"
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.