This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] ld: optimize vfinfo output slightly

Hi Mike,

O 
Write errors should either be handled or ignored, but aborting is not
the right thing (it's not an internal error).


so just do something like the following ?
	if (fwrite (str, 1, len, fp) != len)
	  {
	    /* Ignore.  */
	  }

Yes. Although it would be simpler to just remove the whole if (...) statment block and just call fwrite without testing its return value.

A patch modified in this way is approved.

Cheers
  Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]