This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR gold/13507: Gold assumes GOT entry size is the same as ELF class size
- From: Cary Coutant <ccoutant at google dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, binutils at sourceware dot org
- Date: Tue, 3 Jan 2012 16:25:29 -0800
- Subject: Re: PATCH: PR gold/13507: Gold assumes GOT entry size is the same as ELF class size
- References: <20111215230919.GA14342@intel.com> <mcrliqdjl6w.fsf@dhcp-172-18-216-180.mtv.corp.google.com> <CAMe9rOrHv4YEwDXsmVLhFUZA8D7UPvOC28x-rEk8Aba-p4d_Yw@mail.gmail.com> <mcr8vmdjc59.fsf@dhcp-172-18-216-180.mtv.corp.google.com> <CAMe9rOrXivTFYsadrAH_E6SHcPv_gppz0uNCRcxBWPcZ2EMJjA@mail.gmail.com> <mcrpqfoh3h2.fsf@dhcp-172-18-216-180.mtv.corp.google.com> <CAMe9rOocBWBW7mbb_aS=mjUjshv_bSQKkBwkufYdemVQ7FRGbA@mail.gmail.com> <mcrhb10gx5o.fsf@dhcp-172-18-216-180.mtv.corp.google.com> <CAMe9rOoXyFv6ArEW1KWBkocTuh7a_52+7hOi1KaW-vepJm=wXg@mail.gmail.com> <mcr62hfemih.fsf@dhcp-172-18-216-180.mtv.corp.google.com> <CAMe9rOoUDcgWB7BdxtHRSnPGJubCU2Wa0awqwkqeJ5Dq7QOn9w@mail.gmail.com> <CAKOQZ8zjAStMvF0Di2V0tmbXSaJYgOx9uE3tYCW_CDS2n5-AkA@mail.gmail.com> <CAMe9rOpmE6rQQ_Cz8gMatkKNBLCcMovsTqoQ77O_8FzXuwxKTQ@mail.gmail.com> <mcr8vlq2c5q.fsf@dhcp-172-18-216-180.mtv.corp.google.com> <CAHACq4r9WWgepzYzWxzd94091NSexRO91rhcazUXjMGybJPUTA@mail.gmail.com> <mcrpqf0z67t.fsf@dhcp-172-18-216-180.mtv.corp.google.com>
>> 2012-01-03 ?Cary Coutant ?<ccoutant@google.com>
>>
>> ? ? ? * gold/incremental.cc (Sized_incremental_binary::do_process_got_plt):
>> ? ? ? Use abstract base class for GOT.
>> ? ? ? * gold/output.h (class Output_data_got_base): New abstract base class.
>> ? ? ? (class Output_data_got): Derive from new base class, adjust ctors.
>> ? ? ? (Output_data_got::reserve_slot): Make virtual; rename to
>> ? ? ? do_reserve_slot; Adjust callers.
>> ? ? ? * gold/target.h (Sized_target::init_got_plt_for_update): Return
>> ? ? ? pointer to abstract base class.
>> ? ? ? * gold/x86_64.cc (Target_x86_64::init_got_plt_for_update): Likewise.
>>
>> + ?// Reserve a slot in the GOT.
>> + ?void
>> + ?reserve_slot(unsigned int i)
>> + ?{ this->do_reserve_slot(i); }
>
> Have the comment explain the meaning of the parameter 'i'.
>
> This is OK with that change.
Done, and committed. Thanks.
HJ, please let me know if this solved your problem.
-cary