This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch bfd]: Adjust handling for plugin-generated sections for pe-coff targets
Hi,
So after some research I found the cause for this. As any global
symbol is visible from outside of claimed object realm, we can ease
for COFF is_visible_from_outside function in plugin.c file. As
visibility concepts isn't known to COFF targets too, none of the
checks within this functions are necessary.
ChangeLog
2011-10-09 Kai Tietz <ktietz@redhat.com>
* plugin.c (is_visibile_from_outside): Return for COFF flavor
always TRUE.
Regression tested for x86_64-w64-mingw32, i686-w64-mingw32, and
i686-pc-cygwin. Ok for apply?
Regards,
Kai
Index: plugin.c
===================================================================
RCS file: /cvs/src/src/ld/plugin.c,v
retrieving revision 1.41
diff -u -r1.41 plugin.c
--- plugin.c 6 Oct 2011 10:07:17 -0000 1.41
+++ plugin.c 9 Oct 2011 18:15:44 -0000
@@ -447,6 +447,10 @@
{
struct bfd_sym_chain *sym;
+ /* For COFF targets any global symbol is visible from outside. */
+ if (bfd_get_flavour (link_info.output_bfd) == bfd_target_coff_flavour)
+ return TRUE;
+
/* Section's owner may be NULL if it is the absolute
section, fortunately is_ir_dummy_bfd handles that. */
if (!is_ir_dummy_bfd (section->owner))