This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch bfd]: Adjust handling for plugin-generated sections for pe-coff targets
On Sat, Oct 08, 2011 at 12:49:28PM +0200, Kai Tietz wrote:
> + if ((h->root.type == bfd_link_hash_defined
> + || h->root.type == bfd_link_hash_defweak)
> + && ((finfo->info->strip_discarded
> + && h->root.u.def.section != NULL
> + && !bfd_is_abs_section (h->root.u.def.section)
> + && bfd_is_abs_section (h->root.u.def.section->output_section))
> + || (h->root.u.def.section->owner != NULL
> + && (h->root.u.def.section->owner->flags &
> BFD_PLUGIN) != 0)))
> + continue;
How can this possibly be correct? You have silenced the warning for
*all* symbols defined in excluded sections. You may as well delete
this code! Also, strip_discarded should not be tested here, it has
nothing to do with reporting errors on applying relocations.
--
Alan Modra
Australia Development Lab, IBM