This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [Patch ARM Gas] - strexh/strexb warn for bad addressing modes.
- From: "James Greenhalgh" <james dot greenhalgh at arm dot com>
- To: "'Nick Clifton'" <nickc at redhat dot com>
- Cc: <binutils at sourceware dot org>
- Date: Fri, 29 Jul 2011 16:33:39 +0100
- Subject: RE: [Patch ARM Gas] - strexh/strexb warn for bad addressing modes.
- References: <000601cc4861$5df11510$19d33f30$@greenhalgh@arm.com> <4E32CCDE.2090505@redhat.com>
Hi Nick,
Apologies for the lack of clarity.
strexh and strexb do not have writeback modes in either arm or thumb
mode. An unpatched assembler will return an error for the following
under ARM, but not for thumb.
strexh r1, r2, [r3, #0]!
This was line 9 of strex-bad-t.s which `FAIL's on an unpatched assembler
for me.
Likewise,
strexb r1, r2, [r3, #0]!
The patch adds the error for thumb mode.
The test cases are perhaps a little... over-enthusiastic in testing bad
addressing modes for strexh/strexb, but form a thorough check that
problem cases for this instruction are reported.
Thanks,
James
> -----Original Message-----
> From: Nick Clifton [mailto:nickc@redhat.com]
> Sent: 29 July 2011 16:08
> To: James Greenhalgh
> Cc: binutils@sourceware.org
> Subject: Re: [Patch ARM Gas] - strexh/strexb warn for bad addressing
> modes.
>
> Hi James,
>
> > This patch fixes an issue with strex[b/h] in thumb mode.
>
> What issue ? As far as I can see the current version of gas does
> correctly detect and report these bad addressing modes. Certainly when
> I ran the test cases you supplied through an unpatched assembler they
> all worked.
>
> Cheers
> Nick
>