This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] parameterize elf32-i386 PLT generation
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 27 Jul 2011 16:00:57 -0700
- Subject: Re: [PATCH] parameterize elf32-i386 PLT generation
- References: <x57jaabzgxoa.fsf@frobland.mtv.corp.google.com>
On Wed, Jul 27, 2011 at 3:34 PM, Roland McGrath <mcgrathr@google.com> wrote:
> This patch must follow the "clean up elf32-i386-vxworks hooking mechanism"
> change I just posted, not yet committed.
>
> This parameterizes the elf32-i386 PLT generation code to be table-driven.
> This is preparatory to a reworked addition of the elf32-i386-nacl backend,
> which I first posted yesterday. ?That target uses different PLT code
> sequences and a different PLT entry size.
>
> Ok for trunk?
>
>
> Thanks,
> Roland
>
>
> bfd/
> ? ? ? ?* elf32-i386.c (struct elf_i386_plt_layout): New type.
> ? ? ? ?(GET_PLT_ENTRY_SIZE): New macro.
> ? ? ? ?(elf_i386_plt): New variable.
> ? ? ? ?(struct elf_i386_backend_data): New member `plt'.
> ? ? ? ?(elf_i386_arch_bed): Add initializer for it.
> ? ? ? ?(elf_i386_vxworks_arch_bed): Likewise.
> ? ? ? ?(elf_i386_allocate_dynrelocs): Use GET_PLT_ENTRY_SIZE.
> ? ? ? ?(elf_i386_plt_sym_val): Likewise.
> ? ? ? ?(elf_i386_relocate_section): Likewise.
> ? ? ? ?(elf_i386_finish_dynamic_symbol): Likewise.
> ? ? ? ?Also use other elf_i386_plt_layout members for PLT details.
> ? ? ? ?(elf_i386_finish_dynamic_sections): Likewise.
>
It is OK. Thanks.
--
H.J.