This is the mail archive of the
mailing list for the binutils project.
Re: [patch/gas]: simplify frag_grow
- From: Steve Ellcey <sje at cup dot hp dot com>
- To: Tristan Gingold <gingold at adacore dot com>, binutils at sourceware dot org
- Date: Tue, 26 Jul 2011 13:13:42 -0700 (PDT)
- Subject: Re: [patch/gas]: simplify frag_grow
Tristan Gingold wrote:
> The 'while' loop can only be executed once. The function 'frag_new' can
> either succeed or abort via exit (it uses xmalloc to allocate memory as
> defined by as.h).
This doesn't seem to be true. I used the previous version of frag_grow
and put some print statements in frag_grow and I see multiple passes
through the while loop in some calls to frag_grow. If I change the
while to an if (so that it can only be done once) and make no other
changes, my test case fails.