This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ld --print-output-format switch

> In general I like this idea and I would like somebody to approve it (I
> don't approve many binutils patches these days outside of gold).

You seemed like a good candidate to me because you're whom I expect will
implement it compatibly in gold.

> However, I don't see why this will do the right thing when used with -EB
> or -EL, and it seems to me that this matters.  Your patch prints
> default_target, but as far as I can see -EB/-EL only affect
> output_target.  I think this does need to be tested to ensure that
> -EL/-EB work correctly.

You're right, output_target is correct.  However, it's sometimes not set.
I've fixed the patch and tested that it does the right thing for -EB vs -EL
(or default of -EL or of -EB) with a few targets like armelf_linux_eabi and
armelfb_linux_eabi as well as one like ppcmacos where output_target seems
to be NULL:

	$ for m in armelf{b,}_linux_eabi ppcmacos; do for e in '' -EL -EB; do echo -n "$e $m:"; ./ld/ld-new -m $m $e --print-output-format; done; done
	-EL armelfb_linux_eabi:elf32-littlearm
	-EB armelfb_linux_eabi:elf32-bigarm
	-EL armelf_linux_eabi:elf32-littlearm
	-EB armelf_linux_eabi:elf32-bigarm
	-EL ppcmacos:xcoff-powermac
	-EB ppcmacos:xcoff-powermac


2011-07-09  Roland McGrath  <>

	* ld.h (args_type): New field print_output_format.
	* lexsup.c (enum option_values, ld_options, parse_args):
	Handle --print-output-format.
	* ldmain.c (main): Implement --print-output-format.
	* ld.texinfo (Options): Document it.

	* ldlang.c (lang_get_output_target): Don't return current_target
	when it's NULL.

diff --git a/ld/ld.h b/ld/ld.h
index 9391923..138fdec 100644
--- a/ld/ld.h
+++ b/ld/ld.h
@@ -199,6 +199,9 @@ typedef struct {
      input files.  */
   bfd_boolean accept_unknown_input_arch;
+  /* If TRUE we'll just print the default output on stdout.  */
+  bfd_boolean print_output_format;
   /* Big or little endian as set on command line.  */
   enum endian_enum endian;
diff --git a/ld/ld.texinfo b/ld/ld.texinfo
index 5a8e190..373a24e 100644
--- a/ld/ld.texinfo
+++ b/ld/ld.texinfo
@@ -1401,6 +1401,13 @@ default behaviour (of not listing the sections that are removed) can
 be restored by specifying @samp{--no-print-gc-sections} on the command
+@kindex --print-output-format
+@cindex output format
+@item --print-output-format
+Print the name of the default output format (perhaps influenced by
+other command-line options).  This is the string that would appear
+in an @code{OUTPUT_FORMAT} linker script command (@pxref{File Commands}).
 @cindex help
 @cindex usage
 @kindex --help
diff --git a/ld/ldlang.c b/ld/ldlang.c
index 860ce27..c440940 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -3024,7 +3024,7 @@ lang_get_output_target (void)
   /* No - has the current target been set to something other than
      the default?  */
-  if (current_target != default_target)
+  if (current_target != default_target && current_target != NULL)
     return current_target;
   /* No - can we determine the format of the first input file?  */
diff --git a/ld/ldmain.c b/ld/ldmain.c
index 1b4afff..ec9dcff 100644
--- a/ld/ldmain.c
+++ b/ld/ldmain.c
@@ -427,11 +427,14 @@ main (int argc, char **argv)
       info_msg ("\n==================================================\n");
+  if (command_line.print_output_format)
+    info_msg ("%s\n", lang_get_output_target ());
   lang_final ();
   if (!lang_has_input_file)
-      if (version_printed)
+      if (version_printed || command_line.print_output_format)
 	xexit (0);
       einfo (_("%P%F: no input files\n"));
diff --git a/ld/lexsup.c b/ld/lexsup.c
index 08ef107..b5e52a8 100644
--- a/ld/lexsup.c
+++ b/ld/lexsup.c
@@ -175,6 +175,7 @@ enum option_values
 #endif /* ENABLE_PLUGINS */
 /* The long options.  This structure is used for both the option
@@ -491,6 +492,8 @@ static const struct ld_option ld_options[] =
   { {"oformat", required_argument, NULL, OPTION_OFORMAT},
     '\0', N_("TARGET"), N_("Specify target of output file"),
+  { {"print-output-format", no_argument, NULL, OPTION_PRINT_OUTPUT_FORMAT},
+    '\0', NULL, N_("Print default output format"), TWO_DASHES },
   { {"qmagic", no_argument, NULL, OPTION_IGNORE},
     '\0', NULL, N_("Ignored for Linux compatibility"), ONE_DASH },
   { {"reduce-memory-overheads", no_argument, NULL,
@@ -1059,6 +1062,9 @@ parse_args (unsigned argc, char **argv)
 	  lang_add_output_format (optarg, NULL, NULL, 0);
+	  command_line.print_output_format = TRUE;
+	  break;
 	  if (plugin_opt_plugin (optarg))

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]