This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] ENUM_BITFIELD broke GDB

From: Alan Modra <amodra at gmail dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Andreas Schwab <schwab at linux-m68k dot org>, binutils at sourceware dot org, "H.J. Lu" <hjl dot tools at gmail dot com>, richard dot sandiford at linaro dot org
Date: Mon, 25 Apr 2011 13:34:04 +0930
Subject: Re: [patch] ENUM_BITFIELD broke GDB
References: <g41v0v6cq6.fsf@linaro.org> <BANLkTi=LgfKOP9bEGM9r32hAMUNT3w97LA@mail.gmail.com> <20110424101401.GQ19947@bubble.grove.modra.org> <20110424144908.GA21444@host1.jankratochvil.net> <m2k4ej1xf4.fsf@igel.home> <20110424153128.GA9590@host1.jankratochvil.net>

On Sun, Apr 24, 2011 at 05:31:28PM +0200, Jan Kratochvil wrote:
> include/
> 2011-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* bfdlink.h (ENUM_BITFIELD): Move to ...
> 	* ansidecl.h (ENUM_BITFIELD): ... here, use the one from GCC sources.
> 
> gdb/
> 2011-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* defs.h (ENUM_BITFIELD): Remove.

Sorry for the breakage.  I'm not sure I have approval rights for
ansidecl.h as this file is shared with gcc (and patches should be
applied to both src and gcc repos), but the patch ought to come under
the obvious rule..  However, given that gcc's system.h pulls
in ansidecl.h via libiberty.h, the ENUM_BITFIELD in system.h should go
too.

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- [commit include/+gdb/] Re: [patch] ENUM_BITFIELD broke GDB
  - From: Jan Kratochvil

References:
- Re: Change bfd_link_hash_entry.type to a bitfield?
  - From: Richard Sandiford
- Re: PR12365 and common symbols
  - From: H.J. Lu
- Re: Change bfd_link_hash_entry.type to a bitfield?
  - From: Alan Modra
- [patch] ENUM_BITFIELD broke GDB [Re: Change bfd_link_hash_entry.type to a bitfield?]
  - From: Jan Kratochvil
- Re: [patch] ENUM_BITFIELD broke GDB [Re: Change bfd_link_hash_entry.type to a bitfield?]
  - From: Andreas Schwab
- Re: [patch] ENUM_BITFIELD broke GDB
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]