This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 4.0/4 v3] MIPS/GAS: Propagate symbol attributes
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Catherine Moore <clm at codesourcery dot com>, binutils at sourceware dot org
- Date: Thu, 09 Dec 2010 17:24:50 +0000
- Subject: Re: [PATCH 4.0/4 v3] MIPS/GAS: Propagate symbol attributes
- References: <alpine.DEB.1.10.1007260105250.29495@tp.orcam.me.uk> <alpine.DEB.1.10.1010291526390.25860@tp.orcam.me.uk> <87y69gm0ex.fsf@firetop.home> <alpine.DEB.1.10.1012081023090.5345@tp.orcam.me.uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
>> Sorry for not really getting to this patch when you posted the original
>> series. Do you actually have a "real world" use case for this though?
>> Why wouldn't you just put "fnord:" in the appropriate place?
>
> Please note this issue only affects disassembly -- I have not observed
> any other unexpected symptoms. In particular all the relocated entities
> referring to the symbols concerned get the ISA mode set regardless of this
> change.
>
> So it's not about whether we should treat these symbols as MIPS16 code
> references or not, but to match the reality and not mislead the user into
> thinking standard MIPS code is being concerned.
You haven't answered my question, or at least not in a way that
makes me understand it. The testcase in your original message
was a very artificial one, artificial enough that the correct
disassembly is open to debate. Do you have a real-world example
of people writing code like this?
Richard