This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 19/20] MIPS/GAS: Only set the MIPS16 flag if code produced
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: Catherine Moore <clm at codesourcery dot com>, binutils at sourceware dot org
- Date: Thu, 9 Dec 2010 16:14:22 +0000 (GMT)
- Subject: Re: [PATCH 19/20] MIPS/GAS: Only set the MIPS16 flag if code produced
- References: <alpine.DEB.1.10.1012012146200.14129@tp.orcam.me.uk> <87fwu9aka0.fsf@firetop.home>
On Tue, 7 Dec 2010, Richard Sandiford wrote:
> > gas/
> > * config/tc-mips.c (file_ase_mips16): Adjust comment.
> > (append_insn): Update file_ase_mips16.
> > (mips_after_parse_args): Don't set file_ase_mips16 here.
> >
> > gas/testsuite/
> > * gas/mips/elf_ase_mips16.d: Update test for new MIPS16 ASE flag
> > semantics.
> > * gas/mips/elf_ase_mips16-1.d: New test.
> > * gas/mips/nop.s: Source for the new test.
> > * gas/mips/mips.exp: Run the new test.
> >
> > binutils/testsuite/
> > * lib/binutils-common.exp (regexp_diff): Implement inverse
> > matching, requested by `!'.
>
> OK with a couple of niggles fixed:
>
> 1. The new test should be "elf_ase_mips16-2.d" rather than "-1.d".
> Either leave "elf_ase_mips16.d" with its current name or change
> the filename to "elf_ase_mips16-1.d". (The former seems less
> disruptive, but feel free to do the latter if you prefer.)
The Pascal indexing convention, eh? ;) OK, I'm not *that* orthodox (and
maybe not at all ;) ).
> 2. In this hunk:
>
> > -private flags = [0-9a-f]*[4-7c-f]......: .*[[,]mips16[],].*
> > +!private flags = .{1,8}: .*[[,]mips16[],].*
>
> I think it's better to make the inverted regexp as loose as possible.
> I.e.:
>
> !private flags = .*mips16.*
>
> if indeed that works.
That's better indeed, agreed. Why wouldn't it work?
Thank you for reviewing this series -- I'm dealing with your other points
now.
Maciej