This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHx3] LD plugins: matters outstanding.

On 15/10/2010 17:03, Richard Henderson wrote:
> On 10/15/2010 09:23 AM, Dave Korn wrote:
>> On 15/10/2010 16:52, Richard Henderson wrote:
>>
>>> I think it's slightly confusing that HAVE_WINDOWS_H is defined only if
>>> HAVE_DLFCN_H isn't.  I think it might be a tad better to also test
>>> HAVE_DLFCN_H in the ifdef around the include.
>>     Just checking: you mean like so, right?
>>
>>> #if !defined (HAVE_DLFCN_H) && defined (HAVE_WINDOWS_H)
>>> #include <Windows.h>
>>> #endif
> 
> Yep, thanks.
> 
> 
> r~

  All committed, now for the gcc side of things!

    cheers,
      DaveK
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]