This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCHx3] LD plugins: matters outstanding.
- From: Richard Henderson <rth at redhat dot com>
- To: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Tristan Gingold <gingold at adacore dot com>
- Date: Fri, 15 Oct 2010 09:03:36 -0700
- Subject: Re: [PATCHx3] LD plugins: matters outstanding.
- References: <4CB879B7.8080507@gmail.com> <4CB878C2.3080106@redhat.com> <4CB87FF4.8080104@gmail.com>
On 10/15/2010 09:23 AM, Dave Korn wrote:
> On 15/10/2010 16:52, Richard Henderson wrote:
>
>> I think it's slightly confusing that HAVE_WINDOWS_H is defined only if
>> HAVE_DLFCN_H isn't. I think it might be a tad better to also test
>> HAVE_DLFCN_H in the ifdef around the include.
>
> Just checking: you mean like so, right?
>
>> #if !defined (HAVE_DLFCN_H) && defined (HAVE_WINDOWS_H)
>> #include <Windows.h>
>> #endif
Yep, thanks.
r~