Re: [PATCH,committed] Fix NT weak undef aux symbol lookup [was Re: Oops, serious ld bug cropped up]

[Tristan Gingold <gingold at adacore dot com>]

On Oct 1, 2009, at 10:02 PM, Dave Korn wrote:

> Dave Korn wrote:
>
> >  Neither.  The undef symbol exists in two object files.  When  
> > relocating the
> > second, it looks up the symbol in the hash, finds the aux entry,  
> > looks up the
> > aux symbol index in that - but then assumes that the aux entry must  
> > be in the
> > same bfd's symtab, which isn't the case.  Shouldn't be at all hard  
> > to fix.
>
>  Trivial, in fact; a 6-character fix! :-)  We just use the auxbfd  
> field,
> because that is what it is for.
>
> 2009-10-01  Dave Korn  <dave.korn.cygwin@gmail.com>
>
> 	* cofflink.c (_bfd_coff_generic_relocate_section): Look for the aux
> 	symbol for a weak undef in the auxbfd, not the input bfd.
>
>  Built and regtested on i686-pc-cygwin, and verified that it  
> resolves the
> reported problem compiling gettext.
>
>  Committed to HEAD.  Tristan, I'm sure it's a formality, but, OK for  
> 2.20?

Sure.
Thank you for the quick fix.  I will run a new testsuite today and I  
will try to do the release on
Monday.

Tristan.