This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Add discriminator support to gas .loc directive

From: Nick Clifton <nickc at redhat dot com>
To: Cary Coutant <ccoutant at google dot com>
Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, Binutils <binutils at sourceware dot org>
Date: Fri, 03 Jul 2009 17:21:25 +0100
Subject: Re: [patch] Add discriminator support to gas .loc directive
References: <c17be2b30904201838nbb02752r9372787844a1634e@mail.gmail.com> <49ED7B85.7060606@redhat.com> <c17be2b30904211027w3e8359aen7cdf268cfee5b7f1@mail.gmail.com> <c17be2b30904211146u2f4c8ed2m967ca5d95d665318@mail.gmail.com> <49F16BFA.3040201@redhat.com> <c17be2b30904241133v1dc5a2a4s9484dda8bf5c1674@mail.gmail.com> <4A49F5A4.3040209@gmail.com> <c17be2b30906301338o34710fc8jf28067e603e8588b@mail.gmail.com>

Hi Cary,

It would be nice if the line table reader would silently ignore
opcodes it doesn't understand (as the DWARF spec suggests), but it
seems to be a deliberate decision here to complain, so I'll leave that
as is.

The reason for complaining about unrecognised opcodes is that:

A. They might be bugs in the code being examined and the user wants to know about them.

B. They might be new opcodes and producing a warning will prompt the maintainers to add code to handle them...

bfd/ChangeLog:

* dwarf2.c (decode_line_info): Ignore DW_LNE_set_discriminator.

Approved - please apply.

Cheers
  Nick

Follow-Ups:
- Re: [patch] Add discriminator support to gas .loc directive
  - From: Dave Korn

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]