Re: [PATCH] x86: fix inval-equ-2 gas test

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Apr 15, 2009 at 4:30 AM, Jan Beulich <jbeulich@novell.com> wrote:
> This is the patch addressing the issues raised in an earlier thread
> starting at http://sourceware.org/ml/binutils/2008-11/msg00130.html.
>
> gas/testsuite/
> 2009-04-15 ?Jan Beulich ?<jbeulich@novell.com>
>
> ? ? ? ?* gas/i386/inval-equ-2.s: Change to not make assumptions about
> ? ? ? ?internal (and possibly broken) behavior.
> ? ? ? ?* gas/i386/inval-equ-2.l: Adjust expectations.
>
> --- 2009-04-15/gas/testsuite/gas/i386/inval-equ-2.l ? ? 2008-03-03 16:28:58.000000000 +0100
> +++ 2009-04-15/gas/testsuite/gas/i386/inval-equ-2.l ? ? 2008-11-20 11:37:40.000000000 +0100
> @@ -1,19 +1,19 @@
> ?.*: Assembler messages:
> -.*:8: Error: .*
> -.*:8: Error: .*
> +.*:2: Error: .*
> +.*:6: Error: .*
> ?.*:8: Error: .*
> ?GAS LISTING .*
>
>
> ?[ ? ? ?]*1[ ? ?]+\.globl ?bar1
> -[ ? ? ?]*2[ ? ?]+\.set ? ?bar1,\(%eax\+1\)
> -[ ? ? ?]*3[ ? ?]+\?\?\?\? A12A0000 ? ? ? ? ? ? mov bar1,%eax
> +[ ? ? ?]*2[ ? ?]+\.set ? ?bar1,%eax
> +[ ? ? ?]*3[ ? ?]+\?\?\?\? A1000000 ? ? ? ? ? ? mov bar1,%eax
> ?[ ? ? ?]*3[ ? ?]+00
> -[ ? ? ?]*4[ ? ?]+\.set ? ?bar2,\(%eax\+1\)
> -[ ? ? ?]*5[ ? ?]+\?\?\?\? A12A0000 ? ? ? ? ? ? mov bar2,%eax
> -[ ? ? ?]*5[ ? ?]+00
> +[ ? ? ?]*4[ ? ?]+\.set ? ?bar2,%eax
> +[ ? ? ?]*5[ ? ?]+\?\?\?\? 89C0 ? ? ? ? ? ? ? ? mov bar2,%eax
> ?[ ? ? ?]*6[ ? ?]+\.globl ?bar2
> -[ ? ? ?]*7[ ? ?]+\.set ? ?bar3,\(%eax\+1\)
> -[ ? ? ?]*8[ ? ?]+\?\?\?\? A12A0000 ? ? ? ? ? ? mov bar3,%eax
> -\*\*\*\* ?Error:can't make global register symbol `bar3'
> -[ ? ? ?]*8[ ? ?]+00
> +[ ? ? ?]*7[ ? ?]+\.set ? ?bar3,%eax
> +[ ? ? ?]*8[ ? ?]+\.globl ?bar3
> +[ ? ? ?]*9[ ? ?]+\?\?\?\? 89C0 ? ? ? ? ? ? ? ? mov bar3,%eax
> +[ ? ? ?]*10[ ? ]+\.set ? ?bar4,%eax
> +[ ? ? ?]*11[ ? ]+\?\?\?\? 89C0 ? ? ? ? ? ? ? ? mov bar4,%eax
> --- 2009-04-15/gas/testsuite/gas/i386/inval-equ-2.s ? ? 2008-03-03 16:28:58.000000000 +0100
> +++ 2009-04-15/gas/testsuite/gas/i386/inval-equ-2.s ? ? 2008-11-20 11:36:43.000000000 +0100
> @@ -1,8 +1,11 @@
> ? ? ? ?.globl ?bar1
> - ? ? ? .set ? ?bar1,(%eax+1)
> + ? ? ? .set ? ?bar1,%eax
> ? ? ? ?mov bar1,%eax
> - ? ? ? .set ? ?bar2,(%eax+1)
> + ? ? ? .set ? ?bar2,%eax
> ? ? ? ?mov bar2,%eax
> ? ? ? ?.globl ?bar2
> - ? ? ? .set ? ?bar3,(%eax+1)
> + ? ? ? .set ? ?bar3,%eax
> + ? ? ? .globl ?bar3
> ? ? ? ?mov bar3,%eax
> + ? ? ? .set ? ?bar4,%eax
> + ? ? ? mov bar4,%eax
>

Those tests are added so that assembler won't crash on them. If you remove
those tests, someone may change assembler and assembler crash on them
again.


-- 
H.J.