This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix C++ no .eh_frame_hdr table will be created (PR 6893)


On Wed, 17 Sep 2008 17:41:07 +0200, Andreas Schwab wrote:
> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> > +# Exclude non-ELF targets.
> > +
> > +if ![is_elf_format] {
> > +    return
> > +}
> 
> This fails on ia64, because .cfi_* does not exist.

On Wed, 17 Sep 2008 17:50:10 +0200, Andreas Schwab wrote:
> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> > +	.section	sect, "axG", @progbits, sectgroup, comdat
> 
> This will also fail to assemble on arm because @ is a comment character.


I see now the other CFI-using testcases use an explicit list of targets.
Tested those listed below.

OK to apply?


Thanks,
Jan


2008-09-17  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* ld-elf/eh-group.exp: Execute only on tested targets supporting CFI.

--- ld/testsuite/ld-elf/eh-group.exp	17 Sep 2008 07:50:29 -0000	1.1
+++ ld/testsuite/ld-elf/eh-group.exp	17 Sep 2008 17:28:43 -0000
@@ -29,9 +29,13 @@
 # executable trying to create .eh_frame_hdr.  It needs a separate .exp file due
 # to the requirement of two `ld' runs.
 
-# Exclude non-ELF targets.
+# Exclude non-ELF targets and targets not supporting CFI.
 
-if ![is_elf_format] {
+if { ![is_elf_format] \
+     || (![istarget i?86-*-linux*] \
+	 && ![istarget powerpc*-*-linux*] \
+	 && ![istarget s390*-*-linux*] \
+	 && ![istarget x86_64-*-linux*]) } {
     return
 }
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]