This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: S/390: Fix instruction type of efpc and sfpc - take 2
- From: Martin Schwidefsky <schwidefsky at de dot ibm dot com>
- To: Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 19 Feb 2007 19:07:42 +0100
- Subject: Re: PATCH: S/390: Fix instruction type of efpc and sfpc - take 2
- References: <20070216144020.GA31589@blc4eb430604175.ibm.com>
- Reply-to: schwidefsky at de dot ibm dot com
On Fri, 2007-02-16 at 15:40 +0100, Andreas Krebbel wrote:
> So someone indeed added a pointless dummy parameter to glibc inline assembly
> instructions instead of fixing a typo in binutils - mmmh.
>
> As you've proposed offline, I've made the extra operand optional so that
> now at least the correct versions of the instructions are accepted as well.
> objdump still prints efpc and sfpc with the dummy operand. That's a bit
> annoying but at least backward compatible.
>
> OK?
objdump ignores the S390_OPERAND_OPTIONAL flag and prints the full
instruction format. We could think about skipping optional operands in
the objdump output if the value of the operand is 0.
Anyway, I've committed the patch.
--
blue skies, IBM Deutschland Entwicklung GmbH
Martin Vorsitzender des Aufsichtsrats: Johann Weihen
Geschäftsführung: Herbert Kircher
Martin Schwidefsky Sitz der Gesellschaft: Böblingen
Linux on zSeries Registergericht: Amtsgericht Stuttgart,
Development HRB 243294
"Reality continues to ruin my life." - Calvin.