This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA/PATCH] Fix recognition of NT_PRXFREG notes

After Alan's 2002-06-25 change some tests in GDB's testsuite have been
failing on Linux.  Turns out the current code that reads NT_PRXFREG
notes expects note->namesz to be 5, but with the trailing 0, the
length of "LINUX" is 6.  Turns out the Linux kernel doesn't include
the trailing 0 in the name size.  According to the Systemm V ABI the
trailing 0 should be included, so Alan's change is correct and Linux
is wrong here.  But since changing the Linux kernel isn't going to
happen overnight, I propose the attached fix.

Ok to check this in?


Index: ChangeLog
from  Mark Kettenis  <>

	* elf.c (elfcore_grok_note): Fix recognition of NT_PRXFREG notes.

Index: elf.c
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.152
diff -u -p -r1.152 elf.c
--- elf.c 4 Jul 2002 13:26:30 -0000 1.152
+++ elf.c 4 Jul 2002 14:54:36 -0000
@@ -6718,8 +6718,7 @@ elfcore_grok_note (abfd, note)
     case NT_PRXFPREG:		/* Linux SSE extension */
-      if (note->namesz == 5
-	  && ! strcmp (note->namedata, "LINUX"))
+      if (strncmp (note->namedata, "LINUX", 5) == 0)
 	return elfcore_grok_prxfpreg (abfd, note);
 	return true;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]