This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
re: x86 gas regression?
- To: Alan Modra <amodra at bigpond dot net dot au>
- subject: re: x86 gas regression?
- From: matthew green <mrg at cygnus dot com>
- Date: Tue, 17 Jul 2001 17:29:20 +1000
- Cc: binutils at sources dot redhat dot com
- organisation: Red Hat, Inc.
On Mon, Jul 16, 2001 at 11:10:11PM +1000, matthew green wrote:
>
> when building the netbsd kernel with the latest gas, i'm noticing that
> an expression previously allowed is no longer valid. specifically, the
> / operator seems to generate errors:
See gas/config/tc-i386.c:comment_chars around line 160.
thanks. is this patch OK to commit?
.mrg.
* config/tc-i386.c (comment_chars): Don't use '/' as comment start if
TE_NetBSD.
(line_comment_chars): Set to '/' if TE_NetBSD.
Index: config/tc-i386.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-i386.c,v
retrieving revision 1.99
diff -p -r1.99 tc-i386.c
*** tc-i386.c 2001/06/21 06:12:10 1.99
--- tc-i386.c 2001/07/17 07:28:45
*************** const char extra_symbol_chars[] = "*%-("
*** 157,163 ****
/* This array holds the chars that always start a comment. If the
pre-processor is disabled, these aren't very useful. */
! #if defined (TE_I386AIX) || ((defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF)) && ! defined (TE_LINUX) && !defined(TE_FreeBSD))
/* Putting '/' here makes it impossible to use the divide operator.
However, we need it for compatibility with SVR4 systems. */
const char comment_chars[] = "#/";
--- 157,163 ----
/* This array holds the chars that always start a comment. If the
pre-processor is disabled, these aren't very useful. */
! #if defined (TE_I386AIX) || ((defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF)) && ! defined (TE_LINUX) && !defined(TE_FreeBSD) && !defined(TE_NetBSD))
/* Putting '/' here makes it impossible to use the divide operator.
However, we need it for compatibility with SVR4 systems. */
const char comment_chars[] = "#/";
*************** const char comment_chars[] = "#";
*** 175,181 ****
#NO_APP at the beginning of its output.
Also note that comments started like this one will always work if
'/' isn't otherwise defined. */
! #if defined (TE_I386AIX) || ((defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF)) && ! defined (TE_LINUX) && !defined(TE_FreeBSD))
const char line_comment_chars[] = "";
#else
const char line_comment_chars[] = "/";
--- 175,181 ----
#NO_APP at the beginning of its output.
Also note that comments started like this one will always work if
'/' isn't otherwise defined. */
! #if defined (TE_I386AIX) || ((defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF)) && ! defined (TE_LINUX) && !defined(TE_FreeBSD) && !defined(TE_NetBSD))
const char line_comment_chars[] = "";
#else
const char line_comment_chars[] = "/";