• PatchworkReviewMeetings

Patchwork Review Meetings

The community uses a Patchwork v3 instance to track community submitted patches.

Everyone in the community is invited to attend a weekly Monday patchwork review meeting.

The meetings will be held at the following times:

• Monday at 0900h EST5EDT

Other meeting times may be added in the future to cover additional timezones.

The focus of the meeting is to review the patchwork queue here: https://patchwork.sourceware.org/project/glibc/list/

The intent is to find reviewers for patches and move patches forward along one of the states in the patchwork workflow: https://sourceware.org/glibc/wiki/Patch%20Review%20Workflow

Please set your Profile->Items per page to "500" for the meeting.

Please set your Profile->Show Patch IDs enabled to allow patch IDs to be used for meeting review.

Meetings will not be recorded, but notes from the meetings will be taken and recorded on this page.

Process:

• Show patches with: State = NEW, Delegate = Nobody

  • Use this query.

• Review newest patches looking for critical action items.
  • Record the patch at which review started.
• Delegate patches for review throughout the meeting.
  • Developers present in the meeting may assign patches to volunteers in the reviewer pool.
• Record the patch at which review stopped.
  • This allows external observers to know which range of patches was reviewed and coordinate review.
• At the 30 minute mark go through the attendees and request items that they would like to discuss for review.

• Send out meetings notes to libc-alpha@sourceware.org .

  • CC: absent developers from the reviewer pool who were assigned patches
• Attach meetings notes below.

Patch Reviewer Pool: (for background see https://sourceware.org/pipermail/libc-alpha/2024-February/154455.html)

• <Patchwork username> : <Email>

• azanella : Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>

• arjun : Arjun Shankar <arjun@redhat.com>

• codonell : Carlos O'Donell <carlos@redhat.com>

• dj : DJ Delorie <dj@redhat.com>

• fweimer : Florian Weimer <fweimer@redhat.com>

• maximk : Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>

• schopin : Simon Chopin <simon.chopin@canonical.com>

• Wilco: Wilco Dijkstra <Wilco.Dijkstra@arm.com>

Next Meeting: 2024-12-23 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2024-12-16 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 493 patches.
• Starting 103137.
• [v2] Replace copysign (0,-1) with -0.0 in initializer (HJ)
  • Carlos: I'll ping Maciej on this patch.
• [v2] RISC-V: Regenerate ULPs (Aurelien)
  • Reviewer Pool: Arjun Shankar
• Raise the minimum GCC version to 11.1 (HJ)
  • HJ: Yes, Intel wants to support older glibc releases.
  • Florian: If we need to backport things from upstream that need GCC11 then we have more work to do. Can we keep source level compatibility where required?
  • Carlos: What is the distribution impact?
  • Calros: Florian may you please respond to the thread and add the requirement that we want to maintain sourc-level compatibility by turning on the newer compiler warnings?

• [RFC] Test/Math: Use better result for cbrtl (YunQiang)

  • Rejected by Paul Zimmerman. Needs further review upstream.
• Add further DSO dependency sorting tests (Joseph)
  • Reviewer Pool: Carlos
• [v4] manual: Document more sigaction flags (DJ)
  • Reviewer Pool: Florian
• aarch64: Add support for Guarded Control Stack extension (Yury)
  • Patch 20 and 9 lack RBs.
  • Carlos: I'll review patch 9, 20.
  • Patch 20 is for Adhemerval's comments about making new properties generic.
  • Discussed static exectuables being built from the released sources.
  • Yury: If static executables don't have GCS they won't execute the code, but if they do have GCS enabled the static executables.
  • Stopping at 102889.
• Discussed SHARED-FILES in the context of the Arm Optimized Routines library.
• HJ: I've been working on the other compilers to pass the glibc build. Currently with 1 patch pending for the copy-sign thing, we can use gcc up to 4.9 to test. No regressions. We cannot go beyond 4.9 because some header files use stdatomic.h extensively both in glibc sources and tests. Tried to make 4.8 to work but it doesn't work. Test glibc build with clang. I don't know if the two header files in clang are new or not, but because of them clang can't be used to build glibc.
  • Carlos: remotes/origin/azanella/clang
• HJ: clang can't be used to test glibc if float.h or tgmath.h are used. Likewise you can't use clang testing for libmvec.
  • Florian: Only applies to configuration file parsing, it's a bug, but not a security bug.
• Andreas: What is the status of Series 41054 for extensible rseq
  • Florian: Reviewing TLS and dyanmic loader interactions. The intent is to have it reviewed and ready for this relase.

Meeting: 2024-12-09 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODOY at 517.

• Starting at 102681
• Florian has to leave at the half-hour.
• Carlos: Status of getenv?
• Florian: Incremental improvement and fixes are in place for 2.41.
• Florian: Commented on the pthread_condvar fixes.
  • Carlos: Note that this is not in-place-upgrade safe, but I'll go back and review what we can do in the case of pshared=1 for the condvar recovery.
  • Fix unbalanced nwaiters counting in sem_wait (bug 32436) (Andreas)
    • Reviewer Pool: Adhemerval.
• [v5] Add TEST_CC and TEST_CXX support (HJ)
  • Changes requested by Sam James.
  • Carlos: Noted that this fails CI.
• [v3] ungetc: Guarantee single char pushback (Siddhesh)
  • Asked Maciej for review to get this ready.
• [v1] powerpc64le: ROP Changes for context/Jump assembly (Sachin)
  • Review requested from Peter Bergner.
• Andreas: Ran into issues running the glibc testsuite because the gawk mp was not enabled during build. The more difficult issues is that mpfr usage in gawk may not be supported in the future and gawk suggests we not use the features.
  • Carlos: Yes, this would need changes to the test cases to not use gawk.

  • Note 1: https://www.gnu.org/software/gawk/manual/html_node/MPFR-On-Parole.html

  • Note 2: https://inbox.sourceware.org/libc-alpha/4940805.GXAFRqVoOG@pinacolada/

• Andreas: What features and patch series should be in 2.41?

  • https://inbox.sourceware.org/libc-alpha/1985353.PYKUYFuaPT@pinacolada/

  • Discussed briefly MADV_GUARD_INSTALL/REMOVE which is very new and present only since October 2024. Needs review and implementation in glibc.
• Yury: v5 doesn't yet fix the suggestion that Adhemerval makes for layering with memory sealing.

Meeting: 2024-12-02 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 462 patches.
• Starting at 102219.
• [v6] malloc: Optimize small memory clearing for calloc (HJ)
  • Reviewer Pool: Wilco Dijkstra
• elf: Check PDE load address with non-empty text section (HJ)
  • fweimer: Stefan is looking at the s390.
  • Patch fixes the aarch64.
  • Reviewer Pool: Florian Weimer
• support: Enhance support_need_proc (fweimer)
  • Reviewer Pool: Adhemerval.
• [v2] ungetc: Guarantee single char pushback (Siddhesh)
  • Assigned to fweimer given previous reviews.
• [v4] aarch64: Add support for Guarded Control Stack extension (Yury)
  • yury: Looking for review from another developer to see if we missed anything in the implementation. Still waiting for the upstream kernel HWCAP constant, new constants for prctl, and gcs magic used in the ucontext to identify portion that is related to gcs.
  • Reviewer Pool: Carlos O'Donell
• Stopping at 102126.
• Add remaining CORE-MATH binary32 implementations to libm (azanella)
  • adhemerval: Joseph gave some small comments, but not quite related.
  • Noted that some of the Intel math library code is available in OpenJDK.
  • Reviewer Pool: DJ.
• la_objclose fixes (bug 31985, bug 32065, 32066) (Florian)
  • Reviewer Pool: Adhermval.
• Wilco: Commited the memset fixes for aarch64.

Meeting: 2024-11-25 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 430 patches.

• Florian has a meeting conflict so discussing his issues first.
• Discussed Michael Jeansons status and that he should use Carlos' email and status to get an account setup.
• Adhemerval: Do you need anything else for getenv patches?
  • Florian: It would be nice to have the environment changes.
  • Adhemerval: Can we live without it for the next release?
  • Florian: Yes.
• Florian: Wilco, Do you need anything from me?
  • Wilco: Working on the aarch64 memset issue.
• Carlos: We discussed some pre-commit CI for aarch64 that might have 128-byte cache line that triggers the issue... it is mostly about increasing the coverage?
• Adhemerval: Can we improve the test coverage? Cache line emulation so we can have test these parameters.
• Carlos: Just running str* and mem* testing?
• Wilco: Running the whole testsuite is going to be very costly. Just running the limited tests is going to be enough to crash.
• Adhemerval: I will talk to the Linaro QEMU team to discuss changing the cache line sizes.
• Starting at 101830.
• Remove unused dl-procinfo.h (Wilco)
  • Reviewer Pool: Ahdemerval.
• sysdeps: linux: Fix output of LD_SHOW_AUXV=1 for AT_RSEQ_*
  • codonell: Accepted. Adhemerval to commit.
• [v2] Add threaded test of sem_trywait (Joseph)
  • codonell to review again v2.
• [v3] powerpc64le: ROP Changes for strncpy/ppc-mount
  • Under review bergner.
• [v4] libio: Add test case for fflush (Frederic Berat)
  • Reviewer Pool: fweimer
• [v3] nptl: Add smoke test for pthread_getcpuclockid failure (Siddhesh)
  • Superseded.
• getaddrinfo() does not detect invalid numeric services (bug 16208) (Petr)
  • Conflics with "nss: reject invalid port passed to getaddrinfo [BZ #16208]"
  • codonell: Updated the queues to have Antonio's fix be changes requested.
  • This patch is still in play.
  • Reviewer Pool: Wilco
• Implement ipv4+ipv6 flags in resolv.conf (Petr)
  • Carlos: Noted that this fails pre-commit CI.
• Add rseq extensible ABI support (Michael)
  • Delegated to Florian who is discussing pushing this with Michael.
• [v7,0/1] stdio-common: Add more tests of the setvbuf()function.
  • Needs reposting for CI to trigger. Notified DJ and Nick.
• [v2] math: Add internal roundeven_finite (Adhemerval)
  • Reviewer Pool: DJ Delorie
• [v4] malloc: send freed small chunks to smallbin (Aleksa Siriški)
  • Carlos: Note here that this can be accepted from k4lizen.
• Stopped at 101558.

Meeting: 2024-11-18 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• ​* State NEW delegate NOBODY at 475 patches.
• htl: move pthread_attr_* into libc
  • Let the Hurd developers handle it
• [v2] elf: Second ld.so relocation only if libc.so has been loaded
  • Wait until next week for further review
• [v2] Silence most -Wzero-as-null-pointer-constant diagnostics
  • Assigned to azanella
• Add multithreaded test of sem_getvalue
  • Assigned to arjun
• [v3] libio: Add test case for fflush
  • Assigned to fweimer
• [1/3] aarch64: Fix thunderx memcpy
  • Waiting for a new version that remove all the ThunderX implementation.
  • Assigned the Oryon ones to azanella
• [v1,1/1] assert: ensure posix compliance, add tests for such
  • Failed CI
• [v3] powerpc64le: _init/_fini file changes for ROP
  • Let PowerPC maintainers to handle it
• stdio-common: Add more tests of the setvbuf()function.
  • Assigned to fweimer
• [v2] powerpc64le: Optimized strcat for POWER10
  • Let PowerPC maintainers to handle it
• Add more CORE-math implementations to libm
  • Assigned to DJ
• localedata: Update ar locales abbreviations [BZ #32349]
  • Assigned to mfabian
• Guarantee first pushback in ungetc and ungetwc
  • Assigned to fweimer
• [v2] RISC-V: Use builtin for ffs and ffsll while supported extension available
  • Let RiscV maintainer to handle it.
• use memmove for potentially overlapping data
  • Marked as rejected.
• [v2] nptl: Add new test for pthread_spin_trylock
  • fweimer approved
• AArch64: Remove unused _dl_aarch64_cap_flags
  • Superseeded
• Stopped at 100341
• Florian
  • getenv() patches
• Wilco
  • AArch64-specific pkey
  • pthread_mutex_t size issues.

Meeting: 2024-11-11 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2024-11-04 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 450 patches.

• Carlos's SLI at 412 days average patch age in queue and 187112 accumulated patch days.

• nptl: fix builtin_thread_pointer detection on LoongArch (Caiyinyu)

  • Reviewer Pool: Arjun

• Add Arm HWCAP2_* constants from Linux 3.15 and 6.2 to <bits/hwcap.h> (Aurelien)

  • Review: Yury
• [v3] Add test of ELF hash collisions (Joseph)
  • Review: fweimer

• nptl: Add <thread_pointer.h> for * (Michael)

  • Reviewer Pool: Arjun
• aarch64: Add support for memory protection keys (Yury)
  • Reviewer Pool: Adhemerval
• [v4] malloc: send freed small chunks to smallbin (k4lizen)
  • Reviwer Pool: DJ
• elf: More careful placement of the main malloc switch (Florian)
  • Preview review from DJ.
  • Review: DJ.
• [v2] powerpc64le: _init/_fini file changes for ROP (Sachin)
  • Email sent to Peter Bergner (IBM) for discussion about IBM specific reviews.
• Stopping at 99850.
• Florian: Looking at the arc4random v10 patch, should have comments in today.

  • Carlos: Are there any comments about P&C around the relaxed MO loads?

  • Florian: Implied by the signal fence.
• risc-v: Enable vectorized memset via ifunc (Jeff Law)
  • Changes requested from Andreas.
• locale: More strictly implement ISO 8601 for Esperanto locale (Carmen)
  • Changes requested by Wilco.
• [v7] elf: Handle static PIE with non-zero load address [BZ #31799] (HJ)
  • Reviewer, Carlos still wants to review it.
• Stopped at 99327.

Meeting: 2024-10-28 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 494 patches.

• Carlos's SLI at 370 days average patch age in queue and 184401 accumulated patch days.
• Starting at 99667.
• [v7] elf: Handle static PIE with non-zero load address [BZ #31799] (HJ)
  • Reviewer Pool: Carlos
  • Previously assigned v5 to Carlos for review to gather consensus on decision.
• [1/2] Revert "elf: Run constructors on cyclic recursive dlopen (bug 31986)" (Florian)
  • Carlos: Revert should be pushed per policy for reverts. The new test needs review though.
  • Carlos: Commented on list for the revert.
• Add test of ELF hash collisions (Joseph)
  • Reviewr Pool: Florian.
• Add more CORE-MATH on libm (Adhemerval)
  • Carlos: I can't review the correctness of the implementation, but I think we can review the import.
  • Reviewer Pool: DJ Delorie
  • The review here is mechanical in nature, license, and other things that are already approved. The structure of the changes matter for integration into glibc.
• libio: Correctly link tst-popen-fork against libpthread (Arjun)
  • Superseded.
• [v10] linux: Add support for getrandom vDSO (Adhemerval)
  • Florian to review.
• aarch64: Small optimisation in AdvSIMD erf and erfc (Joe)
  • Carlos: Asked if there was a microbenchmark to show the benefit?
• elf: Change ldconfig auxcache magic number (bug 32231) (Florian)
  • Approved by Adhemerval.
  • Adhemerval: Confirmed that this was OK to backport.
  • Carlos: No objections, it should be safe to backport to a point just before the change that introduces the format change.

• nptl: Add <thread_pointer.h> for LoongArch (Michael)

  • Reviewer Pool: Arjun

• nptl: Add <thread_pointer.h> for sparc (Michael)

  • Reviewer Pool: Arjun

• nptl: Add <thread_pointer.h> for m68k (Michael)

  • Reviewer Pool: Arjun
• Stopped at 99382 with the Arm GCS patches.
• Adhemerval: getrandom?
  • Florian will look at this again this week.
• Carlos: What about getrandom improvements?
  • Adhemerval: I can look at this again this week.
• Carlos: Downstream testing is ongoing for pthread condvar signal stealing fix.
  • Carlos: I think we should accept Malte and Frank's patch, and then improve the testing.
• aarch64: Add support for Guarded Control Stack extension (Yury)
  • Reviewer Pool: Wilco.

Meeting: 2024-10-21 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• ​State NEW delegate NOBODY at 471 patches.
• Discussed briefly "[v8] linux: Add support for getrandom vDSO" and Carlos handed back to Florian for final review.
• Starting at 99227.
• [RFC] realloc: Make REALLOC_ZERO_BYTES_FREES into a tunable (Siddhesh)
  • Marked RFC
• [RFC] rseq: Validate read-only fields under DEBUG_RSEQ config (Mathieu)
  • Mark NA (kernel patch)
• Add more tests of pthread_mutexattr_gettype and pthread_mutexattr_settype (Joseph)
  • Reviewer Pool: Adhemerval
• [v2] libio: Fix a deadlock after fork in popen (Arjun)
  • Reviewer Pool: Carlos
• [v2] stdio-common: Fix scanf parsing for NaN types [BZ #30647] (Avinal)
  • Reviewer Pool: Arjun
• aarch64: Add support for Guarded Control Stack extension (Yury)
  • Carlos: Marked RFC.

• RISCV:Add builtin for some riscv version function (wangboyao)

  • Marked as failed CI.
• Check time arguments to pthread_timedjoin_np and pthread_clockjoin_np (Joseph)
  • Reviewer Pool: DJ
• Add .b4-config file (Jonathan)
  • Florian to review and approve, since it looks sensible.
• rtld: Move architecture specific struct last in _rtld_global_ro (BZ #32279) (Wilco)
  • Wilco: If you change architecture specific features then it changes the whole structure layout.
  • Florian: The structure helps optimize access to the structure members. Do we need this optimization today?
  • Carlos: Note that this causes upgrade issue.
  • Wilco: Look at revising to make this a distinct global.
  • Marked changes requested.
• Adhemerval: Use a gnu attribute for memory sealing to support non-dyanmic scenarios of static link non-pie.
  • Improve executable stack handling (Adhemerval)
    • With Florian for review.
    • Florian and Adhemerval discussed the status of the patch.
• AArch64: Use bitfield in cpu_features struct (BZ #32279) (Wilco)
  • Carlos: What about this one?
  • Wilco: I'll discuss with Florian.
• [v4] nss: reject invalid port passed to getaddrinfo [BZ #16208] (Antonio)
  • Reviewer Pool: Wilco.
• Stopping at 99066.

Meeting: 2024-10-14 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2024-10-07 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 429 patches.

• Carlos's SLI at 406 days average patch age in queue and 176126 accumulated patch days.
• Starting at 98405.
• rt: more clock_nanosleep tests (DJ)
  • Reviewer Pool: Adhemerval.
• [v3,0/1,v3] stdio-common: Add more tests of the setvbuf() function. (Nick)
  • Carlos: I'll review this one.
• [v2] error: Don't call va_end twice [BZ #32233] (Collin)
  • Carlos: Changes requested update to SHARED-FILES
• io: statx, fstatat: Drop nonnull attribute on the path argument (Xi)
  • Reviewer Pool: Carlos
• [v5] stdlib: Make abort/_Exit AS-safe (BZ 26275) (Adhemerval)
  • Reviewer Pool: DJ
• linux: Add openat2 (BZ 31664) (Adhemerval)
  • Reviewer Pool: Florian
• mktime tm_isdst compatibility improvements (Florian)
  • Ongoing discussions with Paul Eggert about the functionality.
  • Some patches need direct review.
• Add support for memory sealing (Adhemerval)
  • Adhemerval: Previous feature was opt-out, sealing is always applied, but this version is opt-in.
  • This should be enabled for static binaries.
  • Need to figure out how to enable this for binutils.
• Stopping at 98185.
• Adhemerval: Note that Jason may chime in about getrandom vdso.
  • Carlos: I'll review this since Florian is out.
• Andre: Talk about GCS and current plan and forthcoming patches.
  • Binutils patches will go in as soon as we can.
  • Focus on glibc. Would like to get this in for 2.41.
  • Kernel patches are going to be relead by 6.13 which is end of January.
  • There are going to be some features exposed by the kernel including AT values and a syscall.
  • Carlos: Any way that we can make this be enabled post-release in the stable branch?
• Yury: I had a question about memory protection key patch, but I'll respond to Adhemerval.

Meeting: 2024-09-30 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 460 patches.
• Carlos's SLI at 374 days average patch age in queue and 173645 accumulated patch days.
• Starting at 98157.
• nss: look for databases in /usr/share/nss/ if they don't exist in /etc/ (Lennart)
  • Florian: I'll review that one.
• Teach glibc about possible page sizes and handle gaps in ld.so (Florian)
  • Reviewer Pool: Adhemerval.
• [v1] x86/string: Fixup alignment of main loop in str{n}cmp-evex [BZ #32212] (Noah)
  • Accepted. HJ reviewed.
• [v8] linux: Add support for getrandom vDSO (Adhemerval)
  • Carlos: Florian, will you review this one?
  • Florian: Yes, assigned to me.
• [v2,1/1] stdio-common: Add more tests of the setvbuf() function. (Nick)
  • Carlos: I'm going to review this one. Assigned to me.
• S390: Don't use r11 for cu-instructions as used as frame-pointer. [BZ# 32192] (Stefan)
  • Florian: Looks, reasonable, I can just ack it?
  • Carlos: Please and thank you.
• [v2] Add a new fwrite test that exercises buffer overflow (Tulio)
  • Already reviewed and accepted. Tulio should push.
• [v3] aarch64: Add support for memory protection keys (Yury)
  • Yury: Final patch, previous versions were RFE.
  • Carlos: Florian, Any preconditions? Testing?
  • Florian: I could try to rebase my RELRO patches to do a non-synthetic test case?
  • Adhemeral: Please assign to me, I'll review.
  • Assigned to Adhemerval.
• stdio-common: Add new test for fdopen (Sergey)
  • Carlos: Failed CI. Old v1, superseded.
  • Adhemeral: Why didn't this fail?
  • Florian: Might be toolchain defaults?
  • We currently have both fortify source on and off via the Intel and Arm builders.
• io: statx, fstatat64: allow using NULL as path (Miao Wang)
  • Florian: I commented on this.
  • Note there were some email bounces here.
• Stopped at 97558.
• Adhemerval: getrandom vDSO, Make accounting database no-op, Make abort() AS-Safe.
  • [v4] stdlib: Make abort/_Exit AS-safe (BZ 26275) (Adhemerval)
    • This patch could use review and comments.
  • Carlos: What about "linux: Do not spawn a new thread for SIGEV_THREAD (BZ 30558, 27895, 29705) (Adhemerval)"? We should fix this kind of robustness issue.

• Florian: Review this? "[v4] Do not export <alloc_buffer.h> functions from libc (Florian)"

  • Carlos: I'll review this.
• Florian: What about the condition variable fix?
  • Carlos: Waiting on downstream feedback to a deployed test fix. There are two ABAs we need to fix, one doesn't matter, one does.
• Adhemerval: What else do we need to handle the core math implementation changes?
  • Carlos: Nothing, all the SOBs are there.
  • Florian: LICENSES file needs an update and that can be done in a separate commit.
• Andreas: Nothing to raise.
• Carlos: Note that there are rand patches from Wilco we need to review.
• Yury: Nothing from me.

Meeting: 2024-09-23 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Patch queue review notes
  • Starting at patch 97857. 465 patches in the queue.
  • arcb big-endian removal
    • Florian considers this reviewed by the ARC maintainer and will push.
  • RISC-V rseq-related changes
    • Florian to ping the RISC-V maintainers. Also pending review:
      • [1/2] RISC-V: Add implementation for fmaximum and fminimum
      • RISC-V: Use builtin for copysign and copysignf
      • RISC-V: Use builtin for fma and fmaf

  • LoongArch: Undef NR_fstat and NR_newfstatat.

    • Florian to ask Adhemerval if he has further comments.

    • How does this related to “LoongArch: Add fstat64 and fstatat64.”?

  • Add a new fwrite test that exercises buffer overflow
    • Florian to ping Joseph if he can review this given his recent fread test work.
  • [v8] replace tgammaf by the CORE-MATH implementation
    • Potentially blocked by the LICENSES situation
  • Stopped at 97175.
• Review assignments
  • azanella:
    • [v2] Add freopen special-case tests: thread cancellation
  • arjun:
    • [RFC] manual: Document how types change
  • carlos:
    • debug: Suppress FAIL macro redefinition warning in tst-fortify
  • dj:
    • [1/3] Do not use -Wp to disable fortify (BZ 31928)
    • [2/3] Disable _FILE_OFFSET_BITS if the compiler defaults to it
    • [3/3] Disable _TIME_BITS if the compiler defaults to it
  • fweimer:
    • [v2] arc: Cleanup arcbe
    • [v7] linux: Add support for getrandom vDSO
    • [2/2] sparc: Fix restartable syscalls (BZ 32173)
    • [v2] stdio-common: Add tests for formatted printf output specifiers
  • Wilco Dijkstra: (Patchwork account unclear);
    • aarch64: Simplify rounding-multiply pattern in several AdvSIMD routines
    • aarch64: Improve codegen in users of AdvSIMD log1pf helper
    • aarch64: Improve codegen in users of ADVSIMD expm1f helper
    • aarch64: Improve codegen in SVE F32 logs

    • aarch64: Improve codegen in SVE expf & related routines

• Open floor
  • Yury khrustalev mentions that the protection key patch for aarch64 has been superseded

    • old version: [RFC v2] aarch64: Add support for memory protection <20240718103115.22003-1-yury.khrustalev@arm.com>

Meeting: 2024-09-16 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Note: Many developers at GNU Tools Cauldron so this call may be empty.

Meeting: 2024-09-09 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW and delegate NOBODY at 457 patches.

• Carlos's SLI at 356 days average patch age in queue and 167306 accumulated patch days.
• Starting at 97340.
• [v2] math: Improve layout of expf data (Wilco)
  • Reviewer Pool: Adhemerval
  • Carlos sent DJ a note about the failed to apply not having text for it.
• [v3] debug: Fix read error handling in pcprofiledump (Florian)
  • Needs a v4.
• tst: Extend cross-test-ssh.sh to support passing glibc tunables (Yury)
  • Reviewer Pool: Arjun
• [v2] nss: reject invalid port passed to getaddrinfo [BZ #16208] (Antonio)
  • Reviewer Pool: Carlos
• aarch64: Avoid redundant MOVs in AdvSIMD F32 logs (Joe)
  • Already pushed.
  • Note that Wilco's response didn't get included in the thread. Need to review why.
• [v2] libio: Fix crash in fputws [BZ #20632] (Peter)
  • Assigned to Florian for review.
• Optimization and benchmarking of bsearch() (Kuwan-Wei)
  • Patch 2 reviewed by Noah Goldstein already.
  • Need review of patch 1 for the benchmark.
  • Reviewer Pool: DJ Delorie.
• elf: Initialize tunables_env_alias with loop to avoid memset (Jesse)
  • Patch dropped.
• [v3] libio: Set _vtable_offset before calling _IO_link_in [BZ #32148] (HJ)
  • Reviewer Pool: Florian
• Stopping at 97282.
• Anything to raise for review?
• Adhemerval: Yes, [v4] linux: Add support for getrandom vDSO (96923)
  • Florian: Surprised that this isn't faster than 2x?
  • Adhemerval: The larger stressng buffer makes this slower. For a small buffer the speedup is up to 10x speedup.
  • Discussed adding cancellation to the implementation and that you could internally call with GRND_NONBLOCK first and then fall back to a cancellable syscall.
  • Does the small size buffer fast path still remain cheap?

  • Note about vDSO unwinding: https://bugzilla.redhat.com/show_bug.cgi?id=2044483#c3

• Florian: The asprintf patch: [v4] libio: asprintf should write NULL upon failure
  • Carlos: It is in my review queue, but getenv hardening is ahead of this.
• Adhemerval: What about the RELRO patch series? "RELRO linkmaps"?
  • Florian: There is an attack vector around DT_DEBUG and the ld.so link map. If you have memory protection keys it is really fast. You need a memory protection key with signal semantics that work on lazy binding.
• Adhemerval: I don't want to block the sched_setattr, sched_getattr addition, just note the tradeoff.

Meeting: 2024-09-02 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and restart review at the top. ​

• State NEW delegate NOBODY at 447 patches.
• Starting at 96865

• [v2] LoongArch: Fix macro redefined warning in tls-desc.S

  • arch maintainer will handle it
• [RFC] Optimize bsearch() implementation for performance
  • Benchmark should be required to evaluate the numbers.
• Add more thorough tests of freopen
  • Assigned to Florian
• FUSE-based testing for file system functions
  • Delegate to D.J
  • It has a regression on last patch.

• linux: mips: Fix syscall_cancell build for mips_isa_rev >= 6

  • azanella will commit it
• Test fclose on an unopened file.
  • Maybe acknoledge this a GNU extension
• Add a new fwrite test for read-only streams
  • Failed CI for some reason (fail to apply)
  • Delegate to azanella
• malloc: TCACHE improvement for free and calloc
  • Assigned to Florian
• [v5] linux: Add linux statx(fd, NULL, AT_EMPTY_PATH) support
  • Assigned to azanella
• [v3,1/2] Loongarch: adapt for the re-introduction of fstat and newfstatat in 6.11
  • arch maintainer will handle it
• Remove the LICENSES file
  • We will need some legal advice how to proceed
• [v7] replace tgammaf by the CORE-MATH implementation
  • Patch failed to apply
  • Should we commit in name of Paul or Alexei.
• [v3,1/2] Loongarch: adapt for the re-introduction of fstat and newfstatat in 6.11
  • Superseeded.
• Do not set errno for overflowing NaN payload in strtod/nan (bug 32045)
  • Approved.
• Improve NaN payload testing
  • Assigned to codonell
• fgets: more tests
  • Assigned to Florian
• Stopped: 96107
• Florian:
  • Want to discuss the license patch
• Szabolcs:
  • Review some Wilco patches
• Yury

  • https://patchwork.sourceware.org/project/glibc/patch/20240718103115.22003-1-yury.khrustalev@arm.com/

  • Superseeded, Yury will send a v3

Meeting: 2024-08-26 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 454 patches.

• Starting at 96493.
• [v7] replace tgammaf by the CORE-MATH implementation (Alexei)
  • Carlos to look at the license of the almost-final implementation.
  • Fails CI, but RH bot doesn't post information. Need to follow up with DJ.
  • Carlos following up with DJ.
• malloc: TCACHE improvement for free and calloc (Wangyang)
  • Reviewer Pool: Florian Weimer
• [v1] libio: Fix crash in fputws [BZ #20632] (Peter Amon)
  • Changes requested by Florian.
• [v2] nss: fix getaddrinfo() accepting garbage as valid IPv4 address (Miklos)
  • Florian requested an update on the reason for the patch, and tha should be in the commit message so marking Changes Requested.
• io: Add error tests for fchmod (Florian)
  • Reviewer Pool: Adhemerval
• support: Report errno constants in TEST_COMPARE failures (Florian)
  • Reviewer Pool: Arjun

• LoongArch: Fix macro redefined warning in dl-tlsdesc.S (Mengqing)

  • Reviewer Pool: Carlos
• FUSE-based testing for file system functions (Florian)
  • Reviewer Pool: DJ
• inet: Avoid label at end of compound statement in tst-if_nameindex (Florian)
  • Carlos: This is a trivial fix. Please push if it compiles.
• [v4] Loongarch: adapt for the re-introduction of fstat and newfstatat in 6.11 (Miao)
  • Adhemerval will review again since he looked at the other versions.
• [v2] linux: Add linux statx(fd, NULL, AT_EMPTY_PATH) support (Miao Wang)
  • Florian: We use statx for these calls on 32-bit targets for 64-bit time_t so this nees fixing.
  • Carlos: What do we do next?
  • Adhemerval: Upstream valgrind might have support for this but it requires updating valgrind on the bot instead of system valgrind.
  • The Linaro testers use system valgrind and would needto get update.
  • Florian: There are multiple problems. Valgrind is faking a resposne for rust compatibility.
  • Carlos: At the end of the day I would like the valgrind testing to continue because of the value, but we may need a way to incrementally test things like this without rolling out custom valgrind everywhere.
• Stopping at 96201.
• Carlos is moving to "elf: Handle static PIE loaded at the specific address" this week.

• Adhemerval: https://patchwork.sourceware.org/project/glibc/list/?series=36657

  • Florian and Adhemerval discussed the solution and switched to not supporting dlopen() if the stack needs to change.
• Carlos: Should we stop handing reviews into the reviewer pool if the reviewer has 10 or more reviews queued for review?
• [v4] libio: asprintf should write NULL upon failure (Florian)
  • Raised during the call since this is stuck and Florian would like to make progress.
  • Carlos will review this first.

Meeting: 2024-08-19 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 438 patches.

• Quick discussion among Adhemerval and Carlos about glibc security team topic.
• Starting at 96068
• [v2] x86: Add support for Hygon processors (Feifei)
  • Delegated to HJ for review.
• nss: fix getaddrinfo() accepting garbage as valid IPv4 address (Miklos)
  • Faild CI, needs re-submit.
• Fix strtod subnormal rounding (bug 30220) (Joseph)
  • Reviewer Pool: Adhemerval
• More thoroughly test underflow / errno in tst-strtod-round (Joseph)
  • Reviewer Pool: Arjun
• Add more tests of strtod end pointer (Joseph)
  • Reviewr Pool: Carlos

• [v2] Make strtod_internal tests type-generic (Joseph)

  • Reviewer Pool: DJ
• libio/tst-getdelim: fix verbose print (Frederic)
  • Reviewer Pool: Florian
• [v2] Make tst-strtod2 and tst-strtod5 type-generic (Joseph)
  • Reviewer Pool; Simon Chopin
• Test errno setting on strtod overflow in tst-strtod-round (Joseph)
  • Carlos: Looks like a conversation ensued on "overflow" meaning.
  • Florian: Maciej has comments.
  • Updated by Joseph, marked superseded, and noted that it was committed.
• Stopping at 95663 since we reached the end of new patches since last week.
• No further patches to review raised.

Meeting: 2024-08-12 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 442
• Carlos's SLI at 351 days average patch age in queue and 157590 accumulated patch days.
• Starting at 95663
• Update RISC-V relocations (Andreas)
  • Needs machine maintainer review. Ask Palmer to review?
• [v4] libio: asprintf should write NULL upon failure (Florian)
  • Reviewer Pool: Adhemerval Zanella Netto
• x86: Add support for Hygon processors (Feifei)
  • Patch fails CI and noted by Adhemerval, so needs work.

• [v2] x86: Add new cpu-flag Prefer_Non_Temporal (Noah)

  • Changes requested by HJ.
• x86: Unifies 'strnlen-evex' and 'strnlen-evex512' implementations. (Matthew)
  • Reviewer Pool: Carlos O'Donell
• Audit fixes for proxy link maps (Florian)
  • Pre-commit CI fails 32-bit Arm. Changes requested.
• [v2] Add more tests of getline (Joseph)
  • Florian to review since he reviewed v1.
• [v1] inet: test if_nametoindex and if_indextoname (DJ)
  • Reviewer Pool: Florian Weimer
• [v1] fgets: more tests (DJ)
  • Fails in pre-commit CI, and Carlos asked DJ to reach out to Adhemerval.
  • Reviewed the test result live on the call and it's a segfault in the test.
• [v2] string: strerror, strsignal cannot use buffer after dlmopen (bug 32026) (Florian)
  • Adhemerval to review.
• [v2] Make accounting database no-op (Adhemerval)
  • Florian to review.
• [v3] stdlib: Fix qsort memory leak if callback throws (BZ 32058) (Adhemerval)
  • Reviewer Pool: Simon Chopin
• dlfcn: dlinfo (RTLD_DI_PHDR) should work for proxy link maps (bug 32060) (Florian)
  • Florian noted this has bug, and so this is Changes Requested.
• [v4] manual: Describe struct link_map, support link maps with dlinfo (Florian)
  • Post v5 with updated changes to get to final version.
• Fixes for recursive dlopen (bug 31986) (Florian)
• Stopped at 95511.
• HJ: Patch from May, 90973.
  • The patch doesn't deal with those issues at all.
  • The discussions are unrelated to the changes in glibc.
  • Object can have non-zero load address.
  • The marking is not relevant.
• HJ: May we backport the SHSTK changes to 2.40?
  • Carlos: Yes, there is no external ABI impact, so it's fine.
• [PATCH v2 0/5] Add support for memory sealing (Adhemerval)
  • What kind of strategy do we want to take here?
  • Do we want a way to disable memory sealing?
  • HJ: Memory sealing. A decision for developers or the end user?
  • Adhemerval: I have added a developer option.
  • HJ: What if one DSO requires mseal? How do you propagate that?
  • HJ: This is a new feature and we don't know how people will use it.
  • HJ: Are such use cases reasonable?
  • Adhemerval: In BSD the sealing happens by default.
  • Adhemerval: Should we do this opt-in by DSO?
  • Adhemerval: If you break down the security hardening it also breaks down the value of hardening.
  • Florian: For a new toolchain feature that is not backwards compatible we have required toolchain changes to opt-in automatically. I don't think this change is sufficiently backwards compatible, but I haven't run enough tests to review.
  • Feedback welcome on strategy to take going forward with memory sealing.
• Florian: I'm working on glibc test cases using FUSE and the intent is to test stuff in the filesystem that is otherwise non-testable because you'd have to win a race condition. Any objections? It's possible to speak FUSE protocol directly.
  • Adhemerval: No objections. We already have linux kernel test specific features like containers.
  • Carlos: No objections from me.
  • Adhemerval: Current CI uses containers, and so we may need extra permissions? This test might not be covered in our CI without some changes.

Meeting: 2024-08-05 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Regrets: Carlos O'Donell (holiday).

Meeting: 2024-07-29 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 422 patches.

• Carlos: Anyting that is missing for glibc-2.40? Manual and website are updated.
• Andreas: Yes, I think we're good and done.
• Florian: Step missing from the release procedure to add the .1 section to the release branch?
• Starting at 94708.
• [v2] manual/stdio: Clarify putc and putwc (Arjun)
  • Marked accepted.
• replace tgammaf by the CORE-MATH implementation (correctly rounded) (Paul)
  • Failed CI gating for i686 math results.
  • Note: Needs SOB, and license check.
• inet: make ether_aton() reject garbage after the address (Miklós Máté)
  • Andreas noted that BSD doesn't reject the trailing garbage.
  • Further discussion required.
• libio: asprintf should write NULL upon failure (Florian)
  • From a review perspective there was a discussion in 2015 on the issue.
  • Ongoing discussion.
• [v2] manual: make setrlimit() description less ambiguous (Lukas)
  • Accepted. Florian to push.

• [v1] stdlib: Mark abort as cold (Noah)

  • Noah: LLVM needs to gain hot/cold splitting for noreturn.
  • Carlos: This should go in until LLVM has this support?
  • Carlos, gave RB.
• [v5] manual: Add Descriptor-Relative Access section (Florian)
  • Reviewer Pool: Adhemerval.
• getenv/environ thread safety (Florian)
  • Need to email DJ about failure in glibc-cicd (applies patch but fails to apply during testing)
  • Reviewer Pool: Carlos
• Stopping at 94652.

• Noah: Raising "assert: Wrap assert_fail in templated function" for review and discussion.

  • Continue discussing on the list. Florian and Adhemerval looked at the solution.
• Adhemerval: Raise cancellation issue.
• Carlos: I switched to the MT-safe exit() review ahead of cancel v8 cleanup, because of the requirement from the Rust community, and the POSIX issue review. I'll switch back to the v8 cancel patch again.
• Mitigation for "clone on sparc might fail with -EFAULT for no valid reason" (bz 31394) (Andreas)
  • Reviewer Pool: DJ Delorie

• [1/2] Define libc_initial for the static libc (Florian)

  • Reviewer Pool: Simon Chopin
• Stopped at 94588.

Meeting: 2024-07-22 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 397 patches.

• Carlos's SLI at 374 days average patch age in queue and 150324 accumulated patch days.
• Starting at 94297.
• Carlos: Noted that redhat-pt-bot/TryBot-still_applies following along still and trying to reapply patches.
• [v2] x32/cet: Enable shadow stack during startup for Linux 6.10 (HJ)
  • Noah: Changes requested.
• [RFC,v2] aarch64: Add support for memory protection keys (Yury)
  • Carlos: What feedback are you looking for?
  • Yury: Add extra pkey flags and permission check. v8 is using the code for example.
  • Adhemerval: Do we have any v8 feedback?
  • Adhemerval: The linux pkey reset over signal handlesr made things difficult to use.
  • Yury: The value of the register in signal handlers reset to default value.
  • Szabolcs: Yes, to use pkeys in glibc we need to propose something new for ALL arches in the kernel.
  • Adhemerval: I started to review this last Friday. I think the current API is what we would accept.
  • Yury: I tried to grep through the sources of debian packages, but they all comes from v8.
• linux: Update the mremap C implementation [BZ #31968] (HJ)
  • Reviewer Pool: Adhemerval Zanella
• [PATCHv2] hurd: Fix missing pthread_ compat symbol in libc (Samuel)
  • Reviewer Pool: Arjun Shankar
• [1/2] linux: fix/improve clone_args description (Kir)
  • Changes requested for the first patch. Accepted for the second patch.
• Updates for Linux 6.10 (Adhemerval)
  • Reviewer Pool: Carlos O'Donell
• stdio-common: Add test for vfscanf with matches longer than INT_MAX [BZ #27650] (Maciej)
  • Reviewer Pool: DJ Delorie
• nptl: Fix extraneous testing run by tst-rseq-nptl in the test driver
  • Reviewer Pool: Florian Weimer
• Adhemeral: Note that Maxim is out, so avoid reviewer pool assigment.
• manual/conf.texi: fix confstr parameter intro
  • Reviewr Pool: Simon Chopin.
• Stopping at 93618.
• Yury: Nothing to raise except for the already discussed RFC.
• Andreas: Nothing blocking.

• Adhemerval: https://patchwork.sourceware.org/project/glibc/patch/20240625191840.2810790-1-adhemerval.zanella@linaro.org/

  • Carlos: Noted. It's in my review queue.
• [v5,1/1] elf: Handle static PIE loaded at the specific address [BZ #31799]
  • Carlos: Currently in my review queue.
  • Do we have consensus?
  • Carlos: I will go back and review this as a steward.

Meeting: 2024-07-15 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

​ * State NEW delegate NOBODY at 393.

• Discussing the 2.40 release status.
• Andreas: Should the Hurd ABI change go in?
  • Carlos: I've commented on the thread that the change should go forward.
• Carlos: The check-localplt issue was visible in Fedora 41.
  • Andreas: Easy to test on my side.
  • Carlos: Joseph commented that binutils did not change but the failure occurred in a range of commits.
  • Carlos: I will look at the ppc64le issue tomorrow and see if is related to that commit range.
• Andreas: What about Alpha failures?
  • Adhemerval: Yes, the way the hardware handles inexact is a problem.
  • Carlos: OK, last results in glibc 2.31.
  • Andreas: I'll put the alpha results in the page.
• Discussed audit failures for MIPS
  • MIPS has an ABI that supports -fno-plt and we didn't have any tests to validate this.
  • MIPS optimization to avoid the indirection.
  • Adhemerval: Compiler options to explicitly create the PLT may need compiler changes.
  • Adhemerval: To solve this we might have to JIT the PLT entries.
  • MIPS failure does not block the release of 2.40.
  • Existing known regression since 2022 and recorded as bug 29404.
• Carlos: Also note that MIPS tst-ro-dynamic and tst-sprof-basic are not regressions.
• Carlos: Noted that RISC-V results are good, but a few failures are present.
  • Andreas: Note that TIMEOUTFACTOR=10 results in clean pass of the other tests that were failing for RISC-V.
• Adhemerval: The ppc64le packed relocation support looks like it might be related to the check-localplt failure.
  • Carlos: Yes, I'd want to know the result before we cut the release.
• Noah: If someone like HJ reviews it that would be OK, and this is not a good idea to have it for Skylake.

  • https://patchwork.sourceware.org/project/glibc/patch/20240715082228.715048-1-goldstein.w.n@gmail.com/

  • Carlos: I'll work with DJ to review this for the release.
• Adhemerval: Found the ppc64le issue... the script checks for specific relocation sections, and on x86 it contains both the relr and rela sections because some can't be put into relr, but in ppc64le everything can move and the script fails.
• Noah has no further issues to raise "[v1] x86: Disable non-temporal memset on Skylake Server" other than this issue.
• Noah noted HJ's patch to enable SHSTK for x32
  • Carlos: I've commented on list that this should wait for 2.41 dev open.
• Szabolcs: Nothing to raise.
• Carlos: I have the AI to add to the release blocker for the skylake change and review with DJ.

Meeting: 2024-07-08 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review of release blockers and desirable for 2.40 release.

​ * State NEW delegate NOBODY at 399 patches.

• In prepataion for glibc 2.40 we are reviewing release blockers and bugs that need fixing.
• What blockers do we have?
  • None, Andreas moved everything to glibc 2.41.
  • Florian: I would like to move just the ABI change for extensible rseq to 2.40?

  • https://patchwork.sourceware.org/project/glibc/list/?series=32221

https://inbox.sourceware.org/libc-alpha/87wmlx9sjh.fsf@oldenburg.str.redhat.com/

• Florian proposes just adding an ABI change so 2.40 would be ready for the extensible ABI.

• Carlos: This adds rseq_size in @GLIBC_2.40.

• Carlos: Procedurally Andreas should respond on the question of changing the ABI at this point.
• Adhemerval: How do we provide compatibility?
• Florian: We don't, we provide the smaller size.
• Adhemerval: Why do the version then?
• Florian: If you do the comparison today we want this to not run.
• Florian: The alternative is not to add the symbol and backport.
• Adhemerval: urcu and criu us it, but anyone else?

• Discussed the options around: ABI change vs. Bug fix.
• Florian will raise this issue on the list to get consensus about which direction to take.
• [v8] nptl: Fix Race conditions in pthread cancellation [BZ#12683] (Adhemerval)
  • Reviewer Pool: Carlos O'Donell
• Extend Rseq Support
  • Carlos: How do we get this into 2.41?
  • Florian: We can do a quick hack to use a static allocation.
  • Carlos: And if we run out of size we can change them?
  • Florian: Yes, totally internal.
  • Florian: We don't have a workable patch for setting aside the static allocation, it needs to be conditionalized and abstracted a bit.
  • Carlos: Looks like a couple more rounds for Michael to get the feature in place.
  • Florian: Once we settle the ABI issue the rest of the work is internal only.
• Improve executable stack handling
  • Reviewer already assigned: Arjun Shankar.
• Some DNS stub resolver fixes/enhancements (Florian)
  • Carlos: Half accepted by DJ, and half changes requested.
  • So this moves into glibc 2.40? No.
  • Florian is seeking feedback from unbound developers on first fix.
  • We can merge in glibc 2.41 after getting that feedback.
• POSIX Cond Var missing signal
  • Still with Carlos or find someone to delegate.
  • Consider for 2.41 inclusion without test case to trigger.
• Thread-safe getenv has zero ABI impact and is 2.41 material
• Carlos: What about the Qualcomm Oryon CPU enablement?
  • Andreas: That's in for 2.40.
• Andreas: Looking at the test failures there are 2 failures.

  • https://sourceware.org/glibc/wiki/Testing/Tests/elf/check-localplt

    • Florian: Something must have changed in the output format?
    • Need to file an upstream binutils bug?

  • https://sourceware.org/glibc/wiki/Testing/Tests/nptl/tst-cond24

    • Carlos: Tests show being at 35K for counter when the max iteration is 50K, this seems like thest timing out while it is making forwaring.
  • on riscv, iconv/tst-iconv_prog

    • http://fedora.riscv.rocks/koji/buildinfo?buildID=308558 Looking at this build.

    • At this log: http://fedora.riscv.rocks/kojifiles/packages/glibc/2.39.9000/30.fc41/data/logs/riscv64/build.log

    • Carlos: I see zero failures for rv64lp64d.
    • Andreas: I'll ask Darius.
    • Carlos: I'll review testing for glibc 2.40 on x86_64, aarch64, s390x, and ppc64le.

Meeting: 2024-07-01 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review of release blockers and desirable for 2.40 release.

• Extensible Rseq: current patch series is not ready
  • Does not build on all architectures.
  • Maybe some smaller approach is possible in time for the release, so that we can add at least the new ABI symbol.
  • Florian might be able to propose something this week.
• Improve executable stack handling.
  • Not sure if we have time to review this
• Some DNS stub resolver fixes/enhancements
  • Missing Review on first two patches
• mtrace-related fixes
  • Already reviewed and accepted.
• Review pthread condvar missing signal bug 25847.
  • No update so far.
• There were some recent discussions about pthread_cond and pthread_rwlock performance:

  • https://sourceware.org/pipermail/libc-help/2024-April/006653.html

  • Old discussion: https://sourceware.org/bugzilla/show_bug.cgi?id=13701

  • gnulib

    • https://lists.gnu.org/archive/html/bug-gnulib/2024-06/msg00291.html

    • https://lists.gnu.org/archive/html/bug-gnulib/2024-06/msg00316.html

• New pthread cancel implementation v8
  • Waiting review
• Florian
  • Thread-safe getenv, it requires some discussion.
• Szabolcs
  • Nothing
• Yury
  • Nothing.

Meeting: 2024-06-24 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• Welcome to Yury! New meeting attendee.

​ * State NEW delegate NOBODY at 404 patches.

• Carlos's SLI at 360 days average patch age in queue and 146904 accumulated patch days.
• Starting at 92660.

• Look at https://sourceware.org/glibc/wiki/Release/2.40 and Blockers / Desirable.

  • Note that we have extended rseq support on the list.
  • Also in the plan was pthread_cancel fix and pthread condvar missing signal fix.
  • Carlos: Do you have pthread_cancel fix ready for this release?
  • Adhemerval: I think we can fix it this release.
  • mtrace: make shell commands robust against meta characters (Andreas)
    • Carlos: Andreas pushed this after my review so this is complete.
  • Fix conditionals on mtrace-based tests. (Carlos)
    • Needs review.
    • Reviewer Pool: Adhemerval.
  • Andreas: What about no executable stack?
  • Adhemerval: It is desirable for the release.
  • Carlos: Then we should find someone to review.
  • Improve executable stack handling (Adhemerval)

    • https://patchwork.sourceware.org/project/glibc/list/?series=35285

    • Reviewer Pool: Arjun Shankar
    • Note that rough consensus seems to exist for v3.
• Extend rseq support (Michael Jeanson)
  • Reviewer Pool: Florian Weimer
• Andreas: Qualcomm Oryon review?
• Adhemerval: In my queue. Will review.
• Andreas: What about Florian's dns stub resolver fixes?
• Carlos: DJ has reviewed 50% of those. We should add to desirable for release.
• Szabolcs: Did the C23 logp1 interfaces get completed?
• Carlos: Yes, committed last week.
• Szabolcs: OK, we can add aarch64 vector libmvec implementations, but that can happen later.
• debug: Fix clang mq_open fortify wrapper (BZ 31917) (Adhemerval)
  • Reviewer pool: Carlos O'Donell
• Opt-out static C++ link check and tests (HJ)
  • Reviewer Pool: Carlos O'Donell
• Starting at 92659, with 391 patches.
• [v2] socket: Add new test for shutdown (Sergey)
  • Reviewer Pool: DJ

• [v3] LoongArch: Fix tst-gnu2-tls2 test case (Meng)

  • Needs machine maintainer review.

• [v6] MIPSr6/math: Use builtin fma and fmaf (YunQuiang)

  • Reviewer Pool: Florian Weimer
• x32/cet: Enable shadow stack during startup for Linux 6.10-rc4 (HJ)
  • Reviewer Pool: Maxim K.
• [v2] RISC-V: Use builtins for ffs and ffsll while supported extension available
  • Needs machine maintainer review.
• [v4] elf: Avoid re-initializing already allocated TLS in dlopen (bug 31717) (Florian)
  • Reviewer Pool: Simon Chopin
• Stopped at 92370.
• time/Makefile: fixed tests target formatting (Samuel)
  • Reviewer Pool: Arjun Shankar.

Meeting: 2024-06-17 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• State NEW delegate NOBODY at 413
• Carlos's SLI at 345 days average patch age in queue and 144263 accumulated patch days.
• Note: Service provider for BBB (Core Toolchain Infrastructure project, and LF IT will be upgrading from Greenlight 2 to 3 for BBB and accounts will be recreated, or may need to be recreated after the upgrade).
• Carlos: What do we do for soft freeze early by 2 weeks?
  • Carlos will respond on list.

  • https://inbox.sourceware.org/libc-alpha/3833503.usQuhbGJ8B@pinacolada/T/#t

• Starting at 92263.
• powerpc64: Add optimized strcpy and stpcpy for POWER10 (Mahesh)
  • Machine maintainer needs to review.

• support: Include <stdlib.h> for atoi use in support_wait_for_thread_exit (Florian)

  • Consensus exists, please push.

• support: Include <limits.h> for NAME_MAX use in temp_file.c (Florian)

  • Consensus exists, please push.
• [v5] MIPSr6/math: Use builtin fma and fmaf (Su)
  • Machine maintainer needs to review.
• [v8] manual: add syscalls (DJ)
  • Florian: What about POSIX Threads?
  • Carlos: Yes, we will need to document.
  • Reviewer Pool: Carlos O'Donell
• Extend tst-getconf.sh test with NPROCESSORS vars (Jan Kurik)
  • Approved by Arjun.
• [v4] Update mmap() flags and errors lists (DJ)
  • Reviewer Pool: Florian Weimer
• [RFC] linux: add definitions for hugetlb page size encodings
  • Commented on by Florian.
• [v2] malloc: Always install mtrace (bug 31892) (Florian)
  • Reviewer Pool: Adhemerval Zanella
• signal/Makefile: Split and sort tests (Michael)
  • Reviewer Pool: Arjun Shankar
• inet: Increase htontest coverage to run-time evaluation, library (Florian)
  • Dropped.

• [v2] LoongArch: Fix tst-gnu2-tls2 with -Og flag (Meng)

  • Needs machine maintainer review.
• Some DNS stub resolver fixes/enhancements (Florian)
  • Reviewer Pool: DJ Delorie

• [v1] LoongArch: Fix _dl_tlsdesc_dynamic in LSX case (Meng)

  • Needs machine maintainer review.
• Implement C23 exp2m1, exp10m1 (Joseph)
  • Soft dependency on other patches.
  • Adhemerval: I'll review this one.
• [v3,1/2] Aarch64: Add memcpy for qualcomm's oryon-1 core (Andrew)
  • Adhemerval to see if he can push this change.
  • Carlos or Florian can apply this if Adhemerval can not apply it.
• [RFC] aarch64: Add support for memory protection keys (Yury)
  • Florian and Szabolcs both commented. Changes requested.
• Stopping at 91978.
• Carlos: Owe Adhemveral the pidfd fixes and the race fix. I will review those ahead of other reviews. I will then review Joseph's C23 patch.
• Adhemerval: Rework how we handle executable stacks. And provide a way to be able to disable for 2.40.
• Work with DJ to set system-wide tunable for this.
• There is a personality flag "read implies exec" for this?
• setarch -X (which won't go away)

* Florian: Needs review: [v3] manual: Recommendations for dynamic linker hardening * Andreas: Looking at the Autoconf updated?

• Carlos: Simon reviewed and considered it OK since everything is checked in.
• Carlos: As release manager you can configure with 2.72?
• Andreas: No problem.

Meeting: 2024-06-10 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• State NEW delegate NOBODY at 392 patches.
• Carlos's SLI at 357 days average patch age in queue and 141541 accumulated patch days.
• Starting at 91805.
• Implement C23 log10p1 (Joseph)
  • Reviewer Pool: Adhemerval
• iconv: Fix matching of multi-character transliterations (bug 31859) (Andreas)
  • Reviewer Pool: Carlos O'Donell
• resolv: Track single-request fallback via _res._flags (bug 31476) (Florian)
  • Reviewer Pool: DJ Delorie
• x86: Ensure MINIMUM_X86_ISA_LEVEL=0 for baseline [BZ #31867] (Wilcox)
  • HJ: Level 0 isn't correct for x86_64, patch is on the bug.
  • Andreas: It affected all gentoo stages. Reports that they couldn't chroot into them. Really old hardware.

• <stdio.h>: Remove comment about getline(3) not being in POSIX (Philip)

  • Note that Sam James commented and provided RB but this is multiple patches in one.
  • Needs to be reposted with final version with RB included and then can be pushed.
  • Florian to comment on list.
• x86: Enable non-temporal memset tunable for AMD (Joe)
  • Noah reviewed and provied RB.
  • Carlos: I commended that Noah should feel free to push.
• elf: sort tunables list from ld.so (DJ)
  • Florian: Changes requested.
• stdio-common: Add test for vfscanf with matches longer than INT_MAX [BZ #27650] (Maciej)
  • Florian: I will follow up as I have some suggestions.
• Remove legacy platform bits and cleanups (Stefan Liebler)
  • Florian: Changes requested. Doesn't build on MIPS.
  • Carlos: We should pass build-many-glibcs as part of any large cleanups.

• [v1] LoongArch: Add cfi pseudo instructions to _dl_tlsdes_dynamic (Meng)

  • Needs review by machine maintainer.
• [v3] Update mmap() flags and errors lists (DJ)
  • Reviewer Pool: Florian Weimer
• [v5] manual: add syscall list (DJ)
  • Changes requested.
• x86_64: Align memmove unaligned routines to 64 byte (Sunil)
  • Carlos: Marked rejected.
• RISC-V: Add Zbb-optimized string routines as ifuncs (Christoph Mullner)
  • RISC-V hardware maintainers need to review.
• Stopped at 90855.
• HJ: I have a couple patches for the past two weeks. Any updates?
  • Carlos: I owe you two reviews for "Opt-out static C++ link check and tests", "elf: Handle static PIE loaded at the specific address".
• Andreas: QEMU filesystem related patches from Adhemerval. Status?
  • Right now we have in the situation that a patch was added to the gentoo kernel as a workaround.

  • Adhemerval: https://patchwork.sourceware.org/project/glibc/list/?series=18052

  • Carlos: We discussed this in October 2023, and while we wanted to fix this, we haven't reviewed it.
  • Adhemerval: I want to get a system that reproduces this to test the patches.
  • Carlos: Do we think v7 is ready?
  • Adhemerval: I would like to test this more, particularly with btrfs.
  • Carlos: Andreas, the help requested would be to get a system that reproduces the issues.
  • Adhemerval: Even just "how to setup a system" would be sufficient.
• Adhemerval: Same patches as last week.

  • https://patchwork.sourceware.org/project/glibc/patch/20240521131311.604831-1-adhemerval.zanella@linaro.org/

  • https://patchwork.sourceware.org/project/glibc/patch/20240506181906.1798367-1-adhemerval.zanella@linaro.org/

  • Carlos: ABI freeze starts with July.
  • Carlos: I have not forgotten that Andreas and I discussed providing him with the ability to upload tarballs.
  • Andreas: I discussed soft-freeze 2 weeks before the freeze.

    • https://inbox.sourceware.org/libc-alpha/3517334.irdbgypaU6@kona/T/#mc433be44ed8c0eedb3652155b75ba2ab2122da6f

    • Carlos: I'll go review that thread.

Meeting: 2024-06-03 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• State NEW delegate NOBODY at 389 patches.
• Carlos's SLI at 353 days average patch age in queue and 138973 accumulated patch days.
• Starting at 91388.
• elf: Avoid some free (NULL) calls in _dl_update_slotinfo (Florian)
  • Carlos reviewd this morning.
• math: Update mips32/mips64 ulps for log2p1 (Su)
  • Adhemerval: I'll comment on this.

• [v2] stdlib: Describe cxa_finalize usage in function comment (Florian)

  • Needs review.
• math: Fix exp10 undefined left shift (Szabolcs)
  • Reviewer Pool: Adhemerval
• [v5] manual: add syscall list (DJ)
  • Florian: I have a sustained objection to the change.
  • Carlos: Please follow up on the list.
  • Florian: Note that we have a downstream requirement to document certain functions. This solution only resolves some of the issues, has mistakes, and needs cleanup.
• getconf: Add NPROCESSORS_{CONF,ONLN} [BZ #31661] (Akram)
  • Reviewer Pool; Arjun
• x86_64: Align memmove unaligned routines to 64 byte (Sunil)
  • Noah discussed this, and Sunil noted it's used by libMicro.
  • Carlos: I commended on this right now to indicate we should not solely base this on libMicro results.
• [v3] malloc: New test to check malloc alternate path using memory obstruction (Paul)
  • Already reviewed by Arjun.
• Implement C23 logp1 (Joseph)
  • Reviewer Pool: Carlos O'Donell
• [v2,1/1] Linux: Add epoll ioctls (Joe Damato)
  • Already committed.
• difftime isn't even pure (Paul Eggert)
  • Reviewer Pool: DJ Delorie.
• Stop at 91027.

• [v2] tests: handle AppArmor userns mitigation (Simon)

  • Reviewer Pool: Florian Weimer
• [v5,1/1] elf: Handle static PIE loaded at the specific address [BZ #31799] (HJ)
  • Carlos: I'll review and look for consensus.
• RISC-V: Add Zbb-optimized string routines as ifuncs (Mullner)
  • RISC-V hardware maintainers need to review.

• [v3] Make nldblIO_vfscanf a compat symbol [BZ #31776] (HJ)

  • Noted to HJ last time that Joseph could review, and indeed Joseph reviewed v2.

• [v1] LoongArch: Fix tst-gnu2-tls2 compiler error (Meng Qing Gang)

  • Machine maintainer reviewed but hasn't pushed.
• [v3] support: Fix typo in xgetsockname error message (Avinal)
  • Reviwer Pool: Maxim
• [v3] elf: Avoid re-initializing already allocated TLS in dlopen (bug 31717)
  • Reviewr Pool: Simon.
• Stopping at 90201.

Meeting: 2024-05-27 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• State NEW delegate NOBODY at 396 patches.
• Carlos's SLI at 341 days average patch age in queue and 136384 accumulated patch days.
• Starting at 90954
• Carlos: Adhemerval, Did we have a meeting on the 20th?
• Adhemerval: Yes, but we just discussed with Arjun code reviews and engaging new developers.
• RISC-V: Add Zbb-optimized string routines as ifuncs (Christoph)
  • Adhemerval reviewd the first version, but raised concerns around the way in which the compiler was instructed to compile the code.
  • Uses configure test for compiler with function attributes.
  • Leave this in the queue for machine maintainers to review.
• i386: Remove Xeon Phi processor support (BZ 31782) (Sunil)
  • HJ: Patch goes too far. Please delegate to me.
• sysdeps/x86_64/dl-machine.h: Add space for ease of retrieval (Xin)
  • Florian requested changes.
• difftime is pure, not const (Paul Eggert)
  • Reviewer pool: Adhemerval Zanella
• [v4] elf: Handle static PIE loaded at the specific address [BZ #31799] (HJ)
  • Adhemerval: Why do we need this?
  • HJ: This is just for a test case.
  • Carlos: Do we set any precedent for this feature even if it's a test?
  • Florian: Should this have generated a diagnostic at the linker stage?
  • HJ: Will post v5.
• Opt-out static C++ link check and tests (HJ)
  • Carlos: Why do we need this? I'll review.
• parse_fdinfo: Don't advance pointer twice [BZ #31798] (HJ)
  • Adhemerval: I'll review right now.
• [1/1] Linux: Add epoll ioctls (Joe)
  • Assigned to Adhemerval for review at his request.

• [v3] Make nldblIO_vfscanf a compat symbol [BZ #31776] (HJ)

  • Carlos: I don't have a good answer for who can review this one.
  • Ping Szabolcs, Joseph or Peter Bergner.
• [v7] Check global symbols in static library against shared library (HJ)
  • Reviewer Pool: Florian Weimer
• Stopped at 90837.
• [v2,1/2] x86: Improve large memset perf with non-temporal stores [RHEL-29312] (Noah)
  • Reviewer Pool: Arjun Shankar.
• [v3] posix: Fix pidfd_spawn/pidfd_spawnp leak if execve fails (BZ 31695) (Adhemerval)
  • Reviewer Pool: Carlos O'Donell.
• [v2,1/1] futex: Add FUTEX_SPIN operation (Andrew Almeida)
  • Not applicable.
• [v4] manual: add syscall list (DJ)
  • Reviewer Pool: Florian Weimer
• add new inputs that yield larger ulp errors for log2p1 on x86_64 (Paul)
  • Reviewer Pool: Maxim Kuvyrkov
• avoid unnecessary copying of a left_subarray's tail (Viktor)
  • Reviewer Pool: Simon Chopin
• Stopped at 90473.

Meeting: 2024-05-20 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• Discussion with Arjun about patch review and attracting new contributors.

Meeting: 2024-05-13 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• State NEW delegate NOBODY at 368 patches.
• Carlos's SLI at 353 days average patch age in queue and 131344 accumulated patch days.
• Starting at 90037.
• [v4] Fix #27777 - now use a doubly-linked list for _IO_list_all (HJ)
  • Reviewer Pool: Florian Weimer.
• Unify output from backtrace_symbols_fd with backtrace_symbols (bug 31730) (Andreas)
  • Reviewer Pool: Adhemerval Zanella.
• [1/6] MIPSr6/math: Use builtin fma and fmaf (Yun Qiang)
  • Needs machine maintainer review.
• Halving the number of recursive calls (Reznov)
  • Carlos: Lacks copyright assignment or DCO. I'll post to the list.
  • Also fails CI for patch application.
• At 89920.
• manual: add dup3 (DJ)
  • Already reviewed. Marked accepted.
• [1/2] elf: update NT_FDO_PACKAGING_METADATA spec URL (Luca)
• [2/2] elf: add note identifier for dlopen metadata (Luca)
  • Reviewer Pool: Arjun Shankar
• Update mmap() flags and errors lists (DJ)
  • Florian said he'll look into this patch and work on getting kernel input.
• manual: Recommendations for dynamic linker hardening (Florian)
  • Needs a v2 with typo fixes.
• [v4] socket: Use may_alias on sockaddr structs (bug 19622) (Florian)
  • Reviewer Pool: Carlos O'Donell
• Stop at 89882.
• HJ: Andreas asked the question why I set timeout larger for the test. Test timeout from 2s is conservative.
  • Florian: My recommendation is to triple the number of fdopen calls and then use the default timeout.
  • HJ: Triple the open or close?

  • https://inbox.sourceware.org/libc-alpha/mvm5xvh3kze.fsf@suse.de/T/#t

  • Carlos: Move the test to the benchtests directory?
  • HJ: Post v5 without the test (which is not needed).
• Szabolcs: Nothing for me.
• Florian: Nothing for me.
• Starting at 89882
• [RFC] malloc: Improve aligned_alloc and calloc test coverage. (Joe)
  • Reviewer Pool: DJ Delorie
• [v2] math: Add GLIBC_TEST_LIBM_VERBOSE environment variable support. (Joe)
  • Carlos: I'll review this again.
• math: Add more details to the test driver output. (Joe)
  • Florian: Should this go to the math subsystem maintainer?
  • Carlos: Yes, it should go to Joseph for review. I'll send email.
• [v2,1/2] Aarch64: Add memcpy for qualcomm's oryon-1 core (Andrew)
  • Carlos: If this is restricted to MIDR checking is that OK?
  • Szabolcs: Yes.
• manual: clarify defintions of floating point exponent bounds (bug 31518) (Andreas)
  • Carlos: I'll review this.
• Stop at 89714.

Meeting: 2024-05-06 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• State NEW delegate NOBODY at 365 patches.
• Carlos's SLI at 350 days average patch age in queue and 129626 accumulated patch days.
• Starting at 89497.
• ldconfig: Ignore all GDB extension files (Adam)
  • Reviewer pool: Florian Weimer
• [1/2] Aarch64: Add memcpy for qualcomm's oryon-1 core (Andrew)
  • Fails pre-commit CI.
• [v2,1/2] Document CVE-2024-33599, CVE-2024-33600, CVE-2024-33601, CVE-2024-33602 (Carlos)
  • Already approved by Siddhesh, and commented on top-level discussion to make descriptions align with program requirements.
  • More tunable fixes (Adhemerval)
    • We have 2 RBs need 2 more RBs.
    • Changes requested.
• [v2] aarch64: Fix AdvSIMD libmvec routines for big-endian (Joe Ramsey)
  • Under review by Szabolcs
• powerpc64: Fix by using the configure value $libc_cv_cc_submachine [BZ #31629] (Matti)
  • Needs machine maintainer review.
• Add crt1-2.0.o for glibc 2.0 compatibility tests (HJ)
  • Reviewer Pool: Carlos O'Donell
• [v2] Fix #27777 - now use a doubly-linked list for _IO_list_all (HJ)
  • Carlos: This needs co-authored-by in the email.
• [1/3] aarch64/fpu: Add vector variants of hypot (Joe Ramsay)
  • Needs machine maintainer review.
  • Szabocls will review.

• powerpc: Fix fesetround_inline_nocheck on POWER9+ (BZ 31682) (Adhemerval)

  • Paul Murphy commented on it. Changes requested.
• [V3] powerpc: Optimized strncmp for power10 (Amrita)
  • Needs machine maintainer review.
• Stopping at 89142.
• Carlos: Noting that DJ's review of extensible rseq still needs an ABI review.
  • Discussed reviewing this with Florian to look at ABI aspect.
• Ending the meeting early so Carlos can spend time to publish CVEs for nscd fixes.

Meeting: 2024-04-29 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• State NEW delegate NOBODY at 370 patches.
• Starting at 89136
• [V3] powerpc: Optimized strncmp for power10 (Amrita)
  • Needs IBM maintainer review.

• LoongArch: Use "$fcsr0" instead of "$r0" in _FPU_{GET,SET}CW (Xi)

  • Needs LoongArch maintainer review.

• [v2] OpenRISC glibc hard float support (Horne)
  • Adhemerval: I reviewed this one and they didn't add a compat symbol for the ucontext extension.
• localedata: add new locales scn_IT and scn_US (David Paleino)
  • Reviewer pool: Arjun Shankar

• [v2] i686: Fix multiple definitions of memmove_chk and memset_chk (Gabi Falk)

  • Needs a v3. Changes requested. Needs to fix i586 as seen by build-many-glibcs.
• Fix #27777 - now use a doubly-linked list for _IO_list_all (Ferrieux)
  • Florian: Sending a comment to the list.
  • Changes Requested. Needs v2 to handle ABI issues.

• [v5] LoongArch: Add support for TLS Descriptors (Meng)

  • Reviewed by Xi, marked changes requested.
• linux: Add openat2 (BZ 31664) (Adhemerval)
  • Adhemerval: Review question, should we provide a wrapper or not, what about size changes?
  • Carlos: This needs to go to the list.
• Stopped at 88833.
• Adhemerval: Note the libm static issues:

  • https://patchwork.sourceware.org/project/glibc/list/?series=32436

  • Carlos: This is in my queue, but blocked on the current CVE advisory work.
• Started review at 88833.
• Add ifunc support for existing Zbb optimizations (Mullner)
  • Review Pool: Carlos O'Donell.
• [1/3] Add system-wide tunables: ldconfig part (DJ Delorie)
  • Review Pool: Florian Weimer.
• RISC-V: Execute a PAUSE hint in spin loops (Mullner)
  • Delegated to Palmer to commit.

  • https://inbox.sourceware.org/libc-alpha/20240419-3edb96288d5199abc7081fd7@orel/#r

  • Though there is a 3 patch series that shows this doesn't have consensus?
• [RFC] math-vector-fortran.h: fix multilib conflict (Kai Kang)
  • Under review from Szabolcs.
• [v2] resolv: add IPv6 support to inet_net_pton() (Snijders)
  • Review Pool: DJ Delorie
• [v2] Update RISC-V relocations (Andreas Schwab)
  • Review Pool: Maxim
• [test,conversion,RFC] Convert to autoconf 2.72 (no patches) (Andreas)
  • Review Pool: Simon
• Stopped at 83165.

Meeting: 2024-04-15 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

• State NEW delegate NOBODY at 370 patches.
• Carlos's SLI at 333 days average patch age in queue and 125211 accumulated patch days.
• Carlos: February's pthread cancel is still my priority.
• [RFC,V4] Enable libmvec support for RISC-V (Yu Long)
  • Adhemerval: Only adds one symbol, so are they looking for feedback?
  • Carlos: Looks simialar to aarch64?
  • Szabolcs: Yes, could be abstracted away but SIMD is hard to do abstract.
• [v4] elf/rtld: Count skipped environment variables for enable_secure (Joe)
  • Review Pool: Adhemerval (assigned because of previous review)
• [v3] Use unsigned 32-bit types for seconds-since-epoch (Florian)
  • Waiting on additional feedback from Paul Eggert
  • Marked Accepted.
• [RFT] malloc: reduce largebin granularity to reduce fragmentation (Eric Wong)
  • Review Pool: Florian (assigned for comments)
• Implement C23 log2p1 (Joseph Myers)
  • Carlos: Marked Failed CI.
• Stopped at 87935.
• Szabolcs: Nothing to raise.
• Florian: POWER10 and valgrind failures have made forward progress. P10 ppc64le fixes are in thanks to Peter Bergner's feedback.
  • Adhemerval: Can we reduce the build permutations and still test this?
  • Florian: I don't know. We might need a specific relocation for this.
  • Carlos: RELRO linkmap for May?
  • Florian: I suggest the syslog work instead as something we can get across the line in Myy.

    https://patchwork.sourceware.org/project/glibc/list/?series=30756

• Adhemerval: Nothing else to raise.
• Carlos: Nothing else to raise.
• [v3] Fix some libm static issues (Adhemerval)
  • Review Pool: Carlos O'Donell
• OpenRISC glibc hard float support (Stafford Horne)
  • Review Pool: DJ
• [v6] RISC-V: Implement TLS Descriptors. (Tatsuyuki Ishi)
  • Adhemerval: Commented on this given the direction they are going.
• [v13] posix: Deprecate group_member for Linux (Joe Simmons-Talbott)
  • Review Pool: Arjun
• RISC-V: Clobber V state on system calls (Palmer)
  • Review Pool: Maxim
• elf: Do not check for loader mmap on tst-decorate-maps (BZ 31553) (Adhemerval)
  • Review Pool: Simon Chopin

Meeting: 2024-04-08 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

State NEW delegate NOBODY at 374 patches.

• 88171: [v2] login: Use unsigned 32-bit types for seconds-since-epoch
  • Have a patch that distro maintainers can pick to get around it the y2038 issues with utmp/utmpx/lastlogin.
• 88164: Enhanced CPU diagnostics for ld.so
  • Nsz raised some concerns about code and printing information for aarch64.
  • Delegate azanella
• 88160: libsupport: Add xgetpeername
  • Assigned to arjun
• 88147: [RFC] Enable libmvec support for RISC-V
  • Let RISC-V maintainers to handle it.
• 88122: Use crtbeginT.o and crtend.o for non-PIE static executables
  • Assigned to codonell
• 87989: arc4random: fix getrandom fallback to /dev/urandom
  • Changes requested
• 87981: elf: Don't call fatal_error in _dl_signal_error
  • Florian will try to come up with a testcase to trigger the deleted code path.
• Florian
  • Nothing to add.
• Szabolcs
  • Nothing to add.
• H.J
  • Nothing to add.
• Maxim
  • Nothing to add.

Meeting: 2024-04-01 @ 0900h EST5EDT

Review new patches and attendee requested reviews.

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 397 patches.
• 87879: stdlib: reorganize stdlib Makefile routines by functionality
  • Need more discussion and more information about the issue.

  • H.J noted he has a patch for bintuils: https://patchwork.sourceware.org/project/binutils/list/?series=29973

• 87875: elf: sanitize objname in _dl_signal_error
  • Possible need a bug report.
• 87870: manual: arith.texi and math.texi fixes
  • D.J already gave his RB to first two patches, assigning the rest to him.

• 87853: LoongArch: Add soft floating-point fe* function implementations.

  • It seems to be rather adding a new ABI, instead of just new symbols.
  • Florian will add some comments

• 87852: [v4] LoongArch: Add support for TLS Descriptors

  • Adhemervall will continue to comment on this one.
• 87847: Superseeded
• 87810: OpenRISC glibc hard float support
  • Skip for now, since this is a quite large patch.
• 87805: RISC-V: Implement TLS Descriptors
  • Skip, there is not upstream support yet (and I hope RISC-V maintainer will help on this).
• 87781: Deprecate group_member for Linux
  • Skip, give it a week.
  • It is desirable for this release.
• 87736: Fix some libm static issues
  • Adhemerval will drop the i386 changes
  • H.J asked a way to enable static build for all tests
• H.J
  • Question for Florian: how is TLS descriptor patch status on Fedore Rawhide?
  • Florian said there is nothing new to add.
• Florian
  • Nothing to add.

* Adhemerval

• https://patchwork.sourceware.org/project/glibc/list/?series=28918

• H.J will take a look.

Meeting: 2024-03-25 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 405 patches.
• Carlos's SLI at 290 days average patch age in queue and 119946 accumulated patch days.
• Starting at 87613
• manual: Drop incorrect statement on PIPE_BUF and blocking writes (Stepan)
  • Changes requested.

• aarch64-gnu port & GNU/Hurd on AArch64 progress (Sergey)

  • Szabolcs: I looked at it some months ago. It fortunately touches very little in core aarch64 code.
  • Carlos: Marked FAILED CI.
• Math static build fixes (Adhemerval)
  • Adhemerval: --disable-shared is broken, but checking for a static build is broken for a long time.
  • HJ: Does the test expose all the issues?
  • Adhemerval: It does. I hooked into the type framework to enable the static cases. The enablement is not full coverage.
• x86_64: Remove avx512 strstr implementation (Adhemerval)
  • Has RB from Noah Goldstein.

• tests: handle AppArmor userns mitigation (Simon)

  • Changes requested.
• [1/4] or1k: Fix Linux user space signal ABI (Stafford Horne)
  • Rejected. Should be handled as part of the new hard float ABI bringup.
• Improve wcsstr (Adhemerval)
  • Review pool: Assigned to DJ based on previous review.
• [1/2] Add random benchmark (Wilco)
  • Review pool: Adhemerval.
• Benchtests: Improve large memcpy/memset benchmarks (Wilco)
  • Review pool: Carlos.
• Benchtests: Remove broken walk benchmarks
  • Review pool: Carlos.
• manual/math.texi: logb(3) and cbrt(3) fixes (Alejandro)
  • Review pool: DJ.
• Extend rseq support (Michael)
  • DJ reviewed initial posting and was requesting a secondary review for ABI.
  • Carlos: Michael needs to repost a rebased version.
• Stopping at 83697.
• Discussed blockers and looked at monthly planning.
  • Carlos: I didn't get to finish the pthread cancel review.

Meeting: 2024-03-18 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2024-03-11 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Starting: 86959
• 86952: v3; v2 is being review by azanella. Assigned to azanella (reviewer pool).
• 86945: v2; v1 commented on by codonell. Assigned to codonell (reviewer pool).
• 86890: Florian to approve trivial change and, possibly, commit.
• 86877: Florian (reviewer pool)
• 86838: DJ (reviewer pool)
• 86821, 86820, 86819: v2; v1 was reviewed quickly, so skipping in hopes that same reviewers will review v2.
• Stopping: 86461
• Discussion of aarch64-gnu Hurd port.

Meeting: 2024-03-04 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 420 patches.
• Start at 86657.
• codonell: Noted Red Hat CI is down, and pinged DJ.
  • maxim: Noted Linaro CI will follow once it's up again.
• v2: Improve wcsstr (Adhemerval)
  • Re-assigned to DJ.
• Extending TLS testing and fixing TLS gnu2 for ARM (Adhemerval)
  • Reviewed pool: Arjun
• Discussed the state of TLS ABI and descriptors.
  • HJ: Should we raise this to other machine maintainers?
  • Adhemerval: I have an action item to raise this with Loongarch.
• optimize memmem for short needles (James Tirta Halim)
  • Maxim to review.

• [v2] LoongArch: Add support for TLS Descriptors (Meng)

  • Adhemerval to review.
• System-wide tunables (DJ)
  • Failed CI for 32-bit targets.
  • Adhemerval to review.
• Extend rseq support (Michael)
  • codonell: I'll follow up with DJ to discuss if this should get pushed or if any remaining blockers exists.
• locale: Handle loading a missing locale twice (Bug 14247) (Carlos)
  • Adhemerval: Requested v2 with minor changes.
• Update RISC-V relocations (Andreas)
  • Reviewer pool: Carlos to review.

• [v3] Always define USE_TIME_BITS64 when 64 bit time_t is used (Adhemerval)

  • Reviewer pool: DJ
• codonell: I'll talk to Siddhesh about running the cleanup script.
• New TLS usage in libgcc_s.so.1, compatibility impact (Florian)
  • Carlos to review.
• Don't check signatures in build-many-glibcs.py (Palmer)
  • Reviewer pool: Simon Chopin
• Stopped at 83697.
• Adhemerval: We've had some issues with the RISC-V commits that broke things.
  • codonell: We need to reply on list that it was broken. Would this be resolved with pre-commit CI?
• Discussed SPDX, and the Licenses file and making some progress to simplify this for downstream distributions.

Meeting: 2024-02-26 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW and delegate NOBODY is at 431
• Discussed past queue review for Adhemerval
  • Patch in questino was: "Re: [PATCH v3 04/10] stdlib: Improve fortify with clang"
  • Carlos provided RB live on the call.
• Starting at 86350.
• x86_64: Suppress false positive valgrind error (HJ)
  • Review pool: Adhemerval.
• [v9,1/1] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (HJ)
  • Florian, Noah, made comments.
  • Carlos: Safest is to XPASS this?
  • This is still under broader community review.
  • HJ will post v10 with XFAIL for the test so we can commit this going forward.
• [v8] sysdeps/x86_64/multiarch/memmem-avx2.c: add memmem-avx2.c (James Tirta Halim)
  • Review pool: Arjun.
• [v3] localedata: Fix several issues with the set of characters considered 0-width [BZ #31370] (Jules)
  • Arjun will review again.
• Add strstr-avx2 based on strstr-avx512 (James Tirta Halim)
  • Changes requested.
• RISC-V: Fix the static-PIE non-relocated object check (Palmer)
  • Review pool: Carlos
• Improve wcsstr (Adhemerval)
  • Review pool: DJ
• [1/8] aarch64/fpu: Add vector variants of erf (Joe Ramsay)
  • Review pool: Maxim
• v12 RISC-V: ifunced memcpy using new kernel hwprobe interface (Evan Green)
  • Delegated to Palmer to resolve ABI issues.
  • Jessica Clark has asked us if we should fix the relocation processing to simplify the ABI or not.
• [v10,1/1] x86: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (HJ)
  • Review pool: Simon
• Maxim: I have some things to raise for the review process.
  • When there is a v2 or v3 posted can we assign the same delegate to the patch?
  • Can we make patchwork add a link to the previous patch that the current one supercedes.
  • Carlos: We would need to add patch version tracking to patchwork.
    • Is using "Message-ID:" sufficient?
  • Carlos: May you please document this on wiki?
• HJ: Ran into an issue in glibc where we say GCC 6 is the minimum version that can build glibc. Only gcc 7 can be used because of a symbol with libgcc_s.a.
  • Carlos: You have two issues. Disentagle why we use the system issue and raise the system gcc version.
  • Adhemerval: We bump when we see an improvement.
  • Carlos: We should only support building glibc wtih supported gcc e.g. GCC 11.1.
  • Adhemerval: What is the minimum version of the compiler required to build itself?
  • Maxim: It just needs a conformant C++ compiler. In practice there is a version below which it can't bootstrap. Not written anywhere.
  • Maxim: I fully agree with Carlos that I don't see the benefit of supporting systems built with very old tools.

Meeting: 2024-02-19 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2024-02-12 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY is at 497 patches.
• Carlos's SLI at 258 days average patch age in queue and 129620 accumulated patch days.
• Patch review volunteers:

  • https://inbox.sourceware.org/libc-alpha/F0A66BDC-9644-445F-9E30-2C1B90C2277C@linaro.org/

• Carlos: Still working on my post the community. I saw with it for the week and I have concluded on a first come first serve design where we try to schedule out blocking work as feature delivery into the release.
• Starting at 85595.
• Patch reviewer pool: Adhemerval (azanella), Arjun (arjun), Carlos (codonell) , DJ(dj), Maxim (maximk), Simon.
• 85594: [v3] x86-64: Update _dl_tlsdesc_dynamic to preserve vector registers - fweimer to review.
• x86-64: Save APX registers in ld.so trampoline - adhemerval to review.
• localedata: Set width of DEFAULT_IGNORABLE_CODE_POINTs to 0 [BZ #31370] - arju to review.
• Enhanced x86 CPU diagnostics - hj to review.
• Improve fortify support with clang - codonell to review.
• [v2] Add public function syscall_no_errno
  • Initial version was CC'd to Rich Felker for musl comments.
  • Adhemerval to review since he started previous review.
• 85461: x86: Improve ERMS usage on Zen3+ -- HJ to ping Noah on the review.
• Stopped at 85344.
• Florian: I will post to the list to start a discussion around eager allocation of TLS space.
• Carlos: dlopen and TLS descriptors?
• Florian: Yes.
• HJ: ABI is clear we need to preserve all registers.
• HJ: It is an implementation detail if we get rid of the slow path or keep it and preserve the registers.
• Carlos: Why did we make this decision initially?
• Adhemerval: Large TLS per thread, and you install multiple threads, then this can consume lots of memory.
• Andreas: The clone3 fix for mips? Can we backport that? Only relevant for 2.38.
• Adhemerval: I'll check the backport if I haven't done it already.
• Carlos: What do we want to do for a patch review pool process? Do we stop once we hit the end of the pool or do we try to assign more to the pool?

• [v2] tests: gracefully handle AppArmor userns containment - assigned to Maxim.

• x86/cet: fix shadow stack test scripts - HJ to push
• Carlos: Please remember to add Reviewed-by: to track review.
• [v5] sysdeps/x86_64/multiarch/memmem-avx2.c: add memmem-avx2.c - Fails to apply. Fails CI.
• Linux: Switch back to assembly syscall wrapper for prctl (bug 29770) - Asking Simon to review. Assigned to Maxim and Maxim will follow up with Simon to get a patchwork account.
• Stopping at 85081.

Meeting: 2024-02-05 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 473 patches.
• Carlos's SLI at 265 days average patch age in queue and 126812 accumulated patch days.
• Carlos: Starting this meeting a bit different than usual, and I'd like to talk about what we are doing right and what we might change in the patch review process.
• Maxim: From the point of view of CI, and what I monitor at Linaro, and one thing which is taking time and difficult for us to do is notification of patch authors. At the moment we have several challenges. We send out a single notification only to the patch author without copying anyone else. If you copy too many people it will create a lot of noise, every single configuration will want to send that email. For example aarch64 can know it has sent notification for the patch, but not if another notification has or hasn't sent that. For patchwork it is much easier to send out nicely formatted email at the right cadence to the mailing list which may include a bigger audience. Sending out digests would be really useful. At most we get 1-2 emails for patch review of patchwork can handle the patch.
• Carlos: Could we write a bot for this?
• Maxim: I understand how we use the bot to use local email servers. How do we send the summaries?
• Carlos: The bot uses sqlite3 and walks the data with id and date and it is possible.
• Carlos: Your idea is to avoid high noise right?
• Maxim: I would like Gerritt but I don't expect we can deploy that in the GNU Toolchain.
• Carlos: Right.
• Florian: Joseph made a comment and noted that none of the alternatives is compelling enough to make a switch from the email based workflows.
• Maxim: The lack of authority to assign work to people is a flaw? It would be good to have volunteers which would like to review patches.
• Carlos: We do have some pool, for example DJ and Arjun are two people from Red Hat that have volunteered to review patches.
• Maxim: I bet we can get 10-20 people on this list for review.
• Maxim: My thesis is that it will be beneficial to the community and the reviewer.
• Florian: Some reviews fail to catch locally incorrect issues or globally incorrect issues (deployment).
• Florian: So even technically skilled reviews fail to catch issues. So the skill of the reviewer should not be a limiting or high bar factor to reviewing patches.
• Carlos: Yes, we can do this.
• Florian: Could we make this pull? So the developer just pulls a patch and reviews it.
• Maxim: We have upstream time set aside at Linaro to do patch review.
• Adhemerval: A workflow where we define features per releas and review them as point release features. There is no defined plan and that frustrates some developers and is rushed at the end of the release.
• Carlos: What about a 1 month boundary? Deliver the planning by 1 month boundaries.
• Adhemerval: Yes. By having a monthly plan we can more easily post-pone features.
• Carlos: Will the more junior reviewers need mentorship from senior people?
• Maxim: Yes, we need to setup a web page with mentors for review.
• Szabolcs: I find it tricky to review arbitrary patches. Sometimes it's easy or I have a single comment, and sometimes I need to do more research.
• Maxim: We are not the first ones challenged by this problem. In gerritt we have +1 for looks good, but you need a reviewer to approve.
• Maxim: There is quality for humans and computers. Each should be achieved by different means, largely human review and computer review (pre-commit CI).
• AI: For Maxim to send out an email to create a queue of reviewers.
• AI: For Carlos to send out an email about project planning in glibc.

Meeting: 2024-01-29 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY is at 457 patches.
• Carlos's SLI at 269 days average patch age in queue and 124257 accumulated patch days.
• Reviewing blockers for glibc 2.39
• Carlos: I wanted to answer the question that Andreas asked on IRC which was: "Can we but the release branch early?" The answer is Yes, if we feel we're ready we can do that.
• Andreas: Only the s390x issue that we discovered late with --disable-multi-arch.
• Carlos: Yes, 2.39 will just go out the door with this quirk which is that you must have multiarch enabled. Using --disable-multi-arch will break s390x.
• Advisory format updates and release process updates are a release blocker
  • Carlos: I need to review this today, and will review ~1pm EDT.
• Carlos new added test results since the 22nd:
  • tst-align3 failures on 32-bit ARM.

  • Update https://sourceware.org/glibc/wiki/Testing/Tests/elf/tst-align3 with failure?

• Andreas: Added loongarch failures. There are a lot of them.
• Carlos: I wouldn't hold up the release for the failures seen on one specific Loongarch system e.g. gcc401.

• https://portal.cfarm.net/tickets/ should be used for Compile Farm tickets.

• The new failures for s390 FAIL: gmon/tst-gmon-pie, FAIL: gmon/tst-gmon-pie-gprof, are both gcc bugs.
• Carlos: The 32-bit i686 failures on the old boxes look interesting.
• Florian: Possible IFUNC selector bug.
• Andreas: Will capture kernel dmesg to see which instruction causes the SIGILL.
• Andreas: This is not a regression present since 2.38.
• Ended meeting early. Carlos will review advisory discussion blocker.

Meeting: 2024-01-22 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 461 patches.
• Carlos's SLI at 260 days average patch age in queue and 121140 accumulated patch days.
• Patch review is looking at glibc 2.39 release blockers and desirable.
• No blockers for today.
• No desirable patches for today.
• Carlos: Note Fedora 40 downstream mass rebuild happened last week with GCC 14, Binutils 2.41 and glibc 2.39 intermediate build with updated qsort changes from upstream as of e2803cfd8bb00b54816d1a2c381d2cf82b136da6. Results looked good overall.
• Adhemerval: Static pie patch for RISC-V needed additional work.

  • https://patchwork.sourceware.org/project/glibc/patch/mvmplxzvv2j.fsf@suse.de/

• string: Disable stack protector for memset in early static initialization
  • fweimer: Should fix the generic implementation.
  • Andreas: +1 from RM.
• Carlos: Florian, anything that we saw in the Fedora 40 changes?
  • Florian: Yes, downstream-only binutils bug, unrelated to glibc.
• Florian: 2 NEWS and 1 manual update.
  • Florian: Need to repost one patch changes.
  • Florian: Forgot the ABI change for utmp and utmpx, will propose for glibc 2.40.
  • Adhemerval: Do you suggest we keep the interface in the next release?
  • Florian: I don't know, we probably need to disable it in the headers.
  • Florian: We will make the change downstream so we don't run into problems.
  • Adhemerval: SUSE did a lot of work to fix this and we should go in that direction.
• Szabolcs: Found a BE-only vector math code bug for AArch64 but we can fix it and backport.
• Carlos: We should have a script that captures the results? Then devs could just paste the results.
• Carlos: The nptl/tst-thread-exit-clobber is odd, but ppc32 and ppc64 is an issue that Raji has to review.
• Florian: Note that if you run with the python ABNF parser then it might timeout tst-rtld-list-diagnostics.
• Andreas: Noted that test-cxa_atexit-race2 was a timeout for s390x so we don't have to worry there.
• Florian: We should add a new test exit code for timeout to make it clear in the reporting.
  • Carlos: Could still be a timeout due to deadlock, but knowing that status is better than not knowing.
• Carlos: I need to do machine testing this week and add notes to the wiki. I will look at a script to collect the items.

• Carlos: I want to reivew this https://patchwork.sourceware.org/project/glibc/patch/779c4fcc-5dc9-4bc1-9d68-cbce31a0d8e7@redhat.com/ and include it in the release. I'll TO the RM and get approval.

Meeting: 2024-01-15 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 458 patches.
• Carlos's SLI at 255 days average patch age in queue and 117996 accumulated patch days.
• Leading into glibc 2.39 release on February 1st.
• 17 days until release.
• Release blockers
  • Revert to original qsort implementation and apply subsequent mergesort changes with heapsort as fallback.
    • Florian: I acked Adhemerval's patch.
    • Adhemerval: Sending a new version with Florian's suggested changes.
    • Noted that Release Manager is out this week so the qsort changes will be pushed this week.
• Desirable for the release
  • Support PLT Rewrite.
    • HJ: v2 is sent for review.
    • Carlos: Will review after the call.
  • Carlos: I reviewed the ffsll changes and approved the small Intel change for 2.39 but broader change for 2.40.

• List of issues: https://inbox.sourceware.org/libc-alpha/2030348.PIDvDuAF1L@pinacolada/

  • Reviewed list of issues and progress. Those that needed to be committed are now in the tree.
• Szabolcs: What about the TLS issues Florian raised?

  • https://inbox.sourceware.org/libc-alpha/8734v1ieke.fsf@oldenburg.str.redhat.com/

  • Interposed malloc didn't break before and was a happy accident.
• Future of PLT rewrites?
  • Adhemerval: What is the future of this feature?
  • HJ: IMO as long as JITs are supported on Linux then this isn't an issue.
• Szabolcs: Review for NEWS entry

  • https://patchwork.sourceware.org/project/glibc/patch/20240112164245.467067-1-szabolcs.nagy@arm.com/

  • Carlos: I'll review the news entry. Thanks.

Meeting: 2024-01-08 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 484 patches.
• Carlos's SLI at 242 days average patch age in queue and 118723 accumulated patch days.
• Starting at 83534.
• The release is coming up in February 2024.
• Adhemerval: One patch which should be added to release blockers.
• [v2] linux: Fix fstat64 on alpha and sparc64 (Adhemerval)
  • Needs to be included to fix the failures.
• [PATCH] Remove ia64-linux-gnu (Adhemerval)
  • Removal was blocked on Linux 6.7 release.
  • Once build-many-glibcs gets linux 6.7 support we will need a special case if we don't deprecate it.
  • Carlos: To review the ia64 removal.
• Improve rounding to interger function for C23 (Adhemerval)
• [v3] posix: Sync tempname with gnulib (Adhemerval)
  • Risk could be tempname breakage?
  • Defer to 2.40.
• [v2] stdlib: Reinstate stable mergesort implementation on qsort (Adhemerval)
  • Florian to review.
  • This is a release blocker for 2.39 since we want to avoid further application issues.
• Already merged the AArch64 SME support, nothing further for aarch64 for 2.39.
• Should glibc update to autoconf 2.72?
  • There is a specific clang issue and requires an update to autoconf 2.72.
  • Given that clang needs out of tree patches anyway then it makes it less urgent.
  • Carlos: I expect that glibc won't update to autoconf 2.72 until August or even later to allow the distributions to include newer autoconf.
• Maxim: Preference for the ia64 port to be removed in glibc to support simpliciation of gcc backends.
• Carlos: I want to make forward progress on pthread condvar missing signal, and pthread cancellation fixes from Adhemerval.
• Szabolcs: The old way that CET worked, that used to be in glibc code, and that code assumed that certain things are done by kernel/userspace and the new kernel ABI assumes userspace has to do things.
  • Adhemerval: Please raise this on the CET thread.
  • Szabolcs: Will raise the issues on the thread.
  • Carlos: If the semantics of the dynamic loader change based on markup and when the callbacks are called is unclear then we can refactor or document.
  • Adhemerval: Shadow stack for 32-bit doesn't work, is that an issue?
  • Carlos: It is not an issue that it doesn't work with i686.

Meeting: 2024-01-01 @ 0900h EST5EDT

Meeting cancelled.

Meeting: 2023-12-25 @ 0900h EST5EDT

Meeting cancelled.

Meeting: 2023-12-18 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 485 patches.
• Carlos's SLI at 226 days average patch age in queue and 111649 accumulated patch days.
• Starting at 82374
• [V1] powerpc: Optimized strncmp for power10 (Amrita)
  • Needs IBM review.
• [v2] x86/cet: Update CET kernel interface (HJ)
  • Needs review.
• RISC-V: Add support for dl_runtime_profile (BZ #31151) (Aurelien)
  • risc-v maintainers need to review.
• [v3] x86: Unifies 'strlen-evex' and 'strlen-evex512' implementations. (Matthew)
  • Intel needs to review.
• aarch64: Add SIMD attributes to math functions with vector versions (Joe)
  • Carlos: Please add your reviewed-by as you push this.
• [V3] powerpc: Fix performance issues of strcmp power10 (Amrita)
  • Needs IBM review.
• s390: Set psw addr field in getcontext and friends. (Stefan)
  • Florian to comment on it.
• [v10] RISC-V: ifunced memcpy using new kernel hwprobe interface (Evan Green)
  • Needs risc-v review.
• getaddrinfo: translate ENOMEM to EAI_MEMORY (bug 31163) (Andreas)
  • Florian: I'll review sometime this week.
• [v7] posix: Deprecate group_member for Linux (Joe)
  • Needs review.
• [v3,1/2] Add random benchmark
  • Carlos: I'll review this.
• Fix elf/tst-env-setuid[-static] if test needs to be rerun. (Stefan)
• [v6] Add rseq extensible ABI support (Michael Jeanson)
• Stopped at 81770.

Meeting: 2023-12-11 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 476 patches.
• Carlos's SLI at 231 days average patch age in queue and 111249 accumulated patch days.
• Starting at 81900.
• resolv: Fix a few unaligned accesses to fields in HEADER (Ludwig)
  • Carlos: Impact is for all arches.
  • Florian: I need to review.

• LoongArch: Delete excessively allocated memory. (caiyinyu)

  • Carlos: Commented on list.
• elf: Add ELF_DYNAMIC_AFTER_RELOC to rewrite PLT (HJ)
  • Needs review.
• aarch64: Add SME support (Szabolcs)
  • Carlos: What kind of review are you looking for?
  • Szabolcs: Just general issues. Distro perspective.
• x86: Check PT_GNU_PROPERTY early (HJ)
  • Changes requested by Noah e.g. refactor vs. new functionality.
• Do not build sparc32 libgcc functions into static libc (Joseph)
• sysdeps/x86/Makefile: Split and sort tests (HJ)
  • Reviewed by Noah.
• Generic x86-64 CPU diagnostics dumper (Florian)
  • Only during the diagnostics.
• [v3] RELRO linkmaps (Florian)
  • Still applying. Hard to rebase.
  • Carlos: Needs review.
• stdlib: Reinstate stable mergesort implementation on qsort (Adhemerval)
  • Florian: Needs further review.
• [v5] Add rseq extensible ABI support (Michael)
  • Fails CI, testing fails on arm32 and aarch64.
  • Needs review.
• x86/cet: Update CET kernel interface (HJ)
  • Needs review.
  • Siddhesh: This is slightly different than the test patches we had in Rawhide at one point.
• [v6] Improve loader environment variable handling (Adhemerval)
  • Siddesh: I'll review.
• [v2] rtld: Add glibc.rtld.enable_secure tunable (Joe Simmons-Talbott)
  • Szabolcs: You write the tunables in a different order and you get different behaviour?
  • Siddhesh: Adhemerval's patch first parses all tunables and then you apply them so it should help this, you can then put enable_secure at the stop of the list.
  • Siddhesh: Will ask the question about ignoring all other tunables in AT_SECURE emulation.
• [V5] powerpc: Optimized strcmp for power10 (Amrita)
  • Raji to review.
• Stopped at 81431.
• [v2,1/2] powerpc: Add space for HWCAP3/HWCAP4 in the TCB for future Power. (Manjunath)
  • Raji to review.

• debug/getwd_chk.c: warning should be emitted for the getwd_chk symbol. (Frederic)

  • Carlos: Will review.
• stdlib: Optimize number of calls to comparison function in qsort (Kuan-Wei)
  • Carlos: Will point out Adhemerval's patch.
• Chain stpcpy(3) to terminate strings after mempcpy(3) (Alejandro)
  • Needs review overall.
• RISC-V: ifunced memcpy using new kernel hwprobe interface (Evan)
  • Needs RISC-V maintainer review.
• Stopped at 81043.

Meeting: 2023-12-04 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 451 patches.
• Carlos's SLI at 250 days average patch age in queue and 113787 accumulated patch days.
• Starting review at 81209 (last week 80738)
• stdlib: Optimize number of calls to comparison function (Kuan-Wei)
  • Changes requested by Florian.
• [RFC,v4] Add rseq extensible ABI support (Michael)
  • Marked RFC for community discussion.

• LoongArch: Add support for TLS Descriptors (mengqinggang)

  • Changes requested by reviewers.
• [v2] math: Add new exp10 implementation (Joe Ramsey)
  • Paul Zimmerman commented. Szabolcs to look.
• RISC-V: ifunced memcpy using new kernel hwprobe interface
  • Needs review by Palmer (machine maintainer)
• [V4] powerpc: Optimized strcmp for power10 (Amrita)
  • Raji to review.
• powerpc: Add HWCAP3/HWCAP4 data to TCB for Power Architecture. (Matti)
  • Patch fails to apply. Marked Failed CI
• [v2] Move CVE information into advisories directory (Siddhesh)
  • Florian to look at this.

• [RFC] resolv: Align buf before second query for A_AAA in res_context_query (Ludwig)

  • Marked RFC.
  • Changes requested to fix architectures with alignment traps.
• aarch64: fix tested ifunc variants (Szabolcs)
  • Maintainer should commit.
• elf: Add TLS modid reuse test for bug 29039 (Szabolcs)
  • Needs review.
  • Adhemerval to review test case.

• elf: Avoid type aliasing violation on tunable_get_{default, val} (Adhemerval)

  • DJ raised this when reviewing another patch.
  • Siddhesh to own review.
• [1/2] Add random benchmark (Wilco)
  • Needs cleanup of Makefile placement.
  • Carlos commented on list.
• strcasestr: try to find non-alpha char in NEEDLE (James)
  • Carlos: Has anyone reviewed this?
  • Adhemerval: Wilco had some reservations and wasn't sure if this was an improvement.
  • Carlos requested clarification of copyright status.
• RISC-V: Add dynamic TSO support (Christoph)
  • Needs RISC-V machine maintainer review.
• Stopped at 80656.

Meeting: 2023-11-27 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 438 patches.
• Carlos's SLI at 250 days average patch age in queue and 110838 accumulated patch days.
• Starting at 80738.
• stdlib: Fix array bounds protection in insertion sort phase of qsort (Florian)
  • Florian: Need to think about the changes with respect to the breakage in Fedora.
  • Adhemerval has reviewed.
  • Florian: Previous problem was self-element comparison and that is fixed.
  • Florian: Current patch is related to running off the end of the array (bug).
  • Florian: The only remaining issue is the lack of sorting stability.
  • There was some discussion about sort stability across OS.
  • Final question was: Do we want a symbol for this change given the impact?
  • Adhemerval: Will provide RB for current patch and send simplification.
• [RFC,v2] Add rseq extensible ABI support (Michael)
  • Failed CI
• [glibc-htdocs] Add a security page (Siddhesh)
  • Carlos to review.
  • Carlos to poke DJ to filter out glibc-htdocs patches.
• Improve MAP_HUGETLB with glibc.malloc.hugetlb=2 (Adhemerval)
  • Carlos: I've asked DJ for review.
• [v5] Improve loader environment variable handling (Ahemerval)
  • Missing 5 RB from this series.
  • Siddhesh will review loader environment handling.
• Avoid padding in _init and _fini. [BZ #31042] (Stefan)
  • Stefan can commit as machine maintainer.
• powerpc : Add optimized memchr for POWER10 (Mahesh)
  • Raji to review as machine maintainer.
• [PATCHV3] powerpc: Optimized strcmp for power10 (Amrita)
  • Likewise.
• [v2] Multiple floating-point environment fixes (Adhemerval)
  • Carlos to review 1/7 again.
• x86: Only align destination to 1x VEC_SIZE in memset 4x loop (Noah)
  • Not reviewed last week. Carlos to look over later as reviewer of last resort.
• Stopped at 78853
• Szabolcs: Someone sent me a Red Hat reported bug.

  • https://bugzilla.redhat.com/show_bug.cgi?id=2251557

  • https://sourceware.org/bugzilla/show_bug.cgi?id=29039

  • Looks like a real bug.
  • Have asked Hector Martin to submit to mailing list.
  • Siddhesh: Discussed the advisories patch for glibc, will send v3 for reivew.
• Adhemerval: Send a question about how we should handle memcpy with equal source and destination.
  • Not clear from our tests or docs that we actually support it.

  • https://inbox.sourceware.org/libc-alpha/1e8beece-f865-4309-a28f-6782135e2a8a@linaro.org/

  • Working on a standard extension change that allows certain compiler optimizations that might require allowing certain arguments.
• Adhemerval: Raised the issue that we don't know why this change was made in ld.so.

  • https://sourceware.org/bugzilla/show_bug.cgi?id=31076

  • Did we make this change for a reason?
  • Carlos: What does binutils do by default?
  • Florian: The kernel unmaps.
  • Adhemerval: The kernel does nothing with the holes.
  • Adhemerval: What do we get by mprotecting the holes?
  • Gadgets are removed since there could be overlaps.
  • Issue 1: There is a gap issue.
  • Issue 2: There is a RELRO alignment issue too.
  • Adhemerval: I recall the RELRO issue, but I don't recall the details.
  • Florian: To preserve correctness we do different things.

    • https://sourceware.org/pipermail/libc-alpha/2022-May/138638.html

    • https://sourceware.org/bugzilla/show_bug.cgi?id=28743

Meeting: 2023-11-20 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 462 patches.
• Carlos's SLI at 232 days average patch age in queue and 108536 accumulated patch days.
• Started at 80169.
• Various qsort fixes (Florian)
  • Florian: Quick look at the first patches.
• [v2] aarch64: Add vector implementations of expm1 routines (Joe)
  • Szabolcs: Will review.
• powerpc : Add optimized memchr for POWER10 (Mahesh)
  • Looking for Raji to review as POWER maintainer.
• [PATCHV3] powerpc: Optimized strcmp for power10 (Amrita)
  • Looking for Raji to review as POWER maintainer.
• [RFC] stdbit.h implementation (Jakub)
  • Floriand and Carlos discussed the RFC and marked Changes requested.
  • Consensus doesn't yet exist for the solution, but we feel gcc has to implement something before glibc.
  • At the very least we'll need some form of this patch, so "Changes Requested"

• [v2] malloc_stats(): Fix unsigned int overflow (Niklas)

  • Changes requested.
• [v2] ldconfig: Fixes for skipping temporary files. (Florian)
  • Committed.
• Make accounting database no-op (Adhemerval)
  • Florian to review.
• Move CVE information into advisories directory (Siddhesh)
  • Siddhesh: Waiting on Florian for a couple of points.
• Multiple floating-point environment fixes (Adhemerval)
  • Carlos to review patch 1 in series again.
• Remove ia64-linux-gnu (Adhemerval)
  • Marked deferred.
• x86: Only align destination to 1x VEC_SIZE in memset 4x loop (Noah)
  • Needs review.
• x86: Improve ERMS usage on Zen3+ (Adhemerval)
  • AMD will take a look at this.
• [v3] posix: Sync tempname with gnulib (Adhemerval)
  • Adhemerval to Ping Paul for review.
• [v5] posix: Deprecate group_member for Linux (Joe Simmons-Talbott)
  • Carlos to review. Florian: Only the gnulib version is used.
  • Fix euidaccess too?
• [v3] elf: dl-load: Get rid of alloca usage. (Joe Simmons-Talbott)
  • Changes requested.

• malloc: Use get_nprocs on arena_get2 (BZ 30945) (Adhemerval)

  • Adhemerval: Will ask DJ for RB.
• elf: Get rid of alloca usage in _dl_start_profile (Joe Simmons-Talbott)
  • Carlos to review.
• Stopping at 76885.
• Discussed state of pthread cancel review from Carlos.
• Discussed state of pthread condvar review from Carlos.
• Adhemerval will review Florian's qsort changes for application compatibility.

Meeting: 2023-11-13 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 478 patches.
• 76677 - Being on review
• 79619 - Real bug
• 79610 - Adhemerval will take care
• 79575 - Adhemerval will take care
• 79563 - Szabocs will take a look
• 79502 - Make accounting database no-op
  • - Florian: not sure about Fedora implications
• 79435 - Need more discussion
• 79340 - Adhemerval will take care
• 79243 - Skip
• 79195 - Skip
• 79068 - Waiting for 6.7 release
• 78990 - Szabolcs will take care
• 78895 - Superseeded
• 78890 - Intel developers will take care of it
• 78853 - Florian will contact AMD people
• 78835 - Florian assigned to himself
• 78791 - Florian assigned to himself
• 78663 - Skip (changes requested)
• 78539 - Florian assigned to himself
• 78460 - Florian assigned to himself
• Florian:
  • - GCC patch for aarch64

    • https://inbox.sourceware.org/gcc-patches/87r0kx6eez.fsf@oldenburg.str.redhat.com/ https://inbox.sourceware.org/gcc-patches/874jht5tsq.fsf@oldenburg.str.redhat.com/

• Szabolcs:
  • - Nothing

Meeting: 2023-11-06 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 459 patches.
• Carlos's SLI at 214 days average patch age in queue and 103254 accumulated patch days.
• Starting at 79195.
• v2: Multiple floating-point environment fixes (Adhemerval)
  • Carlos to look at the hppa code.
• Update BAD_TYPECHECK to work on x86_64 (Flavio)
  • Needs Hurd review.
• Remove ia64-linux-gnu (Adhemerval)
  • On thread discussion that upstream kernel support needed for a Linux port.
• [1/6] aarch64: Add vector implementations of asin routines (Joe)
  • Szabolcs: More vector math functions.
• x86: Only align destination to 1x VEC_SIZE in memset 4x loop (Noah)
• x86: Fix unchecked AVX512-VBMI2 usage in strrchr-evex-base.S (Noah)
• v3: Add a tunable to decorate anonymous memory maps (Adhemerval)
  • Missing 3 RBs for v3.
• x86: Improve ERMS usage on Zen3+ (Adhemerval)
  • Would be valuable to reach out to AMD for feedback.
• 78835: [v2,7/7] linux: Use fchmodat2 on fchmod for flags different than 0 (BZ 26401) (Adhemerval)
  • Carlos: If Florian gave an overall review then we should put it into master and start testing in the rolling release distributions.
• resolv: free only initialized items from gai pool (Jan Palus)
  • Needs review.
• Stopped at 78539.
• Carlos: Siddhesh, May we please run the cleanup scripts again to remove older patches that haven't seen movement in the queue based on the community agreed upon time periods?
• Siddhesh: Yes, I can run the scripts and cleanup the items that don't meet the current time period.
• Adhemerval: Review for pthread cancel?
  • Carlos: Yes, Thursday/Friday at the latest this week for review.
• Siddhesh: Will you share a v3 for the improved loader env var handling?
  • Ahdemerval: Yes, in the queue.

Meeting: 2023-10-30 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 454 patches.
• Carlos's SLI at 212.53813559322035 days average patch age in queue and 100318 accumulated patch days.
• Starting at 78663.
• Started by reviewing the oldest open patches in the queue.

• Carlos: I could create a new project here https://gitlab.com/gnutools and we could add the scripts there.

• Siddhesh: Works for me.
• Carlos: I have the AI to create a patchwork scripts repo called "gnutools-bots"
• Maxim: A bot that enforces policy should have a way for people to contribute.
• Siddesh: Should I pull the trigger on sending emails for commits that don't match?
• Carlos: Yes, start by send email to us, and we'll review the results, and then turn it live.
• Carlos: Once we have a repo we can ask for help to automate re-applying the patches.
• Carlos : AI split DJ's apply-patch bot into two, one for head and one for applied at the time of sent/base-rev.

• libio: Remove comment in <stdio.h> (Johnny) - Changes requested.

• Add a tunable to decorate anonymous memory maps (Adhemerval)
  • Ian Rogers from Google provided the initial RFC.
  • Adhemerval: I expanded the idea the annotate the pthread stack.
  • Performance implications: To set the name requires setting the mm lock.
  • It can show on specific workloads, so it's behind a tunable, off by default for now.
• test: Run the tst-tls-allocation-failure-static-patched with test-wrapper. (Yanzhang)
  • Carlos: I saw the test failing in December for x86_64 cross to AArch64.
  • Carlos: Can we pre-commit CI test cross-test-ssh.sh?
  • Maxim: We do not use cross-test-ssh.sh currently. From the technical point of view you want a container on the host to drive testing, and a second container on the target that will run the tests.

  • Carlos: Yes, the OpSec for this case is very difficult for pre-commit CI.

  • Maxim: I raised that I would like the applypatch bot to run for all GNU Toolchain projects.
  • Carlos: I'll talk to DJ about doing that.
• Stopped at 78463.

Meeting: 2023-10-23 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 479 patches.
• Carlos's SLI at 201.51446280991735 days average patch age in queue and 97533 accumulated patch days.
• Starting at 78358.
• [v2] AArch64: Add support for MOPS memcpy/memmove/memset (Wilco)
  • Szabolcs to review.
• elf: Fix force_first handling in dlclose (bug 30785) (Florian)
  • Florian: In testing in Fedora, could wait for review while downstream tests.
• ldconfig: Actually ignore dpkg-related temporarily files (Florian)
  • Needs review. Should be straight forward.
• [v5] posix: Deprecate group_member for Linux (Joe)
  • Florian to review.
• [v3] elf: dl-load: Get rid of alloca usage. (Joe)
  • Florian: Need to be careful about the usage via dl-minimal.
  • Reviewers need to make sure that if we don't free these that we can still free other allocations earlier.
  • Still needs more review regarding the early allocations that might be blocked.
• Improve loader environment variable handling (Adhemerval)
  • Siddhesh to resume review this week.
• At 77763
• Add MSG_SPLICE_PAGES from Linux 6.5 to bits/socket.h (Joseph)
  • Dropped/Rejected.

• malloc: Use get_nprocs on arena_get2 (BZ 30945) (Adehemerval)

  • Expecting DJ to review again and see if we can get consensus.
• posix: Sync tempname with gnulib (BZ 30958) (Adhemerval)
  • Needs review.
  • Needs v2 with updated SHARED-FILES.
• Stopping at 77439.
• Adhemerval:
  • Review pthread cancellation.
  • Review abort() AS-safety again.
  • Carlos: What about opendir() regressions?
    • Only impacts non-LFS calls on 32-bit ABIs on new FS.
    • Primary impact on qemu-user running 32-bit code.
• Szabolcs: Sign of zero?

  • https://patchwork.sourceware.org/project/glibc/list/?series=25383

  • For vector math we don't care about the sign?
  • Carlos: I think it's fine that we ignore the sign of zero in these cases.
    • Carlos responded onlist.
• Arjun: One more failure to review. Could be false alarms.
  • Florian: Allow-list for pre-commmit CI failures in containerized tests?
  • Carlos: Yes, Arjun may you please check with Linaro on this?
• Carlos: Welcome Ross Burton! Anything you want to review?
• Ross: yocto project distro building. Patches to the list.

Meeting: 2023-10-16 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2023-10-09 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2023-10-02 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 486 patches.
• Carlos's SLI at 187.46138211382114 days average patch age in queue and 92231 accumulated patch days.
• Starting at 76972
• Consolidate NSS functionality into nss subdir (Arjun)
  • Arjun: Couldn't measure any specific improvements.
  • Arjun: All of the NSS entry points will go into a static archive for static applications to avoid dlopen().
  • From a review perspective it's all Makefile changes.
  • Arjun: Looking for broader consensus.
  • Adhemerval: The idea is to remove the dlopen in the static case?
  • Adhemerval: If you apply this, what is the missing link?
  • Arjun: To create a whole set of static built entry points and to conceptually make the nss/ subdirectory have all those entry points.

  • Cover letter: https://sourceware.org/pipermail/libc-alpha/2023-October/151854.html

  • files and dns are part of libc.a, and we use those already.
  • Looking for others to review the concept and provide feedback.
• 76941: Remove libcrypt support (Adhemerval)
  • Carlos to review for removal.
• 76885: elf: Get rid of alloca usage in _dl_start_profile (Joe)
  • Needs review. How did you test this?
  • Need to build with profiling on and test LD_PROFILE?
  • Did you test the scratch buffer triggering malloc()?
• 76855: [RFC] linux: Use fchmodat2 on fchmod for flags different than 0 (BZ 26401) (Adhemerval)

  • CI failure related to old seccomp failure (or AppArmor).

  • Florian sees this is good. Need to wait for 6.6.
• 76847: [v2] nss: Get rid of alloca usage in makedb's write_output. (Joe)
  • Should be straight forward for makedb writing output.
• 76835: [v3] nss: Get rid of alloca usage in db-XXX (Joe)
  • Should also be straight forward to review.
• 76831: Fix WAIT_FOR_DEBUGGER for container tests. (Stefan)
  • Carlos to review.
• 76816: [v3] Linux: add ST_NOSYMFOLLOW (Kir)
  • Adhemerval to push commit.

• 76811: [RFC] pthread_create: Name stacks in /proc/<pid>/maps (Ian)

  • What are the performance implications?
  • Carlos to ask Ian to post a versioned RFC.
• Stopping 76764.
• Carlos noted we should commit 59588.
• Adhemeral: Need review for pthread cancellation fixes.

Meeting: 2023-09-25 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Many attendees travelling back from GNU Tools Cauldron 2023.

• Carlos sends regrets as he will be travelling back that day.

Review new patches and attendee requested reviews.

Meeting: 2023-09-18 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 459 patches.
• Carlos's SLI at 185 days average patch age in queue and 86486 accumulated patch days.
• Review today is focused on the status of upcoming CVEs and distribution rebuilds.
• CVE-2023-4527: no-aaaa (Moderate impact)
• CVE-2023-4806: getaddrinfo (Moderate impact)
• CVE-2023-4813: gaih_inet (Moderate impact)

Meeting: 2023-09-11 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 455 patches.
• Carlos's SLI at 182.0930735930736 days average patch age in queue and 84127 accumulated patch days.
• Starting at patch 75638

• [v2] stdio: Remove libc_message alloca usage (Joe)

  • Discussed briefly stack clash mitigating many of these patches.
  • Objective discussion about dynamic stack adjustment and better code.
  • Adhemerval: Removing alloca generates better code.
  • Understanding allocation patterns and sometimes change to static.

• LoongArch: Add lasx/lsx support for _dl_runtime_profile. (Yinyu)

  • Needs maintainer review.
• [COMMITTED,2.38] NEWS: Add the 2.38.1 bug list (Florian)
  • Discussed 2.39 process and adding a .1 section in the NEWS.
• intl: Treat C.UTF-8 locale like C locale, part 2 (BZ# 16621) (Bruno)
  • Florian posted questions.
• [1/2] elf: Wire up _dl_diagnostics_cpu_kernel (Florian)
  • Looking forward to Intel review.

• libio: Fix oversized io_vtables (Adam)

  • Reviewed.
• [v2] RISC-V: Implement TLS Descriptors. (Ishi)
  • Needs machine maintainer review.

• LoongArch: Add ifunc support for str{cpy, rchr},

  • Needs machine maintainer review.
• sysdeps/alpha/string-fzi.h: fix include guards inconsistency (James)
  • Needed patch? We don't have style guide for this.
• strcasestr: check if ne[0] is in hs with strchr or strpbrk as does strstr (James)
  • Needs review.
• build-many-glibcs: Add a RISC-V config with most of the B extensions (Palmer)
  • Discussed and rejected.
• [v4] elf: Always call destructors in reverse constructor order (bug 30785) (Florian)
  • Already committed.
• elf: Fix memory leaks for dl_scope_free_list (bug 26641) (Peter)
  • Changes requested. Split into two fixes.
• io: Do not implement fstat with fstatat
  • Superseded.
• [v2] elf: Avoid pointer-arithmetic underflow in ldconfig (Peter)
  • Changes requested.
• Stopped at 75223.
• [resend PATCH] Fix miscompilation and thus build on ia64's gcc-10 and later (Andreas)
  • Florian: Should be pushed.
  • Carlos: If it fixes a downstream reported issue we should push it.
• Siddhesh: Quick reminder that I had sent out an email to propose setting up a glibc CNA. Andreas, Maxim, Adhemerval could you please have a look at this.

Meeting: 2023-09-04 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2023-08-28 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY 458 patches (+11 from last week)
• Carlos's SLI at 168.79828326180257 days average patch age in queue and 78660 accumulated patch days.
• [PATCH v3] localedata: Translit common emojis to smileys [BZ #30649] (Colin)
  • Siddhesh requested we raise this for review following request from Colin.
  • Florian to follow up with Colin on final changes.
• Starting at 74812.

• LoongArch: Add ifunc support for {raw}memchr (dengjianbo)

  • Needs RISC-V maintainer review.
• nscd: Skip unusable entries in first pass in prune_cache (bug 30800) (Florian)
  • Needs review. Localized to prun_cache(). Generic in terms of cache.
• New functions tcgetwinsize and tcsetwinsize (Soumendra)
  • Changes requested, needs update to 2.39.

• LoongArch: Clean up after Binutils minimal version bump (Xi)

  • Machine maintainer can commit as required.
• [v3] string: Use builtins for ffs and ffsll (Adhemerval)
  • Needs review across arches.
  • Should we remove the benchtests/ffs-inputs or ffsll-inputs?
• [v3,COMMITTED] elf: Check that --list-diagnostics output has the expected syntax (Florian)
  • Discussed that CI failed.
  • codonell: Do the check and build use base-commit.
• Stopped at 74693.
• Adhemerval: Discussed pidfd version two, and clone3 support for remaining arches.
• Maxim: Would like to discuss base-commit ref.
  • base-commit ref is not available in the git commit message.
  • Florian: Do we want to test on HEAD or some other ref?
  • Maxim: We want to test on HEAD. But testing takes time, so HEAD may move.
  • Carlos: We want to test on HEAD. But testing moves, so we attempt HEAD at the time the patch is sent.

Meeting: 2023-08-21 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY 447 patches.
• Carlos's SLI at 167.6 days average patch age in queue and 76285 accumulated patch days.
• Discussed the case of pidfd usage and the races that it closes.
  • fweimer: A library can use the non-pidfd versions of these functions.
  • Unexpected pids should not be created for the wait functions.
  • pidfd_spawn is more conservative and easier to support than clone3.
  • May we delay the addition of fork_np?
  • Given the current model of fork_np we are concerned that this API will need to use completely new APIs to follow on with the kernel clone3 extensions.
  • The community upstream has been asking for clone3-like interface to use cgroups v2. If they can use the spawn-like interface then we delay and continue to review the design of fork_np or a variant of the clone3 interfac.e
• Starting at 74376

• id_ID: Update Time Locales (RushingAlien)

  • Needs review.
• [v11,1/3] posix: regcomp(): clear RE_DOT_NOT_NULL (Ahelenia)
  • Carlos to review.
• Remove references to the defunct db2 subdir (Andreas)
  • Florian to review.
• m68k: Fix build with -mcpu=68040 or higher (BZ 30740) (Adhemerval)

• m68k: Use M68K_SCALE_AVAILABLE on mpn_lshift and mpn_rshift (Adhemerval)

  • Ping again for small changes.
• Add pidfd and cgroupv2 support for process creation (Adhemerval)
  • v8 patch 7/7 fails CI. Marked superseded. Adhemerval to post v9.
• Stopped at 74317.
• Discussed Florian's queue.
• Discussed ABNF import issue with testing.
• [1/5,v2] aarch64: Add vector implementations of tan routines (Ramsay)
  • Delaying review until Joe is back to handle feedback.
• Discussed with Maxim the new patchwork queues for newlib and binutils.
  • Bot user does not have permission to post check data.

Meeting: 2023-08-14 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Carlos's SLI at 159.64347826086956 days average patch age in queue and 73436 accumulated patch days.
• State NEW delegate NOBODY is at 452 patches.
• Started at 74097.
• Looking across the current set of patches and reviewing the state of CI/CD in the list.
• Discussing strategies for CI and current failures.
• configure: Add -Wall again to the default CFLAGS (fweimer)
  • RB by Siddhesh.
• RISC-V: Enable static-pie. (Yanzhang Wang)
  • Fails CI, notified author.
• Add pidfd and cgroupv2 support for process creation (Adhemerval)
  • Fails CI, notified author.
• Discussed failure of patch application:

  • https://gitlab.com/djdelorie/glibc-cicd/-/issues/5

• [1/5] aarch64: Add vector implementations of tan routines (Joe)
  • Failed CI, notified author.
• %Z [PATCH v6] (Stanley Lancaster)
  • Failed CI, notified author.
• Discussed sending failures and would like to use a per-project mailing list or whole regression list.

Meeting: 2023-08-07 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW and delegate NOBODY is at 452 patches.
• 73669 - MIPS: Sync elf.h from binutils
  • Florian will review

• 73663: hurd: statvfs: f_type -> f_type

• Adhemerval will install
  • 73645: Fix tst-bz21269
• Changes requested
  • 73634 - Document ld.so --list-diagnostics, add syntax tests
• Adhemerval will review

  • 73611 - LoongArch: Redefine macro LEAF/ENTRY.

  • loongarch maintainers to review

• 73601 - Define am_pm string

  • Locale change for specific language
  • Florian will respond to thread.
• 73576 - Make abort AS-safe
  • Continue discussion maillist.
• 73573 - Add pidfd and cgroupv2 support for process creation
  • Florian take a look.
• 73547 - aarch64: Add vector implementations of tan routines
  • aarch64 buildbot showed mathvec/check-abi-libmvec failure.

  • https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/444/artifact/artifacts/artifacts.precommit/07-check_regression/fails.sum

  • https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/465/artifact/artifacts/artifacts.precommit/00-sumfiles/tests.log.1.xz

• 73541 - aarch64: Improve SVE sin polynomial
  • Being discussed on maillist
• 73501 - Add PTRACE_SET_SYSCALL_USER_DISPATCH_CONFIG etc. from Linux 6.4 to sys/ptrace.h
  • Adhemerval will take a look.
• 73491 - RISC-V: ifunced memcpy using new kernel hwprobe interface
  • Under review
• 73447 - Use binutils 2.41 branch in build-many-glibcs.py
  • Adhemerval will take a look.
• 73446 - sparc: Remove optimize md5, sha256, and sha512
• 73437 - Add PACKET_VNET_HDR_SZ from Linux 6.4 to netpacket/packet.h
  • Adhemerval will take a look.
• 73432 - x86: Fix for cache computation on AMD legacy cpus.
  • Committed.
• 73429 - nscd: Do not rebuild getaddrinfo (bug 30709)
  • Under review
• 73409 - [2/2] Loongarch: Add ifunc support and add different versions of strlen.
  • Under review.
• 73396 - x86_64: Optimize ffsll function code size
  • Dropped.
• 73384 - %Z [PATCH v6]
  • Patch is wrong - changes requested.
• 73356 - fcntl fortification
  • Adhemerval will take a look. Changes requested.

* Florian

• Ask for RELRO linkmap review
• [v2,14/32] elf: Use struct link_map_private for the internal link map

https://patchwork.sourceware.org/project/glibc/patch/e2362f80de108090b8f1287b6aa6b5026a694662.1688741159.git.fweimer@redhat.com/ * Noah Goldstein:

• Backport x86 string routines on RH. Gentoo/Debian has raised some concern about backporting performances fixes.

* Szabolcs Nagy:

• Nothing.

* Andreas:

• Nothing.

* Maxim:

• [Precommit CI] Output of failed tests is in artifacts.precommit/00-sumfiles/tests.log.N.xz ; e.g., https://ci.linaro.org/job/tcwg_glibc_check--master-aarch64-precommit/465/artifact/artifacts/artifacts.precommit/00-sumfiles/tests.log.1.xz

Meeting: 2023-07-31 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW and delegate NOBODY is at 412 patches.
• Carlos's SLI at 161.3 days average patch age in queue and 67746 accumulated patch days.
• Noted that queue has gone up a lot during the run-up to the release where we aren't reviewing as many patches as before.
• Reviewing the status of the release.
• SPARC 64-bit issue with fortification.
  • Not a release blocker.

  • Should be reviewed to determine why --enable-fortify-source causes failures.

• IA64 GPREL22 relocations?
  • Adhemerval: A quick analysis based on our discussions 3 years ago. GCC 10 defaults to no-common for variable definitions. On IA64 it breaks depending on the gcc configuration. I don't know why Gentoo sees the issue.
  • Florian: The correct fix is likely a binutils fix.
  • Florian: We don't support static PIE on ia64?
  • Andreas: Gentoo has a workaround that keeps working over the last 3 years.
  • Workaround exists and Gentoo is applying the workaround.
  • Not a release blockers.
• Carlos: Do we have a fix for the tst-realpath issue?
  • Florian: We have a fix for that. Patch 73331.
  • stdlib: Improve tst-realpath compatibility with source fortification (Florian)
    • Real bug in the test.
    • Will go in after the release with backports.
• Carlos: Adhmerval, Did we review all the gcc version fixes for fortification.
  • Adhemerval: Yes, all reviewed.
• Carlos: I owe Andreas a review of the release notes.
• Andreas: Savannah group won't let me post news?
• Carlos: I will double check offline to see what needs doing.

Meeting: 2023-07-24 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY 395 patches.
• Carlos's SLI at 161.11414392059552 days average patch age in queue and 64929 accumulated patch days.
• Discussed with Andreas and Adhemerval the situation with of UNSUPPORTED tests and runing under systemd-nspawn vs. running baremetal. Carlos has AI to update release notes to talk about testing under bare metal. Andreas has AI to post set of tests which failed in system-nspawn testing.
• Discussed clone3 support for multiple architectures. Still missing 32-bit Arm and MIPs versions.
• Andreas: Ran the gnulib testsuite. Builds about 10 more objects. About half of them are expected. The rest we still need to look at. The LTP testsuite hasn't been run yet. Carlos has the AI to run LTP on baremetal x86_64.
• [v2] localedata: Translit common emojis to smileys [BZ #30649] (Colin)
  • Carlos: Marked v1 it superseded. No objection to the idea of adding more translit.
• Maxim: Linaro will try to work to get glibc buildable with clang. Is it a benefit to have a second supported compiler?
  • Siddhesh: Yes. For the first release we can mark clang as desirable but not blockers.
  • Maxim: Secondary target as a first release until the community is comfortable.
  • Andreas: If there is a flip and a toggle, someone will use it. Right now for llvm builds people must use gcc for glibc.
  • Adhemerval: I'm the stakeholder for this so I don't have much to say.
  • Carlos: Recommend 2 releases where it is not a blocker. First release focus on making sure gcc and clang ABIs match.
  • Adhemerval: We have shared code with gcc. Tried to push a patch to enable clang support in gcc. Tried to push on the glibc side and Joseph was adament that it should be done in gcc. Blocker was longlong.h.

Meeting: 2023-07-17 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2023-07-03 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 358 patches.
• Carlos's SLI at 166 days average patch age in queue and 61244 accumulated patch days.
• Reviewing release blockers:

  • https://sourceware.org/glibc/wiki/Release/2.38

• On list review of patches:
  • 72008: [v4] [v4] libio: Add nonnull attribute for most FILE * arguments in stdio.h (Xi)
    • Still needs review. Andreas Schwab reviewed v3.
  • [v3] elf: Fix slow tls access after dlopen [BZ #19924] (Szabolcs)
    • RM asked for after the release commit.
• Flip defaults for some security-relevant build configuration flags (Siddhesh)
  • Not a critical fix, desirable for this release.
  • Downstreams could flip the default back if they wanted.
  • RM gave OK.
  • Florian: There was some objection to this change.
  • We believe Joseph Myers wanted a cross toolchain change?
  • Siddhesh: No objection from Joseph as he reviewed the changes.
• Add clone3 support for multiple architectures (Adhemerval)
  • Needs review.
  • Carlos to review the clone3 changes for the arches.
• Restore support for _r_debug copy relocations, interposition (Florian)
  • The workload that is broken is dyninst.
  • And debugging dlmopen but we haven't really validated it.
  • Review and put it into glibc 2.39.
• Add strlcpy/wcslcpy testcase (Sunil) - Useful, could go in.
• Add strlcat/wcslcat testcase. (Sunil) - Likewise.
• x86_64: Implement AVX2 version of strlcpy/wcslcpy function (Sunil)
  • Sunil: What does the community think here? Should it be accepted?
• Adhemerval: Should we promote and optimize these interfaces?
• RISC-V: ifunced memcpy using new kernel hwprobe interface (Green)
  • Florian: You can't make function calls in the IFUNC resolver.
  • Palmer: We would want to cache it.
• scripts: Add fortify checks on installed headers (Adhemerval)
  • Carlos to review.

Meeting: 2023-07-03 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2023-06-26 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 347 patches (+37 from last week)
• Carlos's SLI at 159 days average patch age in queue and 57727 accumulated patch days.
• Starting at 71674. Previous stop 71119
• [1/5] htl: Let Mach place thread stacks (Sergey)
  • Hurd maintainer needs to review.
• [2/2] linux: statvfs: allocate spare for f_type (Ahelenia)
  • Szabolcs: Statvfs doesn't expose the type and it should be exported.
  • How can the field be known to be set?
  • Needs a new version to make sure new code can use it.
• [v2] mips: dl-machine-reject-phdr: Get rid of alloca. (Joe)
  • Changes requested.
• setenv.c: Get rid of alloca. (Joe)
  • Fails pre-commit CI.
• [v3,1/4] aarch64: Add vector implementations of cos routines (Ramsey)
  • Szabolcs sheparding these patches.
• Allow glibc to be built with _FORTIFY_SOURCE (Fred)
  • Siddhesh marked failed pre-commit CI. Fails on aarch64.
• [v2] ld.so: Always use MAP_COPY to map the first segment [BZ #30452] (HJ)
  • Needs review.
• elf: Update list of RISC-V relocations (Andreas)
  • Palmer: Will check against binutils and review.
• Untitled series #21649 (Christian Rodriguez)
  • Needs some review.
  • Siddhesh: Was tracking the linux kernel changes.
  • Some changes are OK, some are not (public headers)
• [v6] ifaddrs: Get rid of alloca (Joe)
  • Needs review.
• [2/2] time: Implement extra timebase defines for timespec_get and timespec_getres (Luo) (71504)
  • Fails pre-commit CI but only on linaro-tcwg
• [v3,1/4] clang-format: Do not usage tab to indent code (Luo)
  • Needs review for clang-format update.
• Stopped at 71467.
• Adhemerval: Asking for clone3 and posix_spawn that will return an fd.
  • Might work towards this using pidfd fork and spawn.

  • https://sourceware.org/bugzilla/show_bug.cgi?id=26371

  • What kind of API should we create to support this?
• Re: [PATCH v7] nptl: Fix Race conditions in pthread cancellation [BZ#12683]
  • Carlos to review.

Meeting: 2023-06-19 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY 310 (+3 from last week)
• Carlos's SLI at 172 (+4) days average patch age in queue and 55812 accumulated patch days.
• Starting at 71283. Previous stop at 70716.
• Noted that Red Hat Platform Tools pre-commit CI bot is down. Running only with Linaro TCWG bot.
• Rejected some series as Failed CI.
• Discussed that some of hte problems we face would get fixed by MR/PR based workflows e.g. post-commit changes would not happen, and patch versions tracking would not be needed, etc.
• Discussed how to make the patch application reliable with respect to the applied patch. Would need to use the 'base-commit' to apply patches? No. This is problematic for testers that track failure baselines as this base-commit might not have a recorded failure baseline. The easiest solution is to mark "failed to apply" patches as having no failures e.g. indeterminate state.
• [v8,1/3] posix: regcomp(): clear RE_DOT_NOT_NULL (Ahelena)
  • Still needs review.
• [v15] POSIX locale covers every byte [BZ# 29511] (Ahelena)
  • Still needs review.
• PowerPC: Influence hwcaps via cpu arch-level GLIBC_TUNABLES. (Mahesh)
  • Should get review from power maintainers.
• [v3,1/2] elf: Port ldconfig away from stack-allocated paths
  • Adhemerval: Will review last patch.

• manual: Enhance documentation of the <ctype.h> functions (Florian)

  • Carlos: Review decision to accept extensions.
• [v2] fileops: Don't process , ccs= as individual mode flags (BZ#18906) (Joe)
  • manual: Update documentation of strerror and related functions (Florian)
    • Carlos: Review the issue with the memory going away.
• Fix tests-clean Makefile target (bug 30545) (Maxim)
  • Carlos: To review.
• add GB18030-2022 charmap [BZ #30243] (liqingqing)
  • Carlos: Asking Mike Fabian to review as upstream expert on the Unicode data and these updates.
• Stopped at 71119.
• [v5] Add pidfd_spawn, pidfd_spawnp, pidfd_fork, and pidfd_getpid (Adhemerval)
  • Review requested.
• Discussed auto-closer and missing patches:

  • https://sourceware.org/pipermail/libc-alpha/2023-June/148843.html

• [1/4] aarch64: Add vector implementations of cos routines (Ramsey)
  • Szabolcs: New version coming. Will review.

• Format test results closer to what DejaGnu does (Maxim) 70442

  • Request for Florian to review question.

Meeting: 2023-06-12 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 307 patches.
• Carlos' SLI at 168 days average patch in queue and 53830 patch days.
• Starting at 70879. Previous stop at 70469.
• [v14] POSIX locale covers every byte [BZ# 29511] (Ahelenia)
  • Still need review against standard text and desired glibc behaviour.
• [v7,1/3] posix: regcomp(): clear RE_DOT_NOT_NULL (Ahelenia)
  • Carlos to respond about assignment issue.
• [1/2] posix: Handle success in gai_strerror() (Dridi)
  • Ask Arjun to review.
• C2x printf %wN, %wfN support (bug 24466) (Joseph)
  • Adhemerval: I'll review.
• [v2] tst-getdate: Improve testcase flexibility and add test. (Joe)
  • Adhemerval: Use-after-free was always present as Andreas noted. We now just triggered it more easily. The test should cover thi.
  • Adhemerval: Will review.

• RISC-V: Stop referencing global_pointer$ under PIC (Palmer)

  • Machine maintainer can commit.
• [v3] grantpt: Get rid of alloca (Joe)
• hurd: writev: Get rid of alloca (Joe)
• [1/4] aarch64: Add vector implementations of cos routines (Ramsey)
  • Leave in the queue for the community to comment.
  • Adhemerval: Avoid changing the code and make it easier to sync with original sources.
  • Szabolcs: We publish the exact same code in arm-optimized routines. Fixes should live in the glibc repo. glibc is the main source of this code.
• [v1,1/2] x86: Implement sched_yield syscall for x86 only. (Noah)
  • Changes requested after community review.
• [v2] grantpt: Get rid of alloca (Joe)

• [v11,1/3] x86: Increase non_temporal_threshold to roughly sizeof_L3 / 4 (Noah)

  • Carlos: Reviewed this last week with STREAMS data form DJ. Can be pushed.
• stdlib: Perform NULL pointer check for the getenv argument (Dennis)
  • Carlos will respond about the standard requirement.
  • Adhemerval: Header already marked non-NULL.
• malloc: Decrease resource usage for malloc tests (Adhemerval)
  • Carlos: Will review.
• nss_files: Tune down tst-nss-files-hosts-getent resource usage (Adhemerval)
• [v2] elf: _dl_find_object may return 1 during early startup (bug 30515) (Florian)
  • Already reviewed.
• Stopped at 70716.
• [v5] MIPS: Sync elf.h from binutils (Ying)
  • Maxim: This fails in the Linaro CI.

• Format test results closer to what DejaGnu does (Maxim)

  • Florian needs to review Maxim's response.

Meeting: 2023-06-05 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 288 patches.
• Carlos' SLI at 173 days average patch in queue and 51981 patch days.
• Starting at 70592
• Always do locking when accessing streams (bug 15142, bug 14697) (Andreas)
  • Adhemerval: Andreas has been trying to fix this since 2017.
  • Carlos: Do we need a new test?
  • Florian: tst-stdio1 should be adjusted for new behaviour.
  • Florian: I'll review this and the test issue.
• O_IGNORE_CTTY everywhere (Sergey)
  • Florian reviewing the generic changes.
• hurd: Exclude more headers when generating errno.h (Sergey)
  • Hurd maintainer to review.
• time: Also check for EPERM while trying to clock_settime (Adhemerval)
  • Carlos: Reviewed and accepted.
• [v6] Fix warn unused result (Frederic)
  • Siddhesh to review.
• linux: Fail as unsupported if personality call is filtered (Adhemerval)
  • 70508: x86: Fix for cache computation on AMD legacy cpus
    • Florian will add more tests.
• [v4] MIPS: Sync elf.h from binutils (Huang)
  • Changes requested by Maciej.
• debug: Actually run tst-longjmp_chk3.c (Nisha)
  • Adhemerval: Will review.
• grantpt: Get rid of alloca (Joe)
  • Florian: I will follow up.
• linux: Split tst-ttyname (Adhemerval)
  • Adhemerval: Mount /proc can work, but it changes the semantics.
  • Carlos: Will review.
• Stop at 70469.

• 70442 Format test results closer to what DejaGnu does (Maxim)

  • Carlos: Will review.
• [RFC] Avoiding dlopen in statically linked applications that use nss [#27959] (Arjun)
  • Arjun: Would like to raise for review.
  • Florian: 3 benefits (a) Reduce build time. (b) Remove link warnings for static applications. (c) Easier to implement solution to remove dlopen in static applications.
• [v3] elf: Fix slow tls access after dlopen [BZ #19924] (Szabolcs)
  • Carlos: I need to finish pthread cond var review and then look at this.

• Restore support for _r_debug copy relocations & interposition (Florian)

  • Still out for review.
• strlcpy and related functions (Florian)
  • Siddhesh: I'll review these.
• Florian: There is a 25-patch series I have for read-only link maps.
  • Adhemerval: Is there a POC for this?
  • Florian: Yes, DT_FINI can be overwritten to get execution control.
• Adhemerval: Review the pidfd new API calls?
  • v5 addresses all comments from Florian.
  • Looking for review and consensus for the APIs.
• stdlib: Tune down fork arc4random tests (Adhemerval)
  • Carlos: I'll review.
• stdlib: Tune down thread arc4random tests (Adhemerval)
  • Carlos: I'll review.

Meeting: 2023-05-29 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 275.
• Carlos' SLI at 176 days average and 50345 total patch days.
• Carlos: I need to switch to doing more patch review, but I'm making progress on pthread cond var lost signal.
• Start review at 70196. Previous start at 69335. 53 patches?
• [v2] fcntl fortification (Sergey)
  • Adhemerla: Plan to reivew.
  • Siddhesh: Likewise.
• Fix misspellings in elf/ -- BZ 25337 (Paul)
  • Carlos: Will review ASAP. Consensus is Paul can commit.

• [v10,1/3] x86: Increase non_temporal_threshold to roughly sizeof_L3 / 4 (Noah)

  • DJ reviewed v9, should review v10.
  • Carlos has to reivew downstream STREAMS benchmark data.
• [v2] ifaddrs: Get rid of alloca (Joe)
  • Adhemerval: Reviewed last one, Will review this one.
• [v2] io: Fix record locking contants on 32 bit arch with 64 bit default time_t (BZ#30477) (Adhemerval)
  • Carlos: I'll review this.
  • Adhemerval: Reviewed the existing code to see if there any other cases of this (requested by Florian).

  • https://sourceware.org/pipermail/libc-alpha/2023-May/148502.html

• posix: Add error message for EAI_OVERFLOW (Dridi)

  • https://pubs.opengroup.org/onlinepubs/9699919799/functions/gai_strerror.html

  • Should have strings for all error messages. Is this the only missing one?
  • Asked Arjun for review.

• LoongArch: Fix inconsistency in SHMLBA macro values between glibc and kernel (Caiyin Yu)

  • Needs review. Not easy to make a test for this (Florian's suggestion)
• [v7] nptl: Fix Race conditions in pthread cancellation [BZ#12683] (Adhemerval)
  • Adhemerval: Moved to a single file.
  • Carlos: Will review today.
• [v5] Add pidfd_spawn, pidfd_spawnp, pidfd_fork, and pidfd_getpid (Adhemerval)
  • Needs review.
• posix: fix fnmatch() inconsistency BZ#30483 (Carlo Arenas)
  • Adhemerval: Please add test case? Changes requested.
• Stopped at 69810.
• Add clone3 support for multiple architectures (Adhemerval)
  • Needs arch review.
  • Palmer will try to look at RISC-V rv64 clone3 internal impl.
• Restarting at 69810
• [v3] vfprintf-internal: Get rid of alloca. (Joe)
• [v2] elf: Make more functions available for binding during dlclose (bug 30425) (Florian)
  • Carlos: Changes requested. Will follow up with Florian.
• [v2] libio: Add nonnull attribute for most FILE * arguments in stdio.h (Xi)
  • Carlos: Needs DCO or assignment.
• Stopped at 69621.

Meeting: 2023-05-22 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2023-05-15 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 277 patches.
• Carlos' SLI at ~154 days average and 48253 total patch days.
• Starting at 69335.
• x86_64-gnu signal fixes (Sergey)
  • Hurd maintainers to review.

• [v9,1/3] x86: Increase non_temporal_threshold to roughly sizeof_L3 / 4 (Noah)

  • Carlos and DJ will review the patches.
• Patch to fix glibc condition variable bug (BZ 25847) (Malte)
  • Carlos is writing open-box tests for this and reviewing.
• [v2] S390: Use compile-only instead of also link-tests in configure. (Stefan)
  • Accepted by Andreas.

• powerpc:GCC(<10) doesn't allow -mlong-double-64 after -mabi=ieeelongdouble (Mahesh)

  • Florain to post a response.
• MIPS: Sync elf.h from binutils (Ying)
  • Andreas requested changes.
• time: strftime_l: Use malloc rather than an unbounded alloca. (Joe)
  • Needs review of the malloc size computation.
• setsourcefilter: Use malloc() rather than alloca(). (Joe)
  • Needs review of the malloc size computation.
• [v2,1/2] elf: Fix marking root dir as nonexist in open_path (bug 30435) (Qixing)
  • Carlos to review.
• [v1] x86: Use 64MB as nt-store threshold if no cacheinfo [BZ #30429] (Noah)
  • Florian to follow up with a comment.

• [v4] Restore support for _r_debug copy relocations & interposition (Florian)

  • Needs review from someone with ld.so experience.
• Remove last remnants of have-protected (Andreas)
  • Carlos to review.
• [v4,1/3] posix: add (failing) test for REG_STARTEND (Ahelenia)
  • Still needs review of test case and gnulib sync status.
• [v12] POSIX locale covers every byte [BZ# 29511] (Ahelenia)
  • Still with Florian for review.
• [v6] x86_64: aarch64: Set call number just before syscall (Joe)
  • Joe should ping HJ for review of the x86_64 changes.
  • Split this into 3 patches so we can make forward progress.

  • Adhemerval to ask Joe to update "NewPorts" wiki page with QoI requirement.

• Stopped at 68153.
• Florian asked Palmer if there was a reproducer for the case of dlopen'ing executables
  • Palmer: If gp was used by a shared object, then that is likely a bug in ld.
  • Palmer: Reusing gp for other purposes is a violation of the psabi.
  • More details on what they are doing would help, including a reproducer.
• Adhemerval: Florian only reviewed the last of the functions for pid fd.
  • Florian will try to look at this during the week.
• Carlos: Where did we land with the huge pages on stack allocation?
  • Adhemerval: Installed Cupertino's patch to add the tunable.
  • Posted new patch to try detect the bad performance case and fix it.

Meeting: 2023-05-08 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Carlos' SLI at 157 days average and 47870 total patch days.
• State NEW delegate NOBODY at 279 patches (+2)
• Starting at 68902
• Marked 2 "POSIX locale covers every byte" as superseded.
• Marked several "REG_STARTEND" patches as superseded.
• Revert pushed for RISC-V changes.
• [v3] "elf.h: Fix and cleanup the RISC-V defines" (Palmer)
  • Rebase on the revert.
  • Florian: Push first patch.
  • Marked superseded.
• [v4,1/3] posix: add (failing) test for REG_STARTEND (Ahelenia)
  • Needs review of the test cases and fix.
  • Care needs to be taken with gnulibc sync state.
• [v12] POSIX locale covers every byte [BZ# 29511] (Ahelenia)
  • Florian to review.
• [v2] testsuite: stdlib/isomac.c: fix REQUIREMENTS (Ahelenia)
  • Carlos to review.
• [v3] riscv: Vectorized mem*/str* function (Hau)
  • Palmer to review.
• Patch to fix glibc condition variable bug (BZ 25847) (Malte)
  • Under review by Carlos.
• elf: fix handling of negative numbers in dl-printf (Roy)
  • Needs a test case written. Maybe add a test case wrapper the user can use.
• [v5] aligned_alloc: conform to C17 (DJ)
  • Carlos to review.
• At 68462
• Standardize the sorting of Makefile variables (Carlos)
  • Carlos to follow up noting that it doesn't change code generation.
• [v2] time: Remove alloca() from getdate (Joe)
  • Superseded
• [v6] x86_64: aarch64: Set call number just before syscall (Joe)
  • Under review. Joe should ping HJ and Szabolcs to review.
• Florian raised request to review _r_debug changes.
  • Carlos noted they need to be rebased. Florian will rebase.
• At 68093.

• libio: Add nonnull for FILE * arguments of fclose and freopen (Xi)

  • Carlos to push.
• nptl: Disable THP on thread stack if it incurs in large RSS usage (Adhemerval)
  • Wilco: Changes requested.
• Add pidfd_spawn, pidfd_spawnp, pidfd_fork, and pidfd_getpid (Adhemerval)
  • Needs review before July 1st (2 months left)
• [v2] strlcpy and related functions (Florian)
  • Corner case in the impl with Austin Group. POSIX language needs adjusting.
  • If there is no null bytes then behaviour is undefined.
  • Siddhesh to look at v2.
• Added Redirects to longdouble error functions [BZ #29033] (Sachin)
  • Changes requested by Raji for minimum compiler check.
• Fix warn unused result (Frederic)
  • Superseded by newer series.
• Stopped at 67962.

Meeting: 2023-05-01 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 277 patches.
• Carlos' SLI at 159 days.
• Start review 68553
• [v2] elf.h: Drop duplicate STO_RISCV_VARIANT_CC, and reorder DT_RISCV_* (Palmer)
  • Talked to Palmer, marked this superseded and Palmer will send a cleanup set of patches.

• [3/3] Mark various cold functions as COLD (Sergey)

  • Siddhesh to look at reviewing the header change.
• riscv: Add glibc-hwcaps support (Evan Green)
  • Discussed with Palmer and marked RFC since this is very early.
  • An industry discussion is still required to define possible glibc-hwcap groups.
• Revert "riscv: Resolve symbols directly for symbols with STO_RISCV_VARIANT_CC." (Palmer)
  • Carlos noted that you can revert right away if you want.
  • Marked as RFC since this is only to be applied as soon as someone says they want a revert.
  • Palmer working on the correct fix ASAP.
• [v11] POSIX locale covers every byte [BZ# 29511] (Ahelenia Ziemiańska)
  • v9 reviewed by Florian. Need to follow up on changes.
• [v3,1/3] posix: add (failing) test for REG_STARTEND (Ahelenia Ziemiańska)
  • Needs review.
• Fix warn unused result (Frederic Berat)
  • Siddhesh will review these.
• Standardize the sorting of Makefile variables (Carlos O'Donell)
  • Feedback from Fred that editing glibc Makefile was hard.
• elf: Add the soname to the libname_list eagerly on loading a library
• Use GCC 13 branch, Linux 6.3 in build-many-glibcs.py
  • Carlos reviewed on call.
• [v2] time: Remove alloca() from getdate
  • v1 marked superseded.
  • Siddhesh to review v2.

• [v4] x86: Increase non_temporal_threshold to roughly sizeof_L3 / 2 (Noah)

  • Carlos to review.
• [v6] x86_64: aarch64: Set call number just before syscall (Joe Simmons-Talbott)
  • Leaving for machine maintainer review. At v6 and under active review.
• Stopped at 68208.
• Discussed the status of RISC-V patches and atomics vs. mutexes in libstdc++

Meeting: 2023-04-24 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Carlos' SLI at 161 days.
• State NEW delegate NOBODY at 263 patches.
• Carlos raised an issue that he's seeing with testing.
  • Seeing random failures in threaded malloc tests.
  • tst-malloc-thread-fail-malloc-hugetlb2.out
    • error: exit status 139 from child process
  • Noah has not indicated anything failing.
• Starting at 68208
• Szabolcs noted that they are still planning to commit libmvec, just waiting on upgrading certain systems to GCC10.
• Carlos and Szabolcs talked about CI/CD for aarch64.
  • Carlos will write up a setup for a 64-bit builder tied to CI/CD and all the steps.

• [v1] x86: Increase non_temporal_threshold to roughly sizeof_L3 / 2

  • Discussed the details of the results.
  • Discussed looking at the STREAMS result.
• Stopped at 68204.

Meeting: 2023-04-17 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY 234 patches.
• Carlos Patch review SLI at 173 days.
• Last Monday was Easter Monday, and Carlos didn't run the meeting.
• Only those logins with admin access to the "glibc" meeting can start the meeting.
• Need to ask again if anyone who attends needs that access.
• Started at 67810.
• [v6] Added Redirects to longdouble error functions [BZ #29033] (Sachin)
  • Paul reviewed last time.
• Add voice-admit DSCP code point from RFC-5865 (Ronan Pigott)
  • Florian to have a look.
• hurd: Run init_pids () before init_dtable () (Sergey)

• LoongArch: Multiarch string and memory copy routines for unaligned access (Xi)

  • Needs review from LoongArch maintainer.

  • Discussed briefly that this code should be generic. That generic routines should support unaligned access.
  • Adhemerval to discuss with Xi.
• [1/5] hurd: Fix restoring reply port in sigreturn (Sergey)
• [v6,1/1] Created tunable to force small pages on stack allocation. (Cupertino)
  • Adhemerval: Created a NEWS entry.
  • Still discussing heuristic to detect the degradation.
• math: Improve fmod(f) performance (Wilco)
  • Adhemerval: Looking for v7 with a few changes.
• [v6,1/1] memalign: Support scanning for aligned chunks. (DJ)
  • Carlos: This looks like a v4 of the other patch.
• [v3] malloc: set NON_MAIN_ARENA flag for reclaimed memalign chunk (BZ #30101) (DJ)
  • Carlos: Older patch. Need to check if this is superseded.
• [v2,1/2] x86_64: Set the syscall register right before doing the syscall. (Joe)
• [v2,2/2] aarch64: Set the syscall register right before doing the syscall. (Joe)
  • v1 reviewed by Florian.
  • Needs x86_64 arch maintainer review and aarch64 maintainer review.
  • Carlos: Needs a large commit message about why this is useful and a comment.
• [v5,2/2] Enable libmvec support for AArch64 (Joe Ramsey)
  • Szabolcs: Will commit this shortly.
• Carlos discussed Florian's re-flow of Makefiles.
  • Adhemerval noted something was missing a line.

• https://sourceware.org/bugzilla/show_bug.cgi?id=30349

  • Adhemerval: Extend pidfd for posix_spawn()?
  • Florian: Consider a language where a binding generator wraps the API.
  • Carlos: A new API does add the type information.
  • Noted to track the existing API e.g. pidfd_fork and pidfd_spawn

Meeting: 2023-04-10 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

Cancelled due to Spring holidays (Easter Monday).

Conferencing instance is open if one of the developers with a login wants to hold a meeting.

Meeting: 2023-04-03 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 248 patches.
• Carlos' SLI at 156 days.

• https://sourceware.org/bugzilla/show_bug.cgi?id=30301 (memalign improvement introduced regressions)

  • Discussed what we need to do to fix the issue.
• Adhemerval: Raised the issue of submitted bugs for the upcoming release?
  • Required? Desired? Useful? Filtered?
  • Carlos: Unless someone asks for a shortened NEWS list, I'd leave these there as an artifacts of showing development in progress.
  • Florian: Notes that Version field in bugzilla includes 2 upcoming versions so that bugs in devel can be tracked correctly for pre-release based on date.
• Started at 67211

• LoongArch: Ensure consistency with kernel by using union for struct members in mcontext_t and ucontext_t. (Caiyin Yu)

  • Noted that these changes seem odd given that any implementation can pick names as required.
• [v2,18.2/34] hurd: Port trampoline.c to x86_64 (Sergey)
• [v2,18.1/34] hurd: Do not declare local variables volatile (Sergey)
• [v2] hurd: Implement sigreturn for x86_64 (Sergey)
• x86/dl-cacheinfo: remove unsused parameter from handle_amd (Andreas)
  • Needs review from anyone. Fairly generic cleanup.
• implement dlmem() function (stsp)
  • Carlos to comment again about dlmem().
• build-many-glibcs.py: --disable-gcov for gcc-first (Jan-Benedict Glaw)
  • Discussed briefly to disable gcov.
  • Carlos: I'll look at this briefly to commit.

• https://sourceware.org/bugzilla/show_bug.cgi?id=30293

  • Needs review in light of the glibc implementaiton.
• [v2] Add tests for strdup and strndup (BZ #30266) (Joe)
  • Adhemerval reviewing test additions.
• [v5,1/1] Created tunable to force small pages on stack allocation. (Cupertino)
  • Adhemerval to review.
  • Carlos: This seems like we should be doing this by default?
  • Florian: Guard page size could be 2MiB
  • Carlos: Split the tcb from stack?
  • Florian: Note that the reported RSS increase is not technically real because it's untouched thread stack.
  • Adding a tunable is a good first step.
• [v3] elf: Fix slow tls access after dlopen [BZ #19924] (Szabolcs)
  • Still needs review. Important for the release.

• [v2] manual: Document wur usage under _FORTIFY_SOURCE (Siddhesh)

  • Florian to review.
• Add clone3 support for multiple architectures (Adhemerval)
  • Carlos to review.
• Stopped at 66592.

Meeting: 2023-03-27 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 257 patches.
• Carlos' SLI at 146.
• Started at 66952.
• [v2] dlopen: skip debugger notification for DSO loaded from sprof (bug 30258)
  • Florian reviewed v1, will leave this for Florian to review.
• [v4,v4] Added Redirects to longdouble error functions [BZ #29033] (Sachin)
  • Needs a v5, needs testing on other arches (as noted by Adhemerval)
• [PATCH 0/3] Fix tst-ldconfig-ld_so_conf-update and tst-glibc-hwcaps-prepend-cache with custom configure prefix value (Romain)
  • Adhemerval needs review.
• [v2] Take into account ${sysconfdir} in elf/tst-ldconfig-p.sh. (Romain)
  • Need to review if this supercedes the other 3 set patch.

• LoongArch: ldconfig: Ignore EF_LARCH_OBJABI_V1 in shared objects (Xi Ruoyao)

  • Valid thing to have should be removed. Yinyu Cai to review as arch maintainer.
• Minor: don't call _dl_debug_update (which can have side effects) inside assert (Paul P.)
  • Reviewed. Needs v2.
• linux: Avoid va_list for generic syscall wrappers if possible (Xi Ryoyao)
  • Carlos to review and provide comments about compiler optimzations.

• [v2] manual: Document wur usage under _FORTIFY_SOURCE (Siddhesh)

  • Carlos to review.
• [1/2] benchtests: Move libmvec benchtest inputs to benchtests directory
  • Carlos: This is a straight forward RB for me, it's easy and makes sense.
• [2/2] Enable libmvec support for AArch64 (Joe Ramsey)
  • This needs review.
• [v3] malloc: Use C11 atomics on memusage (Adhemerval)
  • Carlos: Default C11? Yes. OK. Needs review.

• LoongArch: Add Syscall Assembly Implementation (Caiyin Yu)

  • Adhemerval: This may be needed, because other arches do this.
• Stopped at 66800
• Discussed sysdeps/elf/Makefile cleanups and automating sorting of lines.

Meeting: 2023-03-20 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 285 patches.
• Carlos' SLI at 128 days.
• Starting review at 66620.
• Marked the 64-bit GNU Hurd port ad RFC.
• implement dlmem() function (stsp)
  • Carlos to review given previous comments.
• posix: Fix some null deferences in wordexp [BZ #18096]
  • Andreas requested changes.
• htl: move some symbol into libc (Guy-Fleury Iteriteka)
• [v2] aligned_alloc: conform to C17 (DJ)
  • Carlos can review. However, v3 required, no new symbol should be exported.
• Improve fmod and fmodf (Adhemerval)
  • v3 needs udpated tests.
• C2x strtol binary constant handling: Fix special case "0b" (Bruno)
  • Early testing. Needs test case.
• getlogin_r: fix missing fallback if loginid is unset (bug 30235)
  • Needs more review than just the name.
• [v2] x86: Set FSGSBASE to active if enabled by kernel
  • Florian to review today.
• Stop at 66328.
• Cupertino raised the "Created tunable to force small pages on stack allocation." patch.
  • Repost v2.
• Remove --with-default-link option (Adhemerval)
  • Carlos to review last 2 patches.
• Patch to fix glibc condition variable bug (BZ 25847)
  • Discussed status of review. No blockers, still reviewing results.

Meeting: 2023-03-13 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2023-03-06 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY is at 214 patches.
• Carlos' SLI at 161 days.

• Discussed "[v3,2/4] libio: Remove the usage of libc_IO_vtables"

  • Decision is to rely on existing regression test suite.
  • Concerned with static link issues that don't bring in everything.
  • v4 needed to fix the typo in "_IO_file_jumps_alia"
  • What about "pragma weak" for _IO_default_* functions?
  • libio_static_fn_required (defined at libio/libioP.h)
  • Carlos: What pulls in libio/genops.c? Pulled in by _IO_un_link?
    • Florian's suggestion is to remove pragma weak for _IO_default.
• Why does LD_PRELOAD not work with RTLD_DEEPBIND?
  • Already had a WONTFIX bug for that.

  • https://sourceware.org/bugzilla/show_bug.cgi?id=25533

  • https://sourceware.org/bugzilla/show_bug.cgi?id=30186

• Carlos raised the issue of Message-ID's with slashes in them.
  • Siddhesh: Yes we do have the fix in patchwork, but it looks incomplete.

  • https://github.com/getpatchwork/patchwork/issues/518

• [v3] elf: Fix slow tls access after dlopen [BZ #19924] (Szabolcs)

  • Needs review for P&C issues.

Meeting: 2023-02-27 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 217 patches.
• Carlos' SLI at 151 days.
• Starting at 65684 patch number.
• crypt: Remove invalid end of page test badsalttest (Adhemerval)
  • Do not support non-NULL termianted strings.

• LoongArch: Further refine the condition to enable static PIE (Xi)

  • Review required from LoongArch maintainer (Yinyu Cai)

• minimal run-time audit support (Stas Sergeev)
  • 2 patches for this.
  • Needs high-level interface review.
  • Carlos to look at use case driving the requirements.
• Add Arm HWCAP values from Linux 6.2 to bits/hwcap.h (Joseph Myers)
• Add AArch64 HWCAP2 values from Linux 6.2 to bits/hwcap.h (Joseph Myers)
  • Needs review from anyone to confirm Linux 6.2 matches.
• Declare wcstofN, wcstofNx for C2x (Joseph Myers)
  • Needs review against DIS for ISO C2x.
  • Adhemerval to look at this and the next.
• pdate printf %b/%B C2x support (Joseph Meyrs)
  • Needs review against DIS for ISO C2x.
• posix: Fix system blocks SIGCHLD erroneously [BZ #30163] (Adam Yi)
  • Reviewed by Adhemerval. Changes requested.
• x86_64: Update libm test ulps (HJ Lu)
  • Paul Zimmermann had already submitted this as 64996.
  • Carlos to make sure this gets pushed.
• [v3] i386: Use pthread_barrier for synchronization on tst-bz21269 (Adhemerval)
  • DJ to review.
• manual: scripts/documented.sh updated (Girish Joshi)
  • Florian to review the patch.
• Update kernel version to 6.2 in header constant tests (Joseph Myers)
  • Carlos to review.
• [v2] manual: Add note to process.texi about MT-process fork (Bug 30159) (Carlos O'Donell)
  • Florian to review the patch.
  • Noted that fork() is not AS-safe, and _Fork() is now present.
  • Agreed that overall we likely go in the direction that malloc() and other functions will be allowed after MT-fork in the child.
• tunables.texi: Change \code{1} to @code{1} (HJ Lu)
  • DJ reviewed.
• Provide a SECURITY.md for glibc. (Carlos O'Donell)
  • Needs review.
• Stopped at 65459.
• Adhemerval: Review "Remove --with-default-link"

  • https://patchwork.sourceware.org/project/glibc/list/?series=15551

  • Carlos to review.
• gshadow: Matching sgetsgent, sgetsgent_r ERANGE handling (bug 30151) (Florian Weimer)
  • Carlos to review.
• [v3] elf: Fix slow tls access after dlopen [BZ #19924] (Szabolcs Nagy)
  • Paul Zimmerman would like this reviewed.

  • https://github.com/sagemath/sage/issues/34850

  • Carlos notes that this was raised 2023-01-09 and left out of 2.37.
    • Should be reviewed for 2.38 early so we can test this downstream.
• Pavel: Started testing the clone3 wrapper patches and saw misaligned stack.
  • Decided to add clone3 wrapper for Arc.
  • Pavel: Do we need to align stack for this wrapper?
  • Florian: We should not modify the address on the stack.
  • Adhemerval: Since clone3 is only used internally we call it with an aligned stack with all internal uses.
  • Pavel: tst-misalign-clone will always use clone3
  • Adhemerval: Yes, you must align the stack.

Meeting: 2023-02-20 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 222
• Carlos' SLI at 163 days.
• Starting at 65235
• Started discussing Arjun's failures on s390x.
  • Florian: Fedora builds against the z13 baseline.
  • Related commit: 22999b2f0fb62eed1af4095d062bd1272d6afeb1
  • Related commit: 7ea510127e2067efa07865158ac92c330c379950
  • Adhemerval: s390x build tests:
    • -march=z900, -march=z10, -march=z196, default
    • Review the earlier commits for impact on z13
    • Review build-many-glibcs configuration with -march= baselines for testing.
• Adhemerval noted that Gentoo was discussing stable backport policy.
  • The open question is about hardware performance backports.
• 65235: Added Redirects to longdouble error functions [BZ #29033]
  • Impacts ppc64le ieee754 long double. IBM to review?
• build: All microbenchmarks should output in JSON. (bug 27740)
  • Ask Siddhesh to review.

• Remap GLIBC_FLT_EVAL_METHOD to 0 if FLT_EVAL_METHOD is -1

  • Needs senior review for generic code. Will come back to this next week.
• [v2] C2x scanf binary constant handling (Joseph)
  • Adhemerval to review.
• implement dlmem() with audit extensions (Stas Sergeev)
  • Adhemerval: dlmem() needs some very specific requirements and memory cannot follow what dlopen will do regarding mmap flags.
  • Carlos: What is our use case here? Why?
  • Florian: Use memfd? Security review will eventually block fds since it can be used to inject created code.
  • Needs senior reviewer to discuss use cases.
  • Carlos will review the use case on list.
• i386: Use pthread_barrier for synchronization on tst-bz21269 (Adhemerval)
  • Carlos to ask DJ to review for CI/CD impact.
• Szabolcs: What about libmvec review?
  • Raising the minimum requirement to gcc 10. Distro gcc?
  • Florian: It is possible to build libmvec only if gcc is 10 or newer?
  • Historically libmvec has different versions and we had an Intel, AMD, and GNU ABI.
  • Some projects also implement what libmvec does in a single DSO to override.
  • Carlos: For rpm-based distros you could backport libmvec.so.
  • Florian: For libcrypt we define the function in the header and not always include it.
  • Adhemerval: Do we define the prototype?
  • Carlos: Yes, gcc has to know, and you add the pragma.
  • Szabolcs: No header magic yet. Explicit decls. Manually call the symbols.
  • Carlos: The risk is not at the distro level, because glibc 2.38 using distros will use newer gcc, so raising the baseline is less risk. The risk is in the glibc/gcc developer workflow impact.
  • Szabolcs: Making the libmvec.so non-optional seems safer.

Meeting: 2023-02-13 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 243 patches
• Carlos' SLI at 153 days.
• Starting at 64894 (previous stop 63734)
• Remove _STRING_ARCH_unaligned (Adhemerval)
  • Old code removal.
• v3: implement dlmem() function (Stas Sergeev) (64887)
  • Florian looking at the dlmem() interface.
• stdlib: Undo post review change to 16adc58e73f3 [BZ #27749] (Vitaley Buka)
  • Vitaley noted that patch pushed didn't match expected content.
  • Adhemerval will review as the original committer.
• [auto-libm-test-in] added pair of inputs for hypotf in binary32 (Paul Z.)
  • Carlos will review after Wednesday if nobody has reviewed.
• [v2] riscv: Add macros for FPUCW/fcsr in fpu_control.h
  • Changes requested from Richard and Andreas.
• gmon: improve mcount overflow handling [BZ# 27576] (Simon Kissane)
  • Ask DJ to look at this with the other gmon changes.
• [v2] x86-64: Add glibc.cpu.prefer_map_32bit_exec [BZ #28656] (HJ)
  • Carlos to review later in the week.
• [v2] gmon: fix memory corruption issues [BZ# 30101] (Simon Kissane)
  • Slightly different patch.

• [committed] Use builtin_FILE instead of FILE in assert in C++. (Paul)

  • The AdaCore hook configuration should have prevented that.

  • Need to review why this was allowed with the current hooks in place.
• [v2] hppa: Drop old parisc-specific MADV_* constants (Helge Deller)
  • Carlos is a machine maintainer for hppa to review.
• Added Redirects to longdouble error functions [BZ #29033] (Sachin Monga)
  • Needs review for generic code and review from ppc64le machine maintainer.
• [v9] POSIX locale covers every byte [BZ# 29511] (наб)
  • Blocked on Florian at reviewing different implemenations.
  • Action item for Florian to propose a new direction.
• Stopped 64442.
• [v2] stdio: Do not ignore posix_spawn error on popen (BZ #29016) (Adhemerval)
  • Needs review.
• [v2] wchar: Define va_list for POSIX (BZ #30035) (Adhemerval)
  • Needs review.

Meeting: 2023-02-06 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Patchwork query: https://patchwork.sourceware.org/project/glibc/list/?series=&submitter=&state=1&q=&archive=&delegate=Nobody

• NB: It is recommended to turn on patch numbers under preferences after login.
  • State NEW delegate NOBODY at 258 patches
  • Carlos' SLI is at 154 days.
  • Account for grouping in printf width (bug 30068) (Reviewed by Andreas)
  • gmon: Fix allocated buffer overflow (bug 2944) (Delgate to DJ) Should be bug 29444.
  • Add clone3 support for multiple architectures
    • Discussed mips OK, arm OK, riscv OK, ppc64le/ppc64 OK, s390x needs review.
    • Suggested reaching out for review from Stefan/Andreas.
• Starting at 64250.
• Replace rawmemchr (s, '\0') with strchr (Wilco)
  • Reviewed by Adhemerval.
  • AArch64: Improve SVE memcpy and memmove (Wilco)
    • Szabolcs to review.
• Improve generic string routines (Adhemerval)
  • What is left? 3 patches without RB, but sh, hppa and the generic routines are reviewed by Richard.
• 64146: S390: Influence hwcaps/stfle via GLIBC_TUNABLES. (Stefan)
  • Florian reviewed and noted that it should be good.
• [1/2] riscv: sysdeps support for vectorised functions (64073, 64074)
  • Adhemerval notes it needs changes.
• Patch to fix glibc condition variable bug (BZ 25847)
  • Carlos to review "fix 2" for 2.38 and 2.37 backport.
• Fix opendir regression on some FS (Adhemerval)
  • qemu and gentoo users on non-LFS calls on ext4.
  • Either readdir succeeds or it fails.
  • Florian will look at it.
• 63751: x86-64: Restore LD_PREFER_MAP_32BIT_EXEC support [BZ #28656]
  • Florian: We could do this in the kernel?
• Stopping 63734.
• Florian: Post tunables ABI internal stability patch.
  • Depends on awk array iteration.
  • Point release to point release ABI should be stable?
  • Florian's patch only solves the multilib issue if awk randomizes the order.
• Adhemerval: Finish up sysdep removal series.

  • https://patchwork.sourceware.org/project/glibc/list/?series=15052

  • Carlos to review again.
• Adhemerval: Review "Remove --with-default-link"

  • https://patchwork.sourceware.org/project/glibc/list/?series=15551

Meeting: 2023-01-30 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY 259 patches.
• Carlos' SLI is at 163 days.
• Release blockers?
  • Discussed "Account for octal marker in %#o format" as a release blocker.
  • Added to the blocker list.
• The C90 header compatibility fix is not a blocker.
  • Siddhesh posted a patch.
  • "cdefs: Limit definition of fortification macros"
    • Will need backporting to 2.34.
• Discussed Gento Hardened gcc11 which may break larger parts of the glibc testsuite. Reports submitted look much better with gcc12 hardened.
  • Carlos discussed his concern regarding the gentoo results. Looks much better now.
  • Discussed "Make stdlib/testmb compile when _FORTIFY_SOURCE is not predefined 2" as a solution to one of the Gentoo test results issues with the hardened toolchain.
    • Push after 2.38 opens.
• Discussed "Use 64-bit time_t interfaces in strftime and strptime (bug 30053)" as something to fix.
  • Not a blocker, but can be backported (ABI neutral).
  • Should be reviewed for 2.38 and then backported.
• One blocker left for 2.37.
• Discussed backports from 2.38 to 2.37 and what to do about backporting strings with translations.
  • Considered this a difficult problem that would involve fruther thought regarding the cost of backporting translations along with fixes.

Meeting: 2023-01-23 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 246 patches.
• Carlos' SLI at 168 days.
• Discussing glibc 2.37 release status.
• Discussed "Remove --with-default-link option" (Adhemerval)
  • It is a major improvement for building with lld.
  • Improves security when building with lld.
• Moved the "Remove --with-default-link option" to 2.38.
• Marked "x86: Cache computation for AMD architecture" as committed.
• Discussed review for "[v8] POSIX locale covers every byte [BZ# 29511]" and status.
  • Needs more strategic review about glibc direction.
• This week starts machine testing for the release.
  • Gentoo is already starting to test.
  • Carlos to send out the request for machine testing.
• Discussed RISC-V ABI break in the context of 2.37.
  • AArch64 uses the pointer-chain method and it works.
    • Szabolcs: No reported issues here.
• Dicsussed PT_GNU_SFRAME constant in elf.h for 2.37
  • Needs coordination between bintuils, glibc, and gnu-gabi.
• Discussed pthread cond var signal stealing.
  • Can be backported.
• Discussed _r_debug and copy relocations.
  • Can be backported.
• Discussed Math TS18661-2 for inclusion in C2x and impact.
  • No impact to the release, but can impact applications that define iszero().

Meeting: 2023-01-16 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Status NEW delegate NOBODY 247 patches.
• Carlos' SLI at 160 days.
• Two weeks until 2.37 release.
• ABI freeze.
• Remove --with-default-link option
  • Carlos reviewing the changes.
  • Florian to review the vtable hardening bits.
• Status of posix_spawn with clone3?
  • New version sent with comments fixed.

  • https://patchwork.sourceware.org/project/glibc/list/?series=15920

  • Assembly impl removed. Only x86_64 and aarch64.
• Discussed the C2X impl additions.
  • Adhemerval noted that he's reviewed the strtol changes, but it adds a lot of new symbols.
  • Carlos to post to the list and suggest scanf binary constant handling get reviews but committed only once 2.38 opens for development.
  • Adhemerval: Makes sense for next release and both should go in at the same release.
• Discussed aarch64 optimizations from Wilco.
  • Szabolcs: Fairly safe, but could cause performance regressions on cores that we haven't benchmarked.
  • Carlos: I'm OK with those going into 2.37.
  • Carlos will reply on the first patch that it's OK going in now, but we want to avoid further changes to allow machine maintainers to test next week.
• [v1,1/2] nptl: Changes tests to be 1/line and sorted
  • [v1,2/2] nptl: Add a testcase for inputs racey to {w}memcmp{eq} BZ #29863
    • Carlos talked to HJ to review.
    • Noah and Carlos agreed to delay to 2.37.
• Desirable for release: AMD cache patch:

  • https://sourceware.org/pipermail/libc-alpha/2022-December/143989.html

  • Restricted to AMD cpus.
  • Reviewed-by: for Pram.
  • Should be OK to go in this week.
• Carlos still to look at pthread condvar signal stealing for 2.37 this week.

Meeting: 2023-01-09 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

With glibc 2.37 about to release the meeting reviews release blocker patches and desirable for release patches.

• State NEW delegate NOBODY is at 254 patches.
• Carlos' SLI is at 161 days up from 155 before the Holidays.
• Discussed several CI failures, some of them are "patch fails to apply"
  • Raised one with DJ regarding glibc-cicd handling of binary patches from git.
• Starting at 62840
• Reviewing release blockers

  • https://sourceware.org/glibc/wiki/Release/2.37

• Add _FORTIFY_SOURCE impl documentation
  • Still needs review. Florian reviewed v1. v3 should be close to done.
• Fix remaining -Os/-O1 compile issues [BZ #19444]
  • Adhemerval: Not exactly a release blocker but shows issues that not all optimization levels show. Some warnings show only on -O1 and not -O2.
    • Carlos to look at this and the warnings.
• elf: Fix GL(dl_phdr) and GL(dl_phnum) for static builds [BZ #29864]
  • Broke Alpha ABI. Needs fixing before release.
  • Florian would like to review this patch.
• Remove --with-default-link option
  • Florian reviewed previous version.
• Adhemerval: Added to release blockers because without this using a linker different from binutils disables vtable hardening.
• Refactor binutils configure usage
  • Carlos to review given he touched the code.
• Desirable for release:
  • Optimize posix_spawn signal setup with clone3
    • Carlos: I would like to put in the first 4 patches.
  • C2x strtol binary constant handling, C2x scanf binary constant handling (see also notes on relevant AFNOR comment)
• Important for release:
  • pthread condition variable signal stealing
• Szabolcs: [v3] elf: Fix slow tls access after dlopen [BZ #19924]
  • Maybe not OK for the release, but also might need more refactoring to fix the concurrency issue. This is a reasonable approach to fixing the problem.
• Cupertino: [PING,v2] Resolve-flockfile-funlockfile-differences
  • The callback is passed uses the function definition, while the other one expands the macro definition.

Meeting: 2023-01-02 @ 0900h EST5EDT

Meeting cancelled for holidays.

Meeting: 2022-12-26 @ 0900h EST5EDT

Meeting cancelled for holidays.

Meeting: 2022-12-19 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 246 patches.
• Carlos' SLI at 147 days.
• Noah raised a discussion about reviewing the test case for
  • the mem and str routines and if a test case would be valid to accept.
• [PATCH v5] x86: Add a testcase for BZ #29863 (HJ)
  • Raised by Noah.
  • Discussed the test case posted to the list.
  • Requested that this become arch agnositc.
  • Need to verify that it fails in at a reasonable rate with the
    • current number of threads, timing, and test timeout.
  • The goal with the test is to catch gross errors where the mem and
    • str routines write outside of the bounds of the input domain.
  • No guarantees are made regarding the implementation, and if we
    • eventually get an implementation that breaks this test we can reconsider the test.
• Add _FORTIFY_SOURCE implementation documentation [BZ #28998] (Siddhesh)
  • Looking for review that ties the documentation together between gcc and glibc.

  • https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608598.html

• Adhemerval trying to send a fix for the longlong.h header.

  • https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607567.html

  • Segher notes that emulating behaviour is required to claim implementation.
  • Discussed that Joseph Myers as Global Maintainer could review the patch since
    • the change follows Joseph's suggestion for cleaning up compatibility for building with both compilers.
• Started at 62142.
• getdelim: ensure error indicator is set on error (bug 29917) (Andreas Schwab)
  • Needs review.
• Stopped at 62140

Meeting: 2022-12-12 @ 0900h EST5EDT

Video/Audio: https://bbb.linuxfoundation.org/room/adm-alk-1uu-7fu

For this meeting we are going to test the LF BBB instance that is provided via GTI (Toolchain Infrastructure for the GNU Toolchain).

Backup: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Status NEW delegate NOBODY 232 patches.
• Carlos' Patchwork SLI 155 days.
• Started at 61780
• O_TMPFILE and SHM_ANON for the Hurd (Sergey)
  • Needs review from Hurd maintainer

• <signal.h>: Add deprecation message for sigpause (Florian)

  • Also C99 related.
• x86: include OSXSAVE in x86-64-v3 level (Fabian)
  • Under review.
• powerpc64: Increase SIGSTKSZ and MINSIGSTKSZ (Raji)
  • Needs a review for ABI impact.
• Remove Linux generic sysdep (Adhemerval)
  • Carlos to re-review the 5 remaining patches at v2.
• [v2] stdio: Do not ignore posix_spawn error on popen (BZ #29016) (Adhemerval)

• [0/1] libc_start_main() now uses auxv to obtain phdr's address [BZ #29864]

  • New patch needs changes.
• [v1,01/27] x86/fpu: Create helper file for common data macros (Noah)
• Refactor binutils configure usage v2 (Adhemerval)
  • Carlos to review v2.
• aarch64: fix elf_machine_dynamic compile error [BZ #29835] (linzhuorong)
  • Marked dropped and discussed in other thread. Needs newer toolchain.

• <signal.h>: Make bsd_signal available with _GNU_SOURCE (Florian)

• libio: Deprecate the fcloseall function (bug 28099) (Florian)
• Revert "Correctly determine libc.so 'OUTPUT_FORMAT' when cross-compiling."
  • Superseded by binutils configure refactor.
• malloc: Use correct C11 atomics for fastbin
  • Still in the backlog for review.
• Add testcese// [PATCH] dlsym: Add RTLD_PROBE for situation when dlsym only wants to probe a symbol but not use it
  • Rejected until we understand the use case in more detail.
• Stopped at 60927
• Optimize posix_spawn signal setup with clone3 (Adhemerval)
  • Good to review for glibc 2.37 release.
• Discussed Florian's vfprintf series being useful to cleanup vtables
  • Then apply Adhemerval's patches on top because some special cases are removed.
  • Carlos will review Florian's patch.
• BBB review:
  • Carlos still has video issues.
  • Adhemerval, Szabolcs, Arjun, Florian had no video issues.
  • Noted noise cancellation is reduced.

Meeting: 2022-12-05 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Status NEW delegate NOBODY at 275 patches.
• Carlos' SLI at 154 days! Moving up. Need to review patches.
• Starting at 61452
• Moved 41 patches from man pages posts to Not Applicable at 234 patches.
• Refactor binutils configure usage (Adhemerval)
  • Cleanup in general.
  • Moves them all to AC_LOCAL override.
  • Carlos: To review because OBJDUMP commit was mine.
• [v3] hurd: Make getrandom cache the server port (Sergey)
  • Samuel needs review.
• aarch64: fix elf_machine_dynamic compile error [BZ #29835] (linzhuorong)
  • Szabolcs: Will review since this has to do with their toolchain configuration.

• linux: Use long int for syscall return value (XingLi)

  • Adhemerval: I'll push this.
• [v2] realloc: Return unchanged if request is within usable size (Siddhesh)
  • DJ to review.

• [v2] <time.h>: Make strptime available by default (fweimer)

• <signal.h>: Make bsd_signal available with _GNU_SOURCE (fweimer)

  • The symbol is hidden without good reason. We generally want a superset.
• Add restrict annotations to all functions that require it (Seija)
  • Needs a v2.
• libio: Deprecate the fcloseall function (bug 28099) (fweimer)

• <string.h>: Make strchrnul, strcasestr, memmem available by default (fweimer)

• Revert "Correctly determine libc.so 'OUTPUT_FORMAT' when cross-compiling." (vineet)
  • Fixed by Adhemerval's patch series to refactor binutils.
• [v2] dlsym: Add RTLD_PROBE to dlsym only probe symbol without add dependency. (wangbing)
  • Florian to comment on this again.
• malloc: Use correct C11 atomics for fastbin
  • Asked DJ what the status of review is at.
• Stopped at 60930.
• Fixing missing 64 bit time_t usages (Adhemerval)
  • Asking DJ for review.

Meeting: 2022-11-28 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Starting at 61164

• <time.h>: Make strptime available by default (fweimer)

  • C99 changes.

• <signal.h>: Make bsd_signal available with _GNU_SOURCE (fweimer)

  • C99 changes.
• [v3,1/2] scripts: Add "|" operator support to glibcpp's parsing (shahab)
  • Reviewd by Florian.
• [v3,2/2] ARC: update definitions in elf/elf.h (shahab)
  • Needs review by Vineet Gupta (machine maintainer)
• Add restrict annotations to all functions that require it (Seija)
  • Adhemerval to comment that this changes internal functions and should split.
  • CI - Patch fails to apply?
• Discussed RFC on malloc usable size and systemd usage of remainder of bytes.
• libio: Deprecate the fcloseall function (bug 28099) (fweimer)
  • fcloseall is problematic from an API perspective.
  • Deprecate this release then find a release to switch to backwards compat.

• [v2] <stdio.h>: Make fopencookie, vasprintf, asprintf available by default (fweimer)

  • C99 changes.

• <string.h>: Make strchrnul, strcasestr, memmem available by default

  • C99 changes.
• [v2] Resolve-flockfile-funlockfile-differences (patrick)
  • Under review by Florian.

• LoongArch: Use medium cmodel build libc_nonshared.a. (caiyinyu)

  • Changes requested.

• Series: LoongArch: Use builtins with GCC >= 13 (xiaolin)

  • LoongArch maintainers need to review.

• Revert "Correctly determine libc.so 'OUTPUT_FORMAT' when cross-compiling." (Vineet)
  • Carlos to review.
• [v2] dlsym: Add RTLD_PROBE to dlsym only probe symbol without add dependency. (wang)
  • Discussed that Solaris has RTLD_PROBE, but semantics are different.
  • Need to discuss on list that this may not be needed given the existing requirements.

• LoongArch: Add syscall.c for getting correct return value (XingLi)

  • Changes requested.
• malloc: Use correct C11 atomics for fastbin (wilco)
  • Needs performance review? Could DJ have a look at this?
  • Last time we tried to do this it had a performance regression.
  • Needs review.
• Stopped at 60930
• Siddhesh looking for feedback on RFC for malloc_usable_size

  • https://sourceware.org/pipermail/libc-alpha/2022-November/143599.html

• Adhemerval: Status of "Remove Linux generic sysdep" review?
  • Carlos: Tested it before I went on vacation. Looks good. Want to retest.
• Adhemerval: v2 of "Optimize posix_spawn signal setup with clone3"
  • Carlos: Early commit for this would be nice so machine maintainers.
• Adhemerval: Status of "Fixing remaining lld issues"
  • 3 patches with fweimer for review.

Meeting: 2022-11-21 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• 60925 - ARC: update definitions in elf/elf.h
  • Check for regressions
• 60924 - stdio-common: Add missing dependencies (bug 29780)
• 60899 - Resolve-flockfile-funlockfile-differences
  • Minor style issues
• 60740 - elf: Fix rtld-audit trampoline for aarch64
  • Committed
• 60704 - Apply asm redirections in syslog.h before first use [BZ #27087]
  • Accepted
• 60790 - [v2] i386: Avoid avoid rely on linker optimization to avoid relocation
  • Committed
• Fixing remaining lld issues
  • Florian will take a look
• 60617 - intl: Treat C.UTF-8 locale like C locale (BZ# 16621)
  • Needs discussion

• Restore support for _r_debug copy relocations & interposition

• Siddhesh
  • Nothing
• Florian
  • Nothing
• Szabolcs
  • Nothing
• Patrick
  • Nothing
• Skiped Intel math refactor
• Skiped loongarch match functions
• 60357 - Linux: Support non-variadic calls to prctl (bug 29770)
  • Keep discussion on the list
• 60283 - [v7] POSIX locale covers every byte [BZ# 29511]
  • Keep discussion on the list
• 60162 -[v3] Define in_int32_t_range to check if the 64 bit time_t syscall should be used
  • Delegate to azanella
• loongarch patches
  • Skip, let arch maintainers handle it.

• Restore support for _r_debug copy relocations & interposition

  • Namespace support has landed on GDB
  • We can now test
  • Not urgent, this has been broken for while
• [v4,1/4] x86: Optimize and shrink st{r|p}{n}{cat|cpy}-evex functions
  • Skip, let arch maintainers handle it.
• Optimize posix_spawn signal setup with clone3
  • Help wanted
• Initial fixes for clang build support
  • [v2,3/4] stdlib: Remove if inline asm context casts if compiler does not support it

    • Add a macro for clang to remove the casts

• LoongArch: Fix ABI related macros in elf.h to keep consistent with binutils[1].

  • Still not sure about it
• Florian
  • On time64 and Large File Support
• Patrick
  • Nothing
• Siddhesh
  • Nothing
• Szabolcs
  • Nothing

Meeting: 2022-11-07 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Carlos' SLI at 122 days.
• State NEW delegate NOBODY at 245 patches.
• Starting at 60086

• Restore support for _r_debug copy relocations & interposition (fweimer)

  • Repost series.
  • Still looking for review.
• string: strtok, strtok_r should accept initial NULL subject (bug 16640) (fweimer)
  • Still needs review.
• Makerules: Generate shlib.lds with -fuse-ld=bfd (fangrui)
  • Adhemerval: Will see if it fixes something for the clang build branch.
• [v4,1/4] x86: Optimize and shrink st{r|p}{n}{cat|cpy}-evex functions (noah)
  • HJ has reviewed and needs v2.
• Linux: Add ppoll fortify symbol for 64 bit time_t (BZ# 29746) (adhemerval)
  • Needs a v2.
  • Discussed ABI impact.
  • fweimer: Suggest just dropping fortification for ppoll.
• Optimize posix_spawn signal setup with clone3 (adhemerval)
  • v2 re-sent after discussion with Szabolcs.
  • Needs review.
• elf/tlsdeschtab.h: Add the Malloc return value check in _dl_make_tlsdesc_dynamic() (xiaoming)
  • Szabolcs committed this.
• [v2] x86_64: Implement evex512 version of strrchr and wcsrchr (sunil)
  • Needs review.
  • Carlos: Wow, the benchmark data is getting big.
  • Discussed needing to use benchtests/scripts/compare_strings.py to review results.

• [1/1] LoongArch: Hard Float Support Of Math Functions. (xiaolin)

  • adhemerval: Split into one patch per symbol for review.
• [v6,1/2] iconvdata/tst-table-charmap.sh: remove handling of old, borrowed format (наб)
• [v6,2/2] POSIX locale covers every byte [BZ# 29511]
  • fweimer: Made comments on the first patches.
  • Delegated to fweimer for review.
• Stopped at 59788.
• [10/20] malloc: Fix alignment logic in obstack (szabolcs)
• [12/20] Fix the symbolic link of multilib dirs (szabolcs)
• [20/20] Fix stdlib/test-dlclose-exit-race to not hang (szabolcs)
• [v2,2/4] Fix off-by-one OOB write in iconv/tst-iconv-mt (szabolcs)
  • siddhesh: I could have a look at these last few?
• Remove Linux generic sysdep (adhemerval)
  • Carlos was testing this in his testers and sees no problem.
• nptl: Fix pthread_cond_signal missing a sleeper
  • Carlos reviewing.

Meeting: 2022-10-31 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Carlos' SLI at 122 days.
• State NEW delegate NOBODY at 246 patches.
• Starting at 59641

• LoongArch: Fix ABI related macros in elf.h to keep consistent with binutils[1]. (Caiyinyu)

  • Carlos commented.
• [v1,1/3] string: Add len=0 to {w}memcmp{eq} tests and benchtests (Noah)
  • Adds tests and benchtests
• move some htl symbol into libc (Guy-Fleury)
  • Samuel Thibault doing initial review.
• elf: Build tst-relr-mod[34]a.so with $(LDFLAGS-rpath-ORIGIN) (HJ)
  • Carlos to review.

• linux: Fix fstatat with !XSTAT_IS_XSTAT64 and TIMESIZE=64 (BZ #29730) (Aurelien)

  • Adhemerval: This is not likely the correct change.
  • MIPS has a different kernel-vs-userspace ABI
  • MIPS ends up using an old set of functions "in_time_t_range" to test for certain things.
• Initial fixes for clang build support (Adhemerval)
  • Fangrui Song reviewing.
• patches from the morello port (Szabolcs)
  • Patches largely already pushed.
  • There are 7 patches left to review.

  • Carlos: Note there is a related bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24994

• [v6] elf: Rework exception handling in the dynamic loader [BZ #25486] (fweimer)
  • Siddhesh: I'll review v6.
• Fixing missing 64 bit time_t usages (Adhemerval)
  • Carlos: I'll review.
• Stopping at 59422
• patrickm: This week is the week of meeting confusion.
  • Carlos: I wondered why we had fewer EU attendees!
• Adhemerval: Optimize posix_spawn signal setup with clone3
  • Optimizing the posix_spawn case and removes the 32 syscalls.
  • Would be good to make use of what the Linux kernel provides.

Meeting: 2022-10-24 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2022-10-17 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 205 patches.
• Carlos' SLI is at 137 days (patch to terminal state).
• Started at 58927
• [v4] x86_64: Implement evex512 version of memchr, rawmemchr and wmemchr
  • We expect Noah to review given the VEC API refactor work.
• [1/2] nptl: Simplify condition variables to fix pthread_cond_signal (BZ 25847) (Malte Skarupke)
  • Needs review.
  • Respond to Malte.

• longlong.h: update from GCC for LoongArch clz/ctz support (Xi Ruoyao)

  • Adhemerval will look at ti.
• Introduce per-thread file system properties on Linux (Florian)
  • codonell: Preference for review?
  • 58755 elf: Introduce to _dl_call_fini (preferred review)
• [v3] Use atomic_thread_fence (Wilco)
• PTR_MANGLE/PTR_DEMANGLE refactoring (Florian Weimer)
  • Adhemerval to review. This is the cleanup of the C side of the mangling.
• aarch64: Cleanup memset ifunc (Wilco)
  • Szabolcs to review.
• aarch64: Use memcpy_simd as the default memcpy (Wilco)
  • Szabolcs to review.
• 58650 ldconfig: create /var/cache/ldconfig also with -r (Johannes Schaur Marin Rodrigues)
  • Changes requested by Aurelien.
• [v3] Avoid undefined behaviour in ibm128 implementation of llroundl (BZ #29488) (Aurelien)
  • Still needs a review.
• Stop at 58569.
• Siddhesh: Upgraded patchwork v3.1 + patch from Stephen Finucane
  • Tagged v3.1.1 - Fixes for comment even generation.
  • Note that parse email script failed but python 3.9 worked.
• posix: Fix getconf symbolic constants defined in limits.h (BZ# 29147)
  • Needs review.

Meeting: 2022-10-10 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2022-10-03 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Status NEW delegate NOBODY 220 patches.
• Carlos' patch SLI at 160 days.
• Starting at 58271.

• LoongArch: Fix the condition to use PC-relative addressing in start.S (Xi)

  • Should just commit these as machine maintainers.
• x86: Fix AVX2 string functions requiring BMI1, BMI2 or LZCNT (BZ #29611) (Aurelian)
  • Being reviewed by Noah Goldstein.
• [v2,1/2] Benchtests: Add bench for pthread_spin_{try}lock and mutex_trylock (Noah)
  • Carlos to ask DJ to review.
• Optimize posix_spawn signal setup with clone3 (Adhemerval)
  • Need a reviewer.
  • Small optimization to remove a number of syscalls.
• Remove legacy hwcaps support (Javier) at v3.
  • Florian is reviewing this series.
• dlsym: Add RTLD_PROBE for situation when dlsym only wants to probe a symbol but not use it
  • Fails CI. Changes requested by Florian (add a test)
• x86: Remove .tfloat usage (Adhemerval)
  • Mark superseded. Will post v2.
• nis: Fix nis_print_directory (Adhemerval)
  • Ask Arjun to review.
• [v2] linux: Avoid shifting a negative signed on POSIX timer interface (Adhemerval)
  • Ask Arjun to review.
• x86_64: Implement evex512 version of strchrnul, strchr and wcschr (Sunil)
• x86_64: Implement evex512 version of strrchr and wcsrchr (Sunil)
• x86_64: Implement evex512 version of memchr, rawmemchr and wmemchr (Sunil)
  • Noah: Can we use the core memory routines and implement them out of a few routines?
  • Sunil: The C generic impl can't quite provide the same performance as the asm.
    • Note: Even if everything is exactly the same, but arguments are different, what
      • happens is because of the encoding (which depends on the arguments) it changes. These changes can cause subtle performance differences.
  • codonell: At the last meeting we discussed the balance of 5 routines vs. maintenance.
  • Sunil: We can try to simplify this for maintenance but we may be leaving performance
    • behind.
  • Noah: I can help try to refactor it without performance loss in the other cases.
  • codonell: Is the next step to try to refactor this?
  • Noah: Yes, some things can be, but some cannot (strrchr).
  • Sunil: ymm vs zmm performance is critical. But zmm is going to be experimental until
    • performance profile changes. Mixing zmm and ymm impls could have risk to users.
• Sunil: For backports to 2.33, using the bmg results, and testing.

  • Arjun can test under Fedora. Sunil to email arjun@redhat.com.

  • Noah: There is one more real bug in strcmp. We may want to add this?
• Adhemerval: Looking fore review for -fno-tree-loop-distribute changes.
  • codonell: I'll review that.

Meeting: 2022-09-26 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 190 patches.
• Start at 57987

• [v3,1/1] LoongArch: Add static PIE support (Xi)

  • Adhemerval to review.
• x86_64: Implement evex512 version of strchrnul, strchr and wcschr (Sunil)
• x86_64: Implement evex512 version of strrchr and wcsrchr (Sunil)
  • Adhermerval: What about just using the generic string routines?
    • There is a maintenance cost to these functions.
    • If we don't see them in workloads then we add maintenance cost.
  • Sunil: As part of the standard we take the perspective that anyone could
    • use these functions.
  • Adhemerval: Suggest reviewing the balance of 5 raw assembly implementations
    • versus the cost of just using the generic impl which uses other str* functions.
• x86_64: Implement evex512 version of memchr, rawmemchr and wmemchr (Sunil)
  • Looking for community review of the versions.
• Discussed that it would be good to have a broader discussion about optimized
  • functions for everything in order to drive review.
• Disucssed with Intel reviewing libc-stable patches.
  • Need feedback on the backport to 2.33 stable branch.
  • Agreed to setup an upstream branch for Fedora glibc team to test.
• [v5,1/2] iconvdata/tst-table-charmap.sh: remove handling of old, borrowed format (Ha)
• [v5,2/2] POSIX locale covers every byte [BZ# 29511] (Ha)
  • Wait for feedback from Florian.
• 57850 to 57845 is Fix -Os build
  • Carlos to review and ACK.
  • Adhemerval: It was a real size reduction. Objectively it was ~10%.
• [v1] x86: Fix wcsnlen-avx2 page cross length comparison [BZ #29591] (Noah)
• [v4] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support (Adhemerval)
  • Carlos to reivew.

Meeting: 2022-09-19 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Anything to discuss:
  • Florian: nothing
  • Siddhesh: rework patchwork flow
• 57741: azanella
• Remove legacy hwcaps support

  • https://patchwork.sourceware.org/project/glibc/list/?series=12012 superseded

• [v2] stdlib/strfrom: Change -NAN test to multiple possible results (bug 29501)
  • Rejected

• https://patchwork.sourceware.org/project/glibc/patch/20220916071642.2822131-2-dengjianbo@loongson.cn/

  • Work toward generic implementation

• https://patchwork.sourceware.org/project/glibc/patch/87mtb0keai.fsf@oldenburg.str.redhat.com/

  • Wait for Carlos

• https://patchwork.sourceware.org/project/glibc/list/?series=12232

  • Delegate to Siddhesh

• https://patchwork.sourceware.org/project/glibc/patch/33460cc477c856fd185bb8355088bfaa8f208ebb.1663123101.git.nabijaczleweli@nabijaczleweli.xyz/

• https://patchwork.sourceware.org/project/glibc/patch/d26840d7bc62c0979243e06d1fdea68e4351390f.1663123101.git.nabijaczleweli@nabijaczleweli.xyz/

  • Delegate to Florian

• https://patchwork.sourceware.org/project/glibc/patch/20220913155558.555979-1-xry111@xry111.site/

• https://patchwork.sourceware.org/project/glibc/list/?series=12055

  • Not urgent

• https://patchwork.sourceware.org/project/glibc/list/?series=12022

• https://patchwork.sourceware.org/project/glibc/patch/20220905171043.1097209-1-adhemerval.zanella@linaro.org/

• https://patchwork.sourceware.org/project/glibc/patch/20220831181400.3875516-1-adhemerval.zanella@linaro.org/

• https://patchwork.sourceware.org/project/glibc/patch/20220830120802.1072466-1-adhemerval.zanella@linaro.org/

• Patchwork:
  • Maybe add a new 'Not applicable state'

Meeting: 2022-09-12 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY is at 236.
• Starting 57539
• 57498 Use C11 atomics instead atomic_decrement_and_test
• 57495 Use C11 atomics instead of atomic_increment(_val)
• 57439-57440 iconvdata/tst-table-charmap.sh: remove handling of old, borrowed format
  • Needs review of series against existing builtin POSIX locale.
• Stopped early since most people are travelling for LPC or Cauldron.

Meeting: 2022-09-05 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY is at 279 patches.
• Cleanup some old patches from Florian

• Discussed briefly https://github.com/itanium-cxx-abi/cxx-abi/issues/146

• Yinyu Cai (LoongArch maintainer) has asked us to give him access to wiki editing.

• POSIX locale covers every byte [BZ# 29511]
  • Florian thinks the patch is not really ok, although the rationale should be ok.

• scripts/build-many-glibcs.py: Use https:// for sourceware.org Git clones

  • Security hardening, acked by Adhemerval
• vprintf refactor
  • Adhemerval will take a look, some patches are already acked
• Ask for review:
  • [v4] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support (Adhemerval)

Meeting: 2022-08-29 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY is at 233
• Start at 57139.
• Noted that Sourcware.org was is slow today and having connection issues.
  • Carlos to check with overseers.
• syslog: Fix large messages (BZ#29536) (Adhemerval)
  • New for 2.36.
  • Carlos to ask DJ for review.
  • Asked Sidddhesh to review security +/-
• Rework exception handling in the dynamic loader [BZ #25486] (Florian)
  • Ask Szabolcs or Carlos for review.

• elf: Call libc_early_init for reused namespaces (bug 29528) (Florian)

  • v2 already committed. Superseded.
• nss_dns: Fix handling of non-host CNAMEs (bug 12154) (Florian)
  • Reviewed by Siddhesh. Two patches remaining.
• Stopped 57078
• [v4] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support (Adhemerval)
• [v3] debug: test for more required cacellation points (BZ# 29274) (Adhemerval)
  • Carlos to review.

Meeting: 2022-08-22 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY is at 217
• Starting at 56906
• Fix BZ #29463 in the ibm128 implementation of y1l too (mwh)
  • Needs review from IBM
• [v2] Avoid undefined behaviour in ibm128 implementation of llroundl (mwh)
  • Needs review from IBM

• [resend] LoongArch: Fix dl-machine.h code formatting

  • Needs a quick review for code formatting.

• LoongArch: Use builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13

  • Needs review.

• codonell: Who is the LoongArch machine maintainer?

  • Such a machine maintainer could push machine patches.
  • Caiyin Yu? Should discuss this with Caiyin.
• adhemerval: Who is syncing the translations?
  • codonell: I am to release/2.36/master.
• Check ld.so/libc.so consistency during startup (fweimer)
  • codonell: I want to review this today.
• vfprintf refactor (fweimer)
  • Needs review.
  • Review required for buffer implementation.

• [1/1] LoongArch: Fix ptr mangling/demangling features. (caiyinyu)

  • Needs changes.
• Add AArch64 HWCAP2_* constants from Linux 5.19 (joseh)
  • szabolcs will review.
• Add NT_LOONGARCH_* from Linux 5.19 to elf.h
  • Will ask Caiyin Yu to review?

  • Needs LoongArch maintainer to review.

• Stopped at 56821.
• Forced ordering for DFS ELF dependency sorting (bug 28937) (fweimer)
  • codonell: Would be great to fix this for the new sort algo.
  • adhemerval: I'll review.
• An update with regards to the DT_HASH situation?
  • adhemerval: We should keep DT_HASH. This is an issue of optics.
  • fweimer: This is a difficult decision that we should wait to determine
    • if we know all of the details of what works and doesn't work.
  • codonell: I can make a public statement around this.
• [v4] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support (adhemerval)
  • Needs review.
• [v3] debug: test for more required cacellation points (BZ# 29274)
  • Still needs review from Carlos.

Meeting: 2022-08-15 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 225 patches.

• LoongArch: Add optimized functions.

  • Noah: Anything with optimized would be nice to have microbenchmark numbers.
  • Carlos: I'll review and ask for the microbenchmark numbers.
• Linux: Terminate subprocess on late failure in tst-pidfd (bug 29485)
  • Florian: Need to terminate the process.
• netinet/in.h: Add ip_mreqn structure (Samuel Thibaut)
  • Florian: I'll write a follow up.
• Ensure calculations happen with desired rounding mode in y1lf128 (Michael)
  • Needs review from IBM.
• Improve performance of libc locks (Wilco)
  • Carlos: I'll review and ask for the microbenchmark numbers.
  • Siddhesh: This is a generic change that needs to show numbers.
• [v4] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support (Adhemerval)
  • Needs review.
• nss_dns: Fix handling of non-host CNAMEs (bug 12154) (Florian)
  • Siddhesh will look at the series.
• sunrpc: Stub out getpublickey, getsecretkey, authdes_create (Florian)
  • Carlos: We got rid of configure, and TIRPC can only be used.
    • Even if you could use a non-files 'key' provider we don't want to support this.
• malloc: Do not use MAP_NORESERVE to allocate heap segments (Florian)
  • Reviewed by Siddhesh.
• Stopped at 56583.
• Noah asked about the status of strlcpy and strlcat.
  • These are still with the Austin Group for deliberation and addition to POSIX.
  • Likely to be discussed at the next telecon.
  • There is a defect report against these interfaces filed by Paul Eggert.
  • We are waiting for the Austin Group to deliberate.
  • Noah has optimized versions of these routines that could go into glibc.

Meeting: 2022-08-08 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• - Status NEW delegate NOBODY at 218 patches. - Starting 56589 (last start 56467)

  - [v1] elf: Replace strcpy call with memcpy [BZ #29454] (Noah)

  • - Needs review.

  - [v1] x86: Fix #define STRCPY guard in strcpy-sse2.S (Noah)

  • - HJ to review?
  - [RFC] elf: fine-grained output LD_DEBUG log when symbol lookup error
  • - Florian to point out this doesn't do what they want.
  - stdlib: tests: don't double-define _FORTIFY_SOURCE (Sam)
  • - Siddhesh to review. - Adhemerval: Do we support building glibc with _FORTIFY_SOURCE=2 on
    • by default?
    - Tested by Gentoo and it's working.
  - [RFC] RISC-V: Implement {convert,round}toint() (Palmer) - [v3] Remove catomics (Wilco)
  • - Adhemerval to comment on a strategy that can involve staggered removal
  - [v1] stdlib: Add more room for reuse of random bits in arc4random_uniform
  • - Given Noah's comments marked as dropped.
  - x86-64: Restore LD_PREFER_MAP_32BIT_EXEC support [BZ #28656] (HJ)
  • - Florian will continue discussion with HJ about kernel support.
  - feat: crypt support sm3 algorithm (Mingjun)
  • - Carlos marked rejected because it needs to go to libxcrypt.
  - resolv: Set a timeout for TCP-based query read (bug 19643) - Skip to 56275 to review older bugs. - [V2] resolv: use arc4random_uniform in the generation of random ids
  • - Carlos marked as changes requested.
  - longlong: Update the checks for "mul" on RISC-V (Palmer)
  • - Reviewed by Andreas. Marked Changes Requested.

  - inet: Turn ivaliduser into a compatibility symbol (Florian)

  • - Needs a v2. Marked changes requested.
  - Stopped at 56223. - Szabolcs: There are licensing discrepancies between various start.S
  • assembly files for architectures and this should be corrected in order to move towards the expected license behaviour.
  • - Carlos: I agree. We can take this up with the FSF to adjust.
  - Florian: Fixing the mount.h header file conflict.
  • - Adhemerval: Discussed this briefly. - Siddhesh: It's sys/fs and linux/fs that breaks things and I've
    • filed several bugs for maintainers to move one way or the other.
    - Florian: qemu developers have had to copy things. - Ahdemerval: If the user needs the kernel interface then they should
    • use syscalls directly and should use the linux headers directly. Why do we need to mix the header usage?
    - Florian: We don't have a wrapper header for linux/fs.h. - Adhemerval: We can work on a fix.
  - Adhemerval: How are we going to handle the posix_spawn issue?
  • - Florian: Linux 6.0 will have the vfork+exec fix. - Florian: I'll file some backport requests for the kernel.

Meeting: 2022-08-01 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• NEW / NOBODY at 219 patches.
• Release 2.36 branch fixes needed?
• Starting 56467
• Internal asserts cleanups (Florian)
  • Not immediately urgent.

• malloc: Use getrandom_nocancel during tcache initiailization (Florian)

• Remove spurious references to _dl_open_hook (Florian)
• feat: crypt support sm3 algorithm (Yang)
  • Discussed rejection of patch due to deprecation of libcrypt in favour
    • of libxcrypt. Need to adjust library for 2.37 to remove crypt routines. This is similar to Sun RPC deprecation.
• [v4] socket: Check lengths before advancing pointer in CMSG_NXTHDR (Arjun)
  • OK to commit. Has RB.
• [v2] stdlib: Simplify arc4random_uniform
  • OK to commit. Has RB.
• resolv: Set a timeout for TCP-based query read (bug 19643) (Sinan)
  • Florian to review.
• [v4,1/1] memalign: Support scanning for aligned chunks. (DJ)
  • Carlos to review with DJ next week.
  • Florian noted we need to process tcache chunks.
• Remove atomic-machine headers (Wilco)
  • Patch doesn't apply.
• Use atomic_thread_fence (Wilco)
  • Patch doesn't apply.
• GLIBC LOONGARCH PATCHES (Yu)
  • Needs review for gettimeofday vDSO addition.
• [v2] NEWS: Add entry for x86-64 ISA level build (Noah)
  • Dropped.
• [v2] nscd: Fix netlink cache invalidation if epoll is used [BZ #29415]
  • Reviewed by DJ. Can be committed with 2.37 open.
• [V2] resolv: use arc4random_uniform in the generation of random ids (Cristian)
  • This needs a v3.
• Stopped at 56275.
• Any issues to raise for review:
• Adhemerval: [v3] debug: test for more required cacellation points (BZ# 29274) (Adhemerval)
  • Carlos needs to review.

Meeting: 2022-07-25 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2022-07-18 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• Status NEW / NOBODY is at 229 patches.
• Starat at 56119.
• Discussing ABI issues for glibc 2.36

  • LoongArch patches need a new version.

    • Very contained to just the architecture patches.
    • codonell: Will ask them to send a new version for testing.
  • arc4random needs review.
    • Testing has happened on all real hardware.
    • fweimer: Do we label the function as crypto secure?
    • fweimer: Anyone certifying OpenBSD for use in FIPS backends
      • will either have to rewrite the openbsd impl or
        • note that it should not be used crypto secure.
    • adhemerval: Note that POSIX has an issue out to add arc4random
      • but it would not be cryptographically secure either.

      • https://austingroupbugs.net/view.php?id=859

• noah: Looking at bug 29327 and impact on glibc 2.36?

  • https://sourceware.org/bugzilla/show_bug.cgi?id=29327

  • fweimer: Often we get bugs reported because string or memory
    • operations are given invalid pointers.
  • Can't reproducer.
• adhemerval: Szabolcs, May you please check on optimzied arc4random?
• codonell: I'm out of the office 22-28.
  • Discussed having replacement RM to ack patches into tree.
  • adhemerval accepted doing the role.
• New reviews at 56119 (226 patches)

• [v2] x86: Fix typo of Slow_SSE4_2 def in isa-level.h - skip

• Always do locking when accessing streams (bug 15142, bug 14697)
  • codonell: This needs review for release.
• [v1] x86: Continue building memmove-ssse3.S as ISA level V3 - skip
• [v3] linux: return UNSUPPORTED from tst-mount if entering mount namespace fails
  • codonell: Check on push.
• [v1,1/1] memalign: Support scanning for aligned chunks. (DJ)
  • Fails CI.
• [v1] nptl: Continue use arch prefered atomic exchange in spinlock loop (need review)
• [v1] nptl: Replace CAS with cheaper atomics for pthread_cancel logic (need review)
• [2.37] x86-64: Use ENTRY_P2ALIGN and END in strcmp-XXX.S (waiting)
• [v2] Update scripts/config.* files from upstream GNU config version
  • codonell: Will review.
• [v2] debug: test for more required cacellation points (BZ# 29274) (need review)
• [PATCHv4] tst-pidfd.c: UNSUPPORTED if we get EPERM on valid pidfd_getfd call
  • codonell: To review as RM.
• elf.h: Add ELFCOMPRESS_ZSTD (Fangrui)
  • codonell: To comment.

• 55882-55877 LoongArch sequence needs repost with new version.

• [1/7] Use atomic_exchange_release/acquire (Wilco)
  • Not OK for 2.36. Can review early for 2.37.
• soft-fp: Add fixhf[uns][di|si] and float[uns][di|si]hf (need review)
  • codonell: This isn't a public ABI/API but glibc is just canonical.
  • Not a release blocker.
• Stopping new review at 55745.

Meeting: 2022-07-11 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY 217 patches
• Switching to discussing ABI blockers for release.
• ABI issues for glibc 2.36
  • arc4random
  • Loongarch
• [codonell] Kernel syscalls we would add?
  • azanella: Checked to 5.17.
  • Latest two releases may have new syscalls.
  • What about libiouring? Don't want to be tied to libc itself.
• The 5.19 rc3/4 for kernel ABI is in place for Loongarch.
• [v8] Add arc4random support (Series 10509)
  • Florian will look at this.

• [v6] LoongArch (13 patches)

  • fweimer: Is upstream binutils ready?
  • azanella: Built cross toolchain and it looks ready (2.38)
  • fweimer: Upstream binutils issues:

    • https://sourceware.org/pipermail/libc-alpha/2022-July/140458.html

  • azanella: Want a committed upstream binutils and gcc.
    • codonell: Agree, want a committed linux, gcc, and binutils.

  • codonell: Will reach out to Nick Clifton to review LoongArch.

• patrick: Can we submit regression fixes during the freeze?
  • codonell: Yes, we can fix bugs up until the release.
• Update miscellaneous files from upstream sources (azanella)
  • Needs review. Built many arches and it was OK.
  • fweimer: config.guess/config.sub
• elf.h: Add ELFCOMPRESS_ZSTD (fangrui)
  • Not a release blocker.
  • Blocked on Generic ABI or GNU ABI accepting.
• x86-64: Remove redundant strcspn-generic/strpbrk-generic/strspn-generic
  • Reviewed by Noah.
• [PATCHv3] Apply asm redirections in stdio.h before first use [BZ #27087]
  • With clang with long double == float128.
  • When Fedora was updated to clang14 we ran into this issue.
  • codonell: Not a release blocker *yet* because upstream defaults don't fail.
• [1/7] Use atomic_exchange_release/acquire (Wilco)
  • codonell: Impact on aarch64? Can we wait until after the branch?
  • szabolcs: I think so.
• Stopped at 55764.
• Any patches to raise?
• soft-fp: Add fixhf[uns][di|si] and float[uns][di|si]hf
  • codonell: Are we the canonical place for soft-fp?
  • Check with Joseph Myers about canonical place for soft-fp.
  • szabolcs: Confirmed. glibc is upstream.
  • Needs review.
• 55628 [PATCHv3] tst-pidfd.c: UNSUPPORTED if we get EPERM on pidfd_open or pidfd_getfd
  • Rejected.
  • codonell: I'll respond again.
• fweimer: Noted that Joseph Myers builder has been failing.

  • https://sourceware.org/pipermail/libc-testresults/2022q3/009939.html

  • Looks like BMG check fails.
  • Using mainline.
  • codonell: Uses mainline gcc builds which won't impact glibc until January.
  • fweimer: Could mask other issues.

Meeting: 2022-07-04 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY at 237 patches.
• Discussed having a workable backlog.
• Started at 55340
• v7 linux: Add new syscalls (Adhemveral)
  • Carlos to review.
• build: report an error message when missing test name (Yann Droneaud)
  • Carlos to review.
• At 55269.
• Simplify internal single-threaded usage (Adhemerval)
• At 55129.
• [patch/idea,v2] Add register scrambling to testsuite (DJ)
  • Needs review.
• vfprintf refactor (Florian Weimer)
• Discsuss ABI for glibc 2.36
  • C++20 APIs need review.
  • arc4random adds ABIs.

  • LoongArch new ABI.

  • Predictable ELF destructor ordering (not ABI, but impacts behaviour)
  • Implementation RTLD_SHARED for dlmopen.
• Stopped review and noted 227 patches in teh queue.

Meeting: 2022-06-27 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY is 243 patches.
• Started review at 55440.
• [PATCHv2] tst-pidfd.c: Test is UNSUPPORTED without PTRACE_MODE_ATTACH_REALCREDS (Mark)
  • Yes, we need the credentials. Need to review.
• [PATCHv2] time/tst-clock2.c: clock_settime CLOCK_MONOTONIC might return EPERM (Mark)
  • It seems correct, but strange that we get EPERM.
• build: report an error message when missing test name (Yann)
  • Carlos: I will commit this for Yann.
• [1/4] time/tst-clock2.c: clock_settime CLOCK_MONOTONIC might return EPERM (Mark)
  • I guess this is correct, but it is superseeded.
• [v5] x86: Fix backwards Prefer_No_VZEROUPPER check in ifunc-evex.h (Noah)
  • Accepted by HJ
• [v7] linux: Add new syscalls (Adhemerval)
  • Carlos: I will review again.
• 55381 [v2] x86: Add comment with ISA level for all targets support by GCC12.1
  • Not needed. Marked rejected.
• 55380-55375 are Noah's patches for the x86 optimizations.
  • Marked as Accepted or Superceded with review from HJ.
• Stopped at 55340 libc-symbols.h: remove unused macros.
• 55269 aarch64: Optimize string functions with shrn instruction
  • Carlos: Will comment on Signed-off-by vs. Google copyright assignment.
• Siddhesh: Patchwork and Django are up to date now.
  • Carlos: This enables us to respond to patchwork comments.
• Adhemerval: Ping arc4random since it has been on the queue for some time.
  • Looking for an acknowledgement from Florian regarding the arc4random approach.
  • Florian Weimer was the previous author of an attempt to include arc4random.
  • Carlos: I'll follow up with Florian.
  • Siddhesh: I can talk to Florian about hand-off of the series to Siddhesh for review.
• Carlos: Note that glibc 2.36 needs an RM.

Meeting: 2022-06-20 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2022-06-13 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

Meeting: 2022-06-06 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY 238
• Start at 54820
• aarch64: Handle fewer relocations for RTLD_BOOTSTRAP
  • Arm should review for AEABI compliance?
• riscv: Change the relocations handled for RTLD_BOOTSTRAP
  • Need machine maintainer review.
• [v4,1/2] nss: add assert to DB_LOOKUP_FCT (BZ #28752)
  • Carlos: Will ask DJ to review.
• [v1] x86: ZERO_UPPER_VEC_REGISTERS_RETURN_XTEST expect no transactions
  • Noah: Will resubmit after teh VEC classes gets approved.
  • Fails CI because previous series needs application.
• [v3,1/8] x86: Create header for VEC classes in x86 strings library
  • Noah: HJ should have a look at these.
• x86_64: Add strstr function with 512-bit EVEX
  • Noah: Looking into this.
• [v2] nptl_db: disable DT_RELR on libthread_db.so
  • Carlos: Will review.
• Avoid -Wstringop-overflow= warning in iconv module. \
  • Siddhesh: Will review.
• resolv: Implement no-aaaa stub resolver option
  • Carlos: Already reviewed. Changes request.
• New syscalls for mount and namespace
  • Carlos: Adhemerval can you please rebase and send the new syscalls?
• Add PT_AARCH64_MEMTAG_MTE from Linux 5.18 to elf.h
  • Already reviewed.
• [v3] elf: Remove ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA
  • Szabolcs: Semantics have changed with this patch and it needs more
    • serious review. Simple test cases previously worked and now it doesn't.

• GLIBC LoongArch PATCHES (caiyinyu)

  • Needs review.
  • Carlos: What is the status of the ABI? It has been submitted to musl.
  • Adhemerval: I think musl's ABI is done, but there is kernel discussion.

• nptl: Fix libc_cleanup_pop_restore asynchronous restore (BZ#29214) (Adhemerval)

  • Carlos: Will review.
  • Broken in 2.35.
• v3: Fix various NPTL synchronization issues (Adhemerval)
  • Robustness issue, and fixes BZ #19951, which is a real issue.
• Review ended 54535.
• Noah: Why can't we use #define to define rseq offset?
  • Noah: Florian isn't here, and I was going to ask him the question.
  • Szabolcs: It's for maintenance reasons. The kernel wanted to grow
    • the size of rseq, and we didn't want to have to define a constant location for all arches, and we didn't want to define a different constant per arch, so we just made it another lookup. You can cache the values in globals if the two TLS accesses are slower than you expect.

Meeting: 2022-05-30 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and attendee requested reviews.

• State NEW delegate NOBODY, 228 patches.
• Starting at 54476
• elf: Remove ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA (Fangrui Song)
  • Needs review. Szabolcs: Same as aarch64.
  • This never worked.
• [v2] elf: Remove one-default-version check when searching an unversioned symbol (Fangrui Song)
  • Florian made a comment about the underlying semantics.
• [v1] benchtests: Improve benchtests for strstr, memmem, and memchr (Noah)
  • Already pushed.
• posix: Fix getconf symbolic constants defined in limits.h (BZ# 29147) (Adhemerval)
  • Review if the minimum impacts applications.
• elf: Fix handling of symbol versions which hash to zero (bug 29190) (Florian Weimer)
  • Found all uppercase P's that hash to zero.
• [1/1] x86_64: Add strstr function with 512-bit EVEX (Raghuveer Devulapalli)
  • Noah updated the benchmark for this.
  • Adhemerval: Can we make this more generic?
  • Noah: Wilco's version is simply better.
• Remove _dl_skip_args (Adhemerval)
  • Needs review.
  • Some machime maintainers have reviewed.
  • i686,x86_64: Done, hppa: Reviewed, aarch64: Already done.
• Stopped at 54394.
• Discussed "linux: Add fallback for clone failure on posix_spawn (BZ #29115)"
  • The issues goes far beyond glibc.
  • If we make posix_spawn work then users can use this.
  • Adhemerval: Rewriting with shared mapping.
  • Florian: Always use a shared mapping the first time to detect vfork-as-fork.
    • Just a future direction for the code.
• Reminder: GNU Tools Cauldron 2022

  • https://gcc.gnu.org/wiki/cauldron2022

  • We can review the patch queue in person!

Meeting: 2022-05-16 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

• Carlos O'Donell sends his regrets.

Review new patches and attendee requested reviews.

• Status NEW delgate NOBODY 224 patches.
• Start at patch 54271.

• dlfcn: Move RTLD_DEFAULT/RTLD_NEXT outside USE_GNU

  • - Looks ok, Florian will review.
• linux: use statx for fstat if neither newfstatat nor fstatat64 is present
  • - Looks ok, Adhemerval will review.
• x86-64: Ignore r_addend for R_X86_64_GLOB_DAT/R_X86_64_JUMP_SLOT
  • - Fangrui state is is already done on other environments, Florian will review.
• dlsym: Make RTLD_NEXT prefer default version definition [#BZ #14932]
  • - Current status is too broken to keep a versioned symbol, change looks reasonable.
• [v11,1/6] elf: Refactor dl_new_hash so it can be tested / benchmarked
  • - Accepted by Siddhesh.
• [1/5] locale: Turn ADDC and ADDS into functions in linereader.c
  • - Not urgent, skipped for now.
• Avoid RMW of flags2 outside lock (BZ #27842)
  • - Still need some discussion that lock can be skipped if flockfile is called.
• [v2] x86_64: Implement evex512 version of strlen, strnlen, wcslen and wcsnlen
  • - Noah is reviewing it.
• [v3] Fix deadlock when pthread_atfork handler calls pthread_atfork or dlclose
  • - Accepted by Adhemerval.
• Add arc4random support
  • - Still need reviewers.
• [v3] Remove special flags of libc.5.so and libc.4.so
  • - Patch looks ok, some changers required.
• socket: Check lengths before advancing pointer in CMSG_NXTHDR
  • - Siddhesh will review it.
• [v4,3/3] linux: Add fallback for clone failure on posix_spawn (BZ #29115)
  • - Skipped, most likely will result in WONTFIX and programs will need to use
    • any new kernel time namespace fix kernel will provide.

• GLIBC LoongArch PATCHES

  • - Patchset looks ok, still requires some upstream fixes. Skipped due it will
    • require at least a v5.
• [v3] elf: Rewrite long RESOLVE_MAP macro to a debug friendly function

  • - Siddhesh is ok with the always_inline change.

• [v3] math: Add math-use-builtins-fabs (BZ#29027)
  • - The patch is ok, it does not change any code.
• stdio-common: Add the fgetln function
  • - Still need review.
• elf: Simplify version test when searching a versioned symbol
  • - Florian will review.
• Simplify ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA and revert aarch64/arm's extern protected data handle
  • - Florian will review.
• Optimize struct pthread size
  • - Skipped, Arjun will review.
• libio: Remove _IO_adjust_column, _IO_adjust_wcolumn, column tracking
  • - Adhemerval will review.
• powerpc64: small-model @got@tprel accesses
• [v3] powerpc64: Enable static-pie
  • - skipped, waiting review from powerpc maintainers.
• Stopped at 52777.
• Siddhesh
  • - Nothing to review.
• Szabolcs
  • - Nothing
• Sunil

  • - Need to check https://sourceware.org/bugzilla/show_bug.cgi?id=29127

• Noah
  • - Can we change pthread cond to use default mutex and increment the counter
    • outside? Is this a GNU extension or is related to some different mutex type?
• Patrick
  • - Nothing
• Florian
  • - Nothing

Meeting: 2022-05-16 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

• Status NEW delgate NOBODY 252 patches.
• Start at patch 53982
• [v2] Remove special flags of libc.5.so and libc.4.so
  • Adhemerval will review.
  • Florian: Cleanup is valuable.
• 53980 Enable DT_RELR automatically
  • Carlos: Make first commit message line more descriptive
• 53963 Check for ISO C compilers should also allow C++
  • Fangrui and Florian reviewed.

• 53886 fortify: Ensure that glibc_fortify condition is a constant [BZ #29141]

  • Florian noted Siddhesh is the subject matter expert.
• [v8,1/6] elf: Refactor dl_new_hash so it can be tested / benchmarked
  • Adhemerval: Is this something we can get the compiler to do?
  • Carlos: Yes, it would be better if the compiler did it, but today it doesn't.
  • Ahemerval: Not a blocking objection, but don't like the asm.
  • Siddhesh: Elevate the objection about the asm. Will comment on the list.
• 53756 Linux: Fix posix_spawn when user with time namespaces
  • Florian: Ask kernel for new way of entering time namespace
  • The kernel can't change the current behaviour.
  • Many C and C++ libraries have interfaces implemented from scratch.
  • All the interfaces would have to be changed to support this.
  • Florian: Reached out to Christian Brauner about this on the musl thread.
  • Do we need to speak with Andrei Vagin (CRIU)?
• Stopped at 53612.
• Adhemerval: Looking for arc4random review.
  • arc4random at v5 review.
  • Carlos will review kernel syscall patches.
  • Florian has not reviewed this as author of the previous attempt.
  • Carlos: We are talking about commiting to the ABI? Any objections to the ABI?
  • Florian: We should add the ABI.
• Arjun: Have two patches to reivew. New patch to post v3 for pthread_atfork.
• Florian:
  • brk change:
    • Not sure where I'm heading with the brk change.
    • Adhemerval: OK with the brk changes.
  • vfprintf rework still needs review of the buffer management.
  • UTF-8 locale source work:
    • Siddhesh can change one.
    • Carlos can change Spanish locales (22 of them)
• HJ: Nothing to review.
  • Long term goal to get rid of copy relocation in x86.
  • There are a couple of platform that support copy relocations.
  • Many don't support copy relocations.
  • From a performance and security POV we want to get rid of them.
  • Especially with protected symbols they are supposed to improve performance.
  • Semantics of copy relocations break this.
  • gcc 12 has option to avoid copy relocations on x86.
  • Explore removing copy relocations?
  • Florian: From Fedora and downstream perspective copy relocations don't matter.
    • We use LTO and the builds localize the symbols.
    • The change to copy reocations is a NOP.
    • Likewise for SUSE.

    • HJ: Note in Windows with declspec(dllimport/dllexport) we can improve code gen.

      • HJ: Anything we can do here that is similar?
  • Florian: COPY relocations may still be relevant on some architectures.
    • For example cost to access global data through the GOT
• Szabolcs: Outstanding patch was reviewed. Need to change and push.

Meeting: 2022-05-09 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

• 255 patches in NEW/NOBODY
• Started at 53612.

• GLIBC LoongArch PATCHES (caiyinyu)

  • LoongArch patch series for glibc.

  • Joseph Myers was previously reviewing this.
  • Several other developers reviewed parts of the series.
  • Review against existing v2

    • https://sourceware.org/pipermail/libc-alpha/2021-December/134811.html

  • LoongArch is not yet upstream in the kernel.

  • Need to have the port make its way into the kernel via linux-next.
  • With 5.19 slated for August, we need to consider if RC phase constants
    • are good enough for a glibc port.
  • Could we merge and then backout of the port doesn't make 5.19?
• 53573: [v3] elf: Rewrite long RESOLVE_MAP macro to a debug friendly function (guriev)
  • Fangrui was looking at earlier versions of the cleanup.
• 53613: [v2] wcrtomb: Make behavior POSIX compliant (poyarekar)
  • Looking for review for v2 from earlier reviewers.
  • Adhemerval: Patch itself is OK, but need to check if the patch has consensus.
  • Carlos: Manual should say what you have *now* in the impl.
  • Siddhesh: Main concern is bumping symbol version because it avoids backports of
    • the fix.
• 53543: [v5] nptl: Add backoff mechanism to spinlock loop (Wangyang)
  • HJ reviewing. Should be committed today.
• 53526: [v3] math: Add math-use-builtins-fabs (BZ#29027)
  • Joseph pointed out issues.
  • Followed up with suggestions. Just a code cleanup.
  • Should not change code generation.
• 53523: [PATCH v4 1/3] ia64: Always define IA64_USE_NEW_STUB as a flag macro
  • Adhemerval and Florian discussing consensus.
  • Adhemerval: Move mmap call to internal definition. So we can use the same logic.

  • https://sourceware.org/pipermail/libc-alpha/2022-May/138524.html

  • Florian to review.
• 53519: Args adjustment with ./ld.so exe [BZ #23293] (v6)
  • Need 1 and 4 patches reviewed.
  • Florian: The first patch needs reivew.
• Stopped at 53519.
• Florian: vfprintf not that high priority.
  • Someone should look at the buffer abstraction.
  • Series 7969.
  • Patch 17 implements the abstraction.
• Arjun: pthread_atfork v2.
• Adhemerval:
  • Fallback clone on posix_spawn failure.
    • Ask Christian Brauner about the vDSO issue.
    • There is conflict here with the semantics.

Meeting: 2022-05-02 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

• 259 patches in NEW/NOBODY.
• 53383 powerpc32: Remove unused HAVE_PPC_SECURE_PLT (Fangrui)
  • Reviewed by Florian.
• 53379 elf: Remove fallback to the start of DT_STRTAB for dladdr (Fangrui)
  • Needs review.
• 53375 elf: Simplify version test when searching a versioned symbol (Fangrui)
  • Needs review.
• Simplify ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA and revert aarch64/arm's extern protected data handl…
  • Ask HJ if he can provide review (worked on this before).
• elf: Remove one-default-version check when searching an unversioned symbol (Fangrui)
  • Needs review.
• S390: Enable static PIE (Stefan Liebler)
  • Needs quite a bit of kernel support.
  • Florian and Adhemerval in agreement that we should handle failures gracefully.
  • brk failures default back to mmap.
  • Should we just use mmap unconditionally?

• time: Use nonnull to avoid null pointer (Xiaoming)

  • Under review from Siddhesh.
  • Fails CI/CD for 32-bit build.
• [v4,1/6] elf: Refactor dl_new_hash so it can be tested / benchmarked (Noah)
  • Needs review for performance and timing.
  • Open question about timing from Alexander Monakov:

    • https://sourceware.org/pipermail/libc-alpha/2022-April/138275.html

• [v2] Fix deadlock when pthread_atfork handler calls pthread_atfork or dlclose (Arjun)
  • Asking Adhemerval for review since he worked on the first patch.
• Optimize struct pthread size (Adhemerval)
  • Two patches. Carlos to review.
• Add arc4random support (Adhemerval)
  • Currently at v4.
  • Siddhesh raised questions about FIPS compliance.
    • Crypto stuff we add does not get exposed publicly as API.

    • No ChaCha20 API exposed then we should be OK.

    • Document in manual that arc4random is not intended for use in secure contexts.
    • Say "Not intended for cryptographic or security purposes."
  • v5 with manual change.
• 53091 libio: Remove _IO_adjust_column, _IO_adjust_wcolumn, column tracking
  • Review after "vfprintf rework to remove vtables"
• Stopped at 53091.
• Sunil: Raised issues about backporting to release/2.32/master.
  • Problems caused by the AMD patch backport.
  • Florian: Could revert the AMD backport and then layer everything properly.
  • Consensus to revert the AMD patch, and then layer the commits correctly.
  • Florian: Can push revert to a branch for 2.32.
• Florian: Would like to backport the dlinfo fixes.
  • Carlos: Only requires the addition of a header constant. OK with me.
• Remove kernel version and distinguish library check (Adhemerval)
  • Florian to review later this week.

• linux: Use /sys/devices/system/cpu on get_nprocs_conf (BZ#28991)

  • Needs a follow-on fix because of rseq.
  • Carlos: Is malloc affected?
  • Adhemerval: No, only the exported symbol is impacted.

Meeting: 2022-04-25 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• NEW/NOBODY is at 324 patches.
• Starting at 53184
• v4 Add arc4random support (Adhemerval) 53184

  • https://sourceware.org/pipermail/libc-alpha/2022-April/138132.html

  • Discussed arc4random support and Adhemerval's implementation.
  • Looking to get consensus from Florian Weimer.
  • Florian is the author of the previous attempt at an upstreamed impl.
  • Looking to decide as a community what direction we would go in.
• 53169 elf: Replace PI_STATIC_AND_HIDDEN with opposite HIDDEN_VAR_NEEDS_DYNAMIC_RELOC
  • Adhemerval to look at this.
• 53144 elf: Move post-relocation code of _dl_start into _dl_start_final
  • Adhemerval to look at this.
  • glibc lacks some clear distinctions around the loader startup.
  • Specific barriers are needed here.
• 53127 Support DT_RELR relative relocation format (HJ)
  • Pretty much done.
  • Try to remove configure knob on this - Turn on DT_RELR by default.
• 53117 INSTALL: Rephrase -with-default-link documentation
  • Carlos to respond.
• 53094 Fix deadlock when pthread_atfork handler calls pthread_atfork or dlclose
  • Failed CI: Bad test.
  • Arjun: Reviewing Adhemerval's patches for this.
  • Arjun: What is the consensus for prepare/after handlers added during the fork
    • in a handler? Should they just become something to use later?
  • Adhemerval: When you fork, you use the list as-is.
  • Arjun to post new version.
  • Arjun to add manual to document pthread_atfork
  • Arjun to investigate what to say to the austingroup.
    • "If any handler causes a handler to be registered to deregistered then the behaviour of the handler is implementation defined"
• Stopped at 53091.
• Args adjustment with ./ld.so exe [BZ #23293] (szabolcs)

  • https://patchwork.sourceware.org/project/glibc/list/?series=8562

  • Looking for review.
  • Szabolcs to look at adding a test case.
• Sunil: Backporting code into the release branches.

  • https://sourceware.org/pipermail/libc-alpha/2022-April/137718.html

  • Commit author remains the backpot author
  • Author remains the original commit author.
  • Cherry-pick -x notes the original commit.
• [v2,1/6] elf: Refactor dl_new_hash so it can be tested / benchmarked (Noah)
  • Asking for Florian to review.
• [v5] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868)
  • Siddhesh to review patch 51584.

Meeting: 2022-04-18 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

No meeting (Easter Monday).

Meeting: 2022-04-11 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• NEW/NOBODY 266 patches.
• Starting at patch 52775.
• ELF tests in Python and libio vtables/RELRO interaction (fweimer)
  • Needs review.
• [v4,1/6] x86: Remove {w}memcmp-ssse3 (noah)
  • Complaints about a specific machine was handled with reporter.
  • HJ to review.
• nptl: Handle spurious EINTR when thread cancellation is disabled (BZ#29029) (fweimer)
  • Debian has tested (Aurelien Jarno)
  • Florian wants to review this one given his state on the changes.
• [v2] math: Add math-use-builtins-fabs (BZ#29027) (adhemerval)
  • Needs review.
• manual: Avoid name collision in libm ULP table [BZ #28956] (Coldrick)
  • Carlos to push.
• [v1] sysdeps: Add 'get_fast_jitter' interace in fast-jitter.h (noah)
  • Jitter interface is for thread backoff.
  • This patch is for use by the in-progress changes to futex backoff.
• [v6] Add .clang-format style file (noah)
  • Looking for 1 review.
  • Carlos to review.
• [v3] elf: fixes compile error when both enable -Werror and -DNDEBUG (yang)
  • This needs the usual compiler pragmas to remove the unused warnings.
  • Carlos to respond.
• 52556-52525 posted fixes for fuzzing by Dmitry Chestnyh (omp.ru)
  • Discussing options for reviewing fuzz patches.
• 52304 - Superseded

• linux: Use /sys/devices/system/cpu on get_nprocs_conf (BZ#28991)

  • Still up for review (week 2).
• Refactor syslog implementation (adhemerval)
  • Just a refactor without timestamp change.
  • Improves code and testing.
• Stopped at 52087: vfprintf rework to remove vtables (fweimer).
• Florian: Discussed PT_GNU_RELRO and potential binutils issues with PT_LOAD alignment.
  • Final PT_LOAD doesn't start page aligned. Should it?
• Noah: Discussed improvements to symbol lookup.
  • Noted dl lookup function and strcmp on the hot path.
  • Florian: Pointed out we can precompute some of the math operations per linkmap.
    • Some of the math on these lookups can be stored.
  • Noah: Can we know that we aren't on a page boundary and use a distinct strcmp?
  • Carlos: You know DT_STRTAB and STRSZ and can do some figuring out.

Meeting: 2022-04-04 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• NEW/Nobody 260 patches.
• Starting review 52598
• [v3] elf: fixes compile error when both enable -Werror and -DNDEBUG
  • Needs different structure.
• Dmitry Chestnyh - Ran the static analyzer.
  • Need to follow up regarding assignment vs. DSO.
  • SVACE static analyzer results.
  • 12 patches need review.
• Discussed briefly that string tests are taking a long time.
  • What can we do to improve developer experience?
  • Note: Split the tests at the make target level with different args.
  • Note: Split the tests at the do_test level with different threads.
  • Noted that any split up should help but not solve.
• [v5] Add .clang-format style file
  • Carlos to review v5.
• Remove -z combreloc and HAVE_Z_COMBRELOC
  • Different from Adhemerval's branch to enable clang.
  • Needs review.
• elf: Simplify _dl_aux_init with inhibit_loop_to_libcall
  • Reviewed by Szabolcs. Needs fixes.
  • Adhemerval noted this can be fixed in a different way.
• 52433: [v6] Allow for unpriviledged nested containers (DJ)
  • Carlos to review.
• 52427: [v1,1/2] random-bits: Factor out entropy generating function
  • Needs review.
  • What is the status of Florian's arc4random?
• 52428: [v1,2/2] x86: Use rdtsc for generating entropy for random_bits
  • Needs review.
• Stopped at 52428.
• Florian has a vfprintf patch series reviewed.

  • https://patchwork.sourceware.org/project/glibc/list/?series=7969

  • Performance impact is very positive.
• Adhemerval wants LD_AUDIT trace fixed.
  • Florian really wants to review.

• linux: Use /sys/devices/system/cpu on get_nprocs_conf (BZ#28991)

  • Needs review.

• [v2] linux: Fix closefrom_fallback iterates until max int (BZ#28993)

  • How do we proceed? -- Should be OK to proceed to fail fast.
  • Will post v3.
  • What about ENOMEM?

Meeting: 2022-03-28 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• State NEW, delegate NOBODY is 312 patches.
• Adhemerval tries to push.

  "Enumerating objects: 1581, done.
Counting objects: 100% (1581/1581), done.
Delta compression using up to 24 threads
Compressing objects: 100% (807/807), done.
Writing objects: 100% (1093/1093), 162.32 KiB | 13.53 MiB/s, done.
Total 1093 (delta 950), reused 298 (delta 272), pack-reused 0
remote: Resolving deltas: 100% (950/950), completed with 415 local objects.
remote: *** This update introduces too many new commits (121), which would
remote: *** trigger as many emails, exceeding the current limit (100).
remote: *** Contact your repository adminstrator if you really meant
remote: *** to generate this many commit emails.
remote: error: hook declined to update refs/heads/azanella/clang"

• Carlos reviewed and it's max-commit-emails, which can be set to 1000 to avoid
  • this problem and allow you to publish a branch for review.
• [v2] nptl: Add backoff mechanism to spinlock loop (Wangyang Guo)
  • We can't use random-bits.h (30 cycles)
  • Can we use tid?
  • Can we use rdtsc? (18 cycles)
  • At least one microbench should be contributed.
• [v1,1/2] x86: Small improvements for wcscpy-ssse3 (Noah)
  • Waiting for feedback from Zhaoxin cpu discussion, see:

    • https://sourceware.org/pipermail/libc-alpha/2022-March/137354.html

• [v2,1/6] x86: Remove {w}memcmp-ssse3 (Noah)
  • HJ reviewing.
• rwlock for async application
  • This is an RFC for glibc to deviate from POSIX behaviour.
• Add HWCAP2_AFP, HWCAP2_RPRES from Linux 5.17 to AArch64 bits/hwcap.h (Joseph)
  • Accepted by Szabolcs [Arm]
• Note from Adhemvarl that POSIX will add strlcpy and strlcat
  • Prposed by Florian in 2016.

  • https://www.austingroupbugs.net/view.php?id=986

  • https://sourceware.org/glibc/wiki/strlcpy

• Stopped at 52304.
• realpath: Bring back GNU extension on ENOENT and EACCES [BZ #28996]
  • Adhemerval will review.
• [v5] Allow for unpriviledged nested containers
  • Adhemerval asking if we are going to accept this patch?
  • Carlos to review this to completion to unblock Adhemerval.

  • This blocks the syslog https://patchwork.sourceware.org/project/glibc/list/?series=8031

• Siddhesh notes that DNS tests no longer depend on proc mount.
  • However we still have tests that use DNS and can fail.
  • They need to be ported to use the in-process test DNS resolver or changed.
• Support DT_RELR relative relocation format review.
  • What is the status of DT_RELR for AArch64? Currently unimplemented.
  • Looking for review of v6 patches.
  • No technical blockers. Push April 11th if no further reviews.

Meeting: 2022-03-21 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• Carlos unable to start meeting until 930am due to technical issue.
• Discussed with Adhemerval patches with outstanding review.

Meeting: 2022-03-14 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 255 patches with NEW/NOBODY.
• getaddrinfo facelift and fixes (Sidhesh)
  • Some feedback from Carlos regarding DNS access.
  • Feedback from Andreas about example.org.
• [v5] Allow for unpriviledged nested containers (DJ)
  • Florian reviewing.
• [v6] Support DT_RELR relative relocation format (HJ)
  • Added for x86_64, ppc64le looking at this. What about others? (Adhemerval)
  • What about aarch64 and s390x? Other arches like RSIC-V?
  • Confirmed for 2.38 we have x86_64, ppc64, ppc64le.
  • Would be nice to have aarch64.

• scripts/dso-ordering-test.py: Fix C&P error in * callrefs processing

  • Adhemerval to review.
• [v5] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868)
  • Review from Florian?
• Remove kernel version and distinguish library check (Adhemerval)
  • Waiting for Florian to finish review.
  • Discussed that 4.9 is the oldest LTS kernel we could support.
  • No large benefit to move to 4.9 and it would cause downstream problems.
  • Relaxing the version check is a step forward.
• PowerPC64 static-pie (Alan Modra)
  • Tulio (IBM) to review.

• : C++20 P0482R6 and C2X N2653: support for char8_t, mbrtoc8(), and c8rtomb().

  • No review.
• [v4] localedata: Updates for Taiwanese locales [BZ #24409]
  • Carlos asking for split up and review.
• Use RFC5424 for syslog (Adhemerval)
  • Adhemerval: Need to review upstream systemd thread.
• linux: Add new syscalls
  • Added 12 syscalls.
  • Carlos: Do we need man pages for these?
  • Adhemerval: I think all of them have man pages.
  • man-pages currently slow to update.
    • Waiting for Alejandro to have access to tree?
• Predictable ELF destructor ordering
  • Florian to repost.

Meeting: 2022-03-07 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 260 patches in NEW/NOBODY
• [v5] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868)
  • Looking for review.
  • Florian will to review.
  • Backported just the fix downstream with no issues to report.
• Remove kernel version and distinguish library check
  • Adressed Florian's review.
• malloc: Exit early on test failure in tst-realloc
  • Need review.
• v5: Support DT_RELR relative relocation format (HJ)
  • No reviewer right now.
• v2: PowerPC64 static-pie
  • Tulio says IBM will review.

• C++20 P0482R6 and C2X N2653: support for char8_t, mbrtoc8(), and c8rtomb().

  • Still in the same position as last week.
• [v3] libio: Ensure output buffer for wchars (bug 28828)
  • Adhemerval reviewed.
  • Asked vor v4 with fixed tests.
  • Changes requested.
• Use RFC5424 for syslog (Adhemerval)
  • Some initial review from Paul Eggert.

  • https://github.com/systemd/systemd/issues/19251#issuecomment-817901396

    • This was the upstream conversation.
• linux: Add new syscalls (Adhemerval)
  • No reviewer yet.
• [v2] x86: Reformat code in svml_s_atanhf16_core_avx512.S
  • Noah submitted. Working with Sunil on this issue.
• v2: Predictable ELF destructor ordering (Florian)
  • Still looking for review.
  • Need to repost v3 after testing.
• [v2,1/3] x86: Optimize svml_s_tanhf_core_avx512.S (Noah)
  • Working with Sunil to reformat code before optimizing.
• Stopped at 50642.
• New DSO dependency resolver buggyness with dlclose()

  • https://sourceware.org/bugzilla/show_bug.cgi?id=28937

  • As serious as LD_TRACE_LOADED objects bug (Bug 28868) and needs fixing.
• Fixes for getnameinfo() with NI_NOFQDN (race condition)

  • https://patchwork.sourceware.org/project/glibc/list/?series=5655

  • Does any of this touch Siddhesh's getaddrinfo refactor? No. Unrelated.
  • Asked DJ for review of resource acquisition.
• Adhemeral discussed symbol redirection and usage in gcc and clang
  • Will need some changes to glibc's headers if we support clang as a compiler.
  • Need to discuss this on list with a plan.
  • Florian notes that this is a large project.

Meeting: 2022-02-28 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• NEW/NOBODY 262.
• PowerPC64 static-pie [v2 1/4-4/4]
  • Ask Tulio if he will review.

• : C++20 P0482R6 and C2X N2653: support for char8_t, mbrtoc8(), and c8rtomb().

  • Accepted by WG14. Needs review. Repost.
  • Needs a reviewer to look at this against the N2653 implementation requirements.
• [v4] localedata: Updates for Taiwanese locales [BZ #24409]
  • Carlos to look at this.
• benchtests: make compare_strings.py accept string as attribute value
  • Patch failed to apply (CI/CD caught this). Siddhesh will cleanup
• [v3] libio: Ensure output buffer for wchars (bug 28828)
  • Adhemerval reviewed the changes.
  • Adhemerval to respond again regarding test case.
• [v3] elf: Fix DFS sorting algorithm for LD_TRACE_LOADED_OBJECTS with missing libraries (BZ #28868)
  • Adhemerval need to rewrite the test case using Florian's suggestions.
• Remove distinguish library code (Adhemerval)
  • Drop kernel version check and drop arch review.
  • Florian to review.
• [v3] x86: Test wcscmp RTM in the wcsncmp overflow case [BZ #28896]
  • HJ reviewing.
• Use RFC5424 for syslog

  • https://sourceware.org/pipermail/libc-alpha/2021-November/132893.html

  • DJ needs to review.
  • New pid namespace means new proc instance.
  • Same pid namespace you can use a bind mount.
• Support DT_RELR relative relocation format
  • At v3. Latest version of binutils had DT_RELR support.
  • Note that Fedora Rawhide has binutils 2.38 and could be used to test DT_RELR.

Meeting: 2022-02-21 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• Discussed patches and how to make progress on them.

Meeting: 2022-02-14 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 284 patches in NEW/NOBODY.
• linux: Use socket-constants-time64.h on tst-socket-timestamp-compat
  • Carlos to review.

• x86-64: Define memcmpeq in ld.so

  • Noah reviewing.
• libio: Ensure output buffer for wchars (bug 28828)
  • Adhemerval reply to resend the patch.
  • Patrick: Was a whitespace issue. Lines that are not in the patch
    • all have extra whitespace.
• resolv: Fix tst-resolv tests for 2.35 ABIs and later
  • Adhemerval said he'd look atthis.
• rtld: Add new hook to initialize dp register on hppa
  • Reviews from Florian and HJ. Dave needs a v2.
• inptl: Use 64 bit time_t stat internally for sem_open (BZ #28880)

  • Notes that running on a system with future >64-bit time fails a lot of tests.

  • Need to go fixing these issues.
• Remove bcopy and bzero optimizations

  • HJ notes that rather than remove bzero we could rename to memset_zero

  • Note that memset_zero is not equivalent to bzero because of the return type.

  • Removing bcopy and bzero and replacing with memset_zero is arch specific.

  • Each maintainer needs to consider the memset_zero optimziation.

  • Carlos: Can we notify the arch maintainers before removal?
• Stopped at 51018.
• Support DT_RELR relative relocation format
  • HJ: Answered all of Joseph's comments.
  • Joseph was original reviewer.
  • Carlos to look at this on Friday.
• Florian: Patch for aux vector changes.
  • Consensus to push but needs future work.

Meeting: 2022-02-07 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• NEW / NOBODY patches 355.
• [v2] linux: fix accuracy of get_nprocs and get_nprocs_conf [BZ #28865]
  • Adhemerval to look at.
• [v2] hppa: Fix bind-now audit (BZ #28857)
  • Adhemerval to send v3.
  • Carlos to review as hppa maintainer.
• [v1] x86: Remove SSE3 instruction for broadcast in memset.S (SSE2 Only)
  • HJ provided feedback.

• elf: Replace memcmp with memcmpeq for variable size

  • Using memcmp_eq limits the compiler optimizations for size.
    • There is a tradeoff for size vs. speed.

• x86-64: Make bcmp an alias of memcmpeq

  • HJ will drop this.
  • Carlos will make a comment about bcmp.
• [v1] x86: Improve vec generation in memset-vec-unaligned-erms.S
  • Already committed.
• Support DT_RELR relative relocation format [v2]
  • Second version of DT_RELR.
• Improve LC_MONETARY handling.
  • Ask DJ for review.
• [v2] x86: Reformat code in svml_s_atanhf16_core_avx512.S
  • Sunil will review svml cleanups for reformatting.
• Remove prelink support [v2]
  • Siddhesh has started to review.
• linux: Add new syscalls
  • Carlos to review new syscalls.
• HJ: During the 2.35 release cycle we removed a p_align check.
  • elf: Check invalid hole in PT_LOAD segments [BZ #28838]
    • Needs review.
• Patrick: [v2] Remove upper limit on tunable MALLOC_MMAP_THRESHOLD
  • Cleaned up patch tracker state.
• Siddhesh ran cleanup for patches.
  • Cleaned up to 264.
• getaddrinfo: Fix leak with AI_ALL [BZ #28852]
  • May need a v2. Florian reviwed and asked for feedback.
• [v2] setlocale: Fail if iconv module for charset is not present [BZ #27996]
  • Siddhes to post v3.

Meeting: 2022-01-31 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

With the release upcoming we've switched to reviewing blockers and desirable changes.

• NEW/NOBODY 312 patches.
• Release planned for Wednesday February 2nd.
• MIPS _r_debug issues

  • https://sourceware.org/pipermail/libc-alpha/2022-January/135820.html

  • Needs fixing properly.
• MIPS pldd support for DT_MIPS_RLD_MAP_REL

  • https://sourceware.org/pipermail/libc-alpha/2022-January/135821.html

  • Needs fixing.
• MIPS issues all in one group.

  • https://sourceware.org/pipermail/libc-alpha/2022-January/135837.html

• posix_spawn_file_actions_addtcsetpgrp_np needs review.

  • https://patchwork.sourceware.org/project/glibc/patch/20220129200620.501423-1-adhemerval.zanella@linaro.org/

  • Florian to review v2.
• C.UTF-8 locale
  • Review Andreas Schwab's comments.
• HJ - Close to fixing the loader bug for invalid p_align
  • Considering to backport the p_align change to older releases.
  • We should fix this in 2.35.
  • Need an additional check for invalid objects.
• HJ - When I run the glibc testsuite on Alderlake
  • Opened bugs for those. They are test issues.
  • Use of a privileged instruction issue.
  • Processor feature detected by cpuid but is not reported by kernel.
  • 50466, 50467 patches.
• CI/CD - tst-21269 hangs on i386

  • Discussion: https://sourceware.org/pipermail/libc-alpha/2021-July/128853.html

  • We should fix this.

Meeting: 2022-01-24 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

With the release upcoming we've switched to reviewing blockers and desirable changes.

• Review the release blockers for glibc 2.35.
• PT_LOAD fix status?
  • Committed fix e22a4557eb39d7cba9a74d70f4582c13f1a7a83a
  • Adhemerval reviewing test case inclusion.
• Fix glibc 2.34 ABI omssion.
  • HJ: Is there a missing linker feature here?
  • Discussed Solaris VER_FLG_WEAK

    • https://sourceware.org/pipermail/libc-alpha/2021-December/133796.html

• linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ #28350)
  • Florian sent review.
  • Adhemerval reposted patches with fixes.
• posix: Add terminal control setting support for posix_spawn
  • Carlos to post review ASAP.
• Multiple RTLD audit fixes.
  • Adhemerval sent updated versions.
  • Carlos to look at the fixes.
• Use after free warning failures in gcc 12.
  • Carlos to follow up with Martin Sebor.
• IBM long-double issues are release blockers we aren't tracking yet.
  • Blocks Fedora Rawhide builds.
  • We need to disable the flag in more places.
  • Florian to post the patches for this today.
• Szabolcs: p_align issue.
  • Binutils switching on x86 to set p_align of load segments.
  • On AArch64 it would be nice too.
  • Old glibc would reject such a binary on a 64k page system.
  • Seems to me that I cannot switch this if there are existing 64k page sized systems.
  • Florian suggests fixing the bug in glibc and backport to old releases.
  • Carlos agrees with backport.
• Adhemerval sent prelink removal patch for glibc 2.36.
  • Carlos: Post a NEWS update with a note saying 2.35 is the last relase with prelink.

Meeting: 2022-01-17 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

With the release upcoming we've switched to reviewing blockers and desirable changes.

• NEW/NOBODY 290 patches
• [v7] elf: Properly align all PT_LOAD segments [BZ #28676]
  • Adhemerval to review alignment patch.
• linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ #28350)
  • Florian to review.
• posix: Add terminal control setting support for posix_spawn
  • Carlos to finish review Monday.
• Multiple rtld-audit fixes
  • Adhemerval to rebase patch set.
  • Szabolcs looked at the aarch64 pieces and gave feedback.
• Properly handle --disable-default-pie
  • Siddhesh is going to look at this.
• Carlos and Adhemerval discussed 64-bit time_t testing.
  • No way to change library default time_t size, just testing can test it.
• Prelink discussion
  • Adhemerval: May I submit patches to remove prelink?
  • Carlos: Yes.
  • Discussed Intel, Arm, Linaro involvement in prelink.
  • Carlos: IHVs and ISVs need to invest upstream if they want to see prelink maintained.
• Paul sends his regrets and includes two items:
  • I have done a review of the accuracy of the libmvec functions (in master)
    • both with sse4.2, avx2 and avx512. Apart from a minor issue with atan2 in binary64 which was fixed (#28765), I found no error larger than 4 ulps, both in binary32 and binary64.
  • We are making good progress in the CORE-MATH project: 17 out of 26
    • functions are now available in single precision (binary32).

      See https://homepages.loria.fr/PZimmermann/CORE-MATH/. In most cases the correctly-rounded CORE-MATH code outperforms the GNU libc one (see the "perf" graphs). The only exceptions so far are the cosf function on i7, and the expf function.

Meeting: 2022-01-10 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

With the release upcoming we've switched to reviewing blockers and desirable changes.

• Discuss release blockers for glibc 2.35.
• Properly align all PT_LOAD segments with tests (v7)

  • https://patchwork.sourceware.org/project/glibc/list/?series=6100

  • Florian will look again at v7.
• [v2] math: Fix float conversion regressions with gcc-12 [BZ #28713]

  • https://patchwork.sourceware.org/project/glibc/list/?series=6114

  • Review from Paul, and Joseph. Joseph's feedback incorporated.
  • Carlos recommends pushing fix at this point.
• Fix glibc 2.34 ABI omission (missing GLIBC_2.34 in dynamic loader)

  • https://patchwork.sourceware.org/project/glibc/list/?series=5581

  • Florian to ping Andreas again pointing at previous justification.
• elf: Fix 64 time_t support for installed statically binaries

  • https://patchwork.sourceware.org/project/glibc/patch/20211229132711.3324972-1-adhemerval.zanella@linaro.org/

  • Carlos to review.
• [v4] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ #28350)

  • https://patchwork.sourceware.org/project/glibc/patch/20211222185239.1088511-1-adhemerval.zanella@linaro.org/

  • Florian to review.
• _FORTIFY_SOURCE fixes [BZ #28746]

  • https://patchwork.sourceware.org/project/glibc/list/?series=6132

  • Siddhesh to send out v3.
  • Adhemerval will review v3.
• [v5] posix: Add terminal control setting support for posix_spawn

  • https://patchwork.sourceware.org/project/glibc/patch/20211223173003.1037286-1-adhemerval.zanella@linaro.org/

  • Adhemerval: Would really like this to be released in 2.35.
  • Perfectly possible to use fork but it has issues for performance on Linux.
  • This removes the race condition.
  • Carlos to review.
• Multiple rtld-audit fixes

  • https://patchwork.sourceware.org/project/glibc/list/?series=6085

  • Adhemerval: Would be better to have this in 2.35.
  • Florian to look at the added audit version check.
  • Szabolcs to look at aarch64 audit changes.
• Desirable for the release?
  • Predictable ELF destructor ordering

    • https://patchwork.sourceware.org/project/glibc/list/?series=5764

    • Carlos to review for 2.35.
    • Suggestion from Adhemerval about ldd output being in constructor ordering.
      • Florian will review ldd output ordering.
• Go through atteendees to review patches they need review for.
• HJ: Working on DT_RELR for binutils 2.38 (end of January)
  • Compact relative relocations. Implemented for x86_64 and i386.
  • Outstanding issue is what symbol name do we want to identify the support.
  • CC'd libc-alpha mailing list with suggestion: GLIBC_ABI_DT_RELR.
    • Need a decision on symbol name for end of January for binutils 2.38.
    • Code freeze 22nd of this month.

Meeting: 2022-01-03 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

Meeting: 2021-12-27 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

Meeting: 2021-12-20 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

Meeting: 2021-12-13 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• Carlos asks what are we looking at putting into the release.
• Adhemerval:
  • Would like to get hugepage support into 2.35.
    • Siddhesh: Reviewed the last patch set.
    • Huge page support aligns with what we are doing with the text segment
      • Makes it easier to support THP with .text.
  • Carlos: What is the status of the LD_AUDIT series?
    • Adhemerval: Florian has reviewed half of the patches.
    • Florian: Ran out of time last week. I should be able to review this week.
• Florian:
  • _dl_find_object needs review.
    • Adhemerval: Will review.
  • Minor fix to rseq. No ABI implications.
    • Removes not-needed relocations.
  • Add membarrier support (syscall wrapper)
    • Need to do some digging for programming model.
    • May be an additional step required for membarrier setup.
• HJ:
  • libmvec patches are very large (42 patches)
    • Submit one function. Work with community to address concerns.
      • If the community agrees with the approach then the rest of the patches can be automated and ready.
    • Intent is to include the functions in 2.35.
  • DT_RUNPATH v3 posted.
    • Carlos to review v3.
• Sunil:
  • libmvec needs review.
    • CFI escape? Compiler generated. Encodes the DFA expression.
      • Can we remove it? What are they?
• Siddhesh:
  • No additional reviews required.
• Szabolcs:
  • No additional patches for review.
• Carlos:
  • pthread cond var fix and review. Bug fix.
  • Licked the cookie. MUST BE FIXED.
• Series 5728: Fix 64-bit time_t ancillary socket conversion
  • Posted v3. Needs review from Florian.
• Series 5725: [v4] elf: Add _dl_find_object function
  • Adhemerval to review.
• Series 5714: fix p_align on PT_LOAD segment in DSO isn't honored
  • Checked in.
• Series 2348: [v2] Use LFS and 64 bit time for installed programs (BZ #15333)
  • Needed.
• Discussed alignment issues with some architectures from the PT_LOAD changes.
  • Still need this if p_align is large.
  • We can solve this in the loader.
  • Once we fix hte linker the normal binary will have 4KiB p_align.
  • Will only get the large alignment if we have a variable that needs it.
  • For huge page we still want the large p_align even if there is no variables.
  • TODO: Must fix unmapping for 2.35.
• Series 5703: intl/plural.y: define macros to avoid multiple conflicting declarations of yyerror and yylex
  • Ask Arjun to review this change.
• Series 5688: [v3] Support target specific ALIGN for variable alignment test [BZ #28676]
  • Needs review.
• Series 5695: [v7] elf: Don't execute shared object directly [BZ #28453]
  • Needs review.
• What is the state of the OpenRISC or1k port?
  • Joseph has reviewed some of the state.
  • Is this ready for glibc 2.35?
  • State of the port is looking good.
  • Need to check build-many-glibcs and with Jospeh for the state of the port.
  • Doesn't look like there are any large blockers for 2.35.
• New ld sort algorithm is failing on OpenRISC.
  • Needs review.
• New ld sort default should be flipped to new algorithm.
  • Need to flip the new sort.

Meeting: 2021-12-06 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

Meeting: 2021-11-29 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

Meeting: 2021-11-22 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 306 patches in NEW/NOBODY
• linux: Add generic ioctl implementation
  • Needed for ork1 port.
• linux: Add generic syscall implementation
  • Needed for ork1 port.
• Add GLIBC_PRIVATE_RELR as proxy for DT_RELR
  • What about toolchains that don't use symbol versions?
  • Why does *_RELR exist in the name?
  • Is Google going to rebase 2.27 to a more current version?
  • Ask Chrome OS developers?
  • Ask Google server branch developers?
  • What will be the generic ABI mechanism for feature lockout?
    • Does this impact the decisions we make?
    • The BSDs don't view it as an issue overall
      • Except that if we decide on this markup they may need to change things.
  • Context: Just glibc. Parallel feature lockout via symbol@version.
    • Add linker support for empty node.
    • Use dummy symbol in glibc.
  • Add concrete semantics to that version.

Meeting: 2021-11-15 @ 0900h EST5EDT

Cancelled.

Meeting: 2021-11-08 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• State NEW, Delegate Nobody, 289 patches.
• 47212: io: Refactor close_range and closefrom
  • Adhemerval: Pointed out a discrepancy for patch review and refactoring.
• 47211: powerpc: Define USE_PPC64_NOTOC iff compiler and linker also supports it
  • Adhemerval: These are further fixes for lld. Discussing with IBM.
• Discussed the current gABI issues that relate to ensuring that old ld.so
  • can safely fail when new binaries are run on old system.
  • Waiting for Cary Coutant to publish the gABI repo.
• Series 4535: Update Makefile fragments for DSO sorting tests
  • Florain: Needs changes. Post v2.
• 47161: Remove the unnecessary +make-deps
  • Needs review.
• 47065: powerpc: Use FLAG_ELF_LIBC6 for 32-bit known libraries
  • Needs review from Florian or Tulio.
• 47064: Fix memmove call in vfprintf-internal.c:group_number
  • Florian: Given that I produced the bug I should review it.
• 47061: [v3] x86: Optimize atomic_compare_and_exchange_[val|bool]_acq [BZ #28537]
  • Needs review.
  • Carlos: As x86 maintainer you could just wait and push. There is a lot of internal CPU details that this depends upon.
  • Carlos: We need a comment here to expalin the redundant read.
• 47048: [v2] elf: Use the minimal malloc on tunables_strdup
  • Siddhesh should review.

• https://sourceware.org/pipermail/libc-alpha/2021-November/132688.html

  • Florian needs review.
• Adhemerval: 64-bit time_t recvmsg review.
  • Florian: Assign that to me for review.
• Florian: May you please repost your LD_AUDIT patches? (to Adhemerval)

Meeting: 2021-11-01 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• State NEW, Delegate NOBODY, 317 patches.
• Series 4330: Enable EVEX strcmp
  • Carlos noted that with Noah and HJ working together this is enough review
    • along with the microbenchmark to commit this code.
• Series 4329: Fix lld build for armhf
  • HJ: Binary with ARM_EXIDX inbetween to relocation sections looks odd.
  • We fixed a similar issue with fa19d5c48a6b36518ce68412e3bdde6bfa8aa4a6.
  • Rewrite as cleanup and provide timing cycle information.
• Series 4318: [v1,1/5] string: Make tests birdirectional test-memcpy.c
  • HJ to review.
• Series 4294: benchtests: Add atan2f, expm1f, log1pf and tanf to bench-math (4 patches)
• Series 4292: benchtests: Add float version of math functions to bench-math (12 patches)
  • Convert double input to float input.
• Series 4208: regex: Unnest nested functions in regcomp.c
  • Carlos to look at it.

• 46656: [PiNg,9] localedata: add new locale ab_GE

• 46551: powerpc: Use the correct flag for 32-bit known libraries
  • Needs a new commit message.
• 46481: manual: remove an obsolete requirement on aligned_alloc() usage
  • Status? Suggest version the interface, return error without alignment.
• Enable hard-coded path in tests.
  • 46294: elf: Also try DT_RUNPATH for internal dlopen [BZ #28455]
  • 46295: Add and use link-test-modules-rpath-link [BZ #28455]
  • Carlos to review.
• Series 2732: malloc: Improve Huge Page support
• Maxim Kuvyrkov attended. Hello Maxim!
  • Linaro looking at benchmarking toolchains.
  • Patrick: libmicro has many mirobenchmarks.
  • Stream benchmarks were showing regression for the L3 memcpy issue we fixed before.
  • It is very important that you must find the patch that makes the change.
  • We are doing post-commit testing.
  • Pre-commit testing is the point where it is easiest to prevent a patch going.

Meeting: 2021-10-25 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• State NEW, Delegate NOBODY, 304 patches.
• Series 4140, Improve hypot(), Adhemerval to rebase.
  • Needs rebase after HJs benchtests/Makefile change.

• Series 4116, [v14,1/4] String: Add support for memcmpeq() ABI on all targets

  • Looks OK.
• Series 4105, powerpc: Use the correct flag for 32-bit known libraries
  • This looks like old a.out code is blocking this.

  • Carlos & Florian to bring up with IBM.

• Series 4101, Add missing math functions to benchtests (Sunil Pandey)
  • Adding functions to libmvec
  • Adding benchmark data for existing libmvec functions.
  • For each function we have both double and float.
  • In order to generate the microbenchmarks for float we need float and double.
  • Sunil copied the input from double to float.
• Series 4056, manual: remove an obsolete requirement on aligned_alloc() usage
  • Carlos to ask Martin Sebor.
  • Update 2021-10-25: Asked Martin for comment.

  • https://patchwork.sourceware.org/project/glibc/patch/33ec9e0c1e587813b90e8aa771c2c8e6e379dd48.camel@posteo.net/

• Series 3961, [PING,8] localedata: add new locale ab_GE
  • First issues: No feedback from Rafal and Mike (other locale maintainers).
  • Second issue: Consensus on header.
    • Carlos to respond on the second issue with new thread.

    • https://sourceware.org/pipermail/libc-alpha/2021-September/130692.html

• Series 3949, regex: fix buffer read overrun in search [BZ#28470]
  • Stuck on review. Needs v2. Marked Changes Requested given Andreas' comments.
• Series 3941, Benchtests: Improve bench-memcpy-random
  • Siddhesh to look at improvement and reveiw.
• Series 3895, [v2] elf: Support DT_RELR relative relocation format [BZ #27924]
  • Unknown dynamic tags are ignored by old glibc.
    • Old glibc must fail when running the new binary.
    • Need to add symbol dependency or bump ELF OSABI.
  • lld is there for review, but additional patches are needed to build glibc for tests.
    • More work is required in the tree to get lld working.
    • If the testsuite fails to build we can't talk about regressions easily.
    • What is the status of lld building with glibc?
      • Carlos: Ask on thread about status of lld to build glibc.
• HJ: Testing gcc with glibc 2.34 issues.
  • Sanitizer libraries has a hack that they assume dlsym malloc is always freed.
    • In glibc 2.34 in dlsym we do 2 mallocs and then do 2 frees. Hack doesn't work.

  • https://bugs.llvm.org/show_bug.cgi?id=52278

• Adhemerval: 64-bit time_t receive message fix.

  • https://patchwork.sourceware.org/project/glibc/list/?series=3280

Meeting: 2021-10-18 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 339 NEW/NOBODY patches in queue.
• [v2] elf: Support DT_RELR relative relocation format [BZ #27924]
  • Need official gABI assignment (Carry Coutant status?)
    • Needs to be reserved verbally by Carry (Action item)
    • Required for patch acceptance.
  • Need BFD port or a released llvm/lld that supports DT_RELR to review patches.
    • Minimally a 32-bit and 64-bit port that can build glibc and passes regression testing.
    • Required for patch review.
  • Official glibc relese with feature?
    • Need BFD port to support build-many-glibcs to provide testing confidence.
  • HJ: Would like to see a BFD port before a glibc release with the features.
    • Sufficient to have a released binutils with DT_RELR also.
  • Release date of released static linkers with support should be close to glibc release with feature.
    • When glibc is released users can pick a static linker to test with (binutils or lld).
• 317 NEW/NOBODY patches in queue.
• Add and use link-test-modules-rpath-link [BZ #28455]
• elf: Also try DT_RUNPATH for internal dlopen [BZ #28455]
  • Needed for change in linker default.
• elf: Make global.out depend on reldepmod4.so [BZ #28457]
  • Existing defect.
• 46290: elf: Fix elf_get_dynamic_info() for bootstrap
  • Needs review.
• 45506: [v2] ld.so: Initialize bootstrap_map.l_ld_readonly [BZ #28340]
  • Needs review to fix valgrind issue with ppc64le.
• _FORTIFY_SOURCE=3 improvements
  • Siddhesh looking for review.
• Series 3601: Improve hypot()
  • Changes requested by Paul Zimmerman.

Meeting: 2021-10-11 @ 0900h EST5EDT

Cancelled.

Meeting: 2021-10-04 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 398 patches in the NEW/NOBODY queue.
• H.J:
  • Most of the patches are in, there are 2 ones that need review:
    • Remove copy relocations: rquires linker, compiler, and runtime changes

      • https://patchwork.sourceware.org/project/glibc/patch/20210803215914.4170913-1-hjl.tools@gmail.com/ and https://patchwork.sourceware.org/project/glibc/patch/20210803215914.4170913-2-hjl.tools@gmail.com/

    • https://patchwork.sourceware.org/project/glibc/patch/20210924165338.2326917-2-hjl.tools@gmail.com/

      • Two issues: we don't need an API, we can use the syscall directly
      • Multiple users results in UB, so glibc acts as a gatekeeper
      • Hard to backport, so the patch adds no new symbol
      • Szabolcs is not sure if the rigth direction
        • Existing code which does something with pointer tag bits and make code incompatibility.
      • H.J pointed that a internal LAM branches fixes it.
        • These are independently of the LAM glibc API.
      • H.J will send examples on how to use this API
• Szabolcs:
  • elf: Avoid deadlock between pthread_create and ctors [BZ #28357]
  • Backport to 2.34
• We didn't make any patchwork evaluation.

Meeting: 2021-09-27 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 365 patches in the NEW/NOBODY queue.
• 45462: [PING,5] localedata: add new locale ab_GE
  • Need to review the reviewers position on copyright/license text.

  • https://sourceware.org/pipermail/libc-alpha/2021-September/130692.html

• 45457: linux: Fix a non-constant expression in _Static_assert
  • Accepted. Under review from Paul Eggert.
• [v1,1/3] benchtests: Add medium cases and increase iters in bench-memset.c
  • Should be looked at by H.J. for correctness.
  • Results attached. Look OK.
• 45437 [powerpc] Fix unrecognized instruction errors with recent binutils
  • Is this a binutils bug?
  • Paul should commit. What review is he expecting?
• 45436 puts: indentation
  • Florian to follow up.
• 45434 pthread/tst-cancel28: Fix barrier re-init race condition
  • Adhemerval has this on his list.

• 45430 elf: Add libc_get_static_tls_bounds [BZ #16291]

  • Outstanding question from Florian.
• 45429 [v3] elf: Avoid nested functions in the loader (all ports) [BZ #27220]
  • Complexity looks reasonable.
  • No global data introduced.
  • Should we test on hppa and ia64?
  • Florian: Will test ia64.
  • Adhemerval: Will test hppa.
• Down to 344 patches.
• 45423 Disable symbol hack in libc_nonshared.a
  • Florian to ACK. Agreement that it looks correct.
• 45422 [v2] i386: Port elf_machine_{load_address,dynamic} from x86-64
  • Accepted by HJ
• 45407 powerpc: Delete unneeded ELF_MACHINE_BEFORE_RTLD_RELOC
  • Accepted by Rafael
• Break to review status from meeting participants.
• Siddhesh: Inputs to math benchmarks?
  • Paul Z. wanted to add an extra sets.
  • Agreed that workloads could be added.
• 44622 [v3] Fixed inaccuracy of j0f (BZ #28185)
  • Carlos to review.
• Patrick: Recommend that new users should login to patchwork because
  • you can't set your settings until you have a login.
  • Carlos will amend wiki with notes.
• Patrick: Is OFTC #glibc used for hte review meeting?
  • Carlos: It can be used if you want. It is the official IRC, and we will
    • discuss patch review via IRC.
• Florian: 3 things to raise.
  • opensock problem with the race.
    • 4 address families, and remove unused code.
  • recvmsg emulation code is non-functional for time64
    • systemd/qemu reported problem.
    • Some callers expect you can use a very tightly sized buffer.
    • Not enough space and this breaks.

    • See: https://sourceware.org/bugzilla/show_bug.cgi?id=28350

    • See: https://sourceware.org/bugzilla/show_bug.cgi?id=13500

  • getaddrinfo crash, dns related, reported on launchpad tracker.
    • There are no packet captures.
    • Looks like a real problem.

    • https://bugs.launchpad.net/bugs/1945072

• Adhemerval:
  • Audit patch set: Carlos: Yes, trying to get reviews.

  • sort: https://patchwork.sourceware.org/project/glibc/list/?series=2745

    • What do we do about malloc?
    • Change in algorithm?
      • Yes, the performance is different.
      • We use quicksort instead of mergesort.
      • Use intrasort to avoid quadratic worse case.

    • https://sourceware.org/pipermail/libc-alpha/2021-September/130698.html

  • Looking for comments on the series.

Meeting: 2021-09-20 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 341 patches.
• This week is busy with GNU Tools track at LPC.
• The sysconf fixes are reviewed by Florian.
  • Change request for test case and commit.
  • Fedora 35 has downstream copy in testing.
• The pthread_kill ESRCH vs. old applications (steam)
  • Rebase before working on the sysconf changes.
• Carlos still looking at pthread cond var.
  • Next week due to LPC/GNU Tools track.
• Adhemerval reviewed dynamic loader patches.
  • Adhemerval reviewed RTLD_SHARED
  • Adhemerval reviewed loader optimization for shared libraries.
  • Carlos suggests sending Vivek and Chung-Lin direct email to discuss progress on patches.
• LD_AUDIT series is still up for review.
• Florian posted a fix for the aarch64 BTI build failure.

  • https://patchwork.sourceware.org/project/glibc/patch/87h7ef4hu2.fsf@oldenburg.str.redhat.com/

  • Szabolcs to review.
• Discussed extra build-many-glibc target for patch testing AArch64 + PAC + BTI.
• Review for pthread_mutexattr_*

  • https://patchwork.sourceware.org/project/glibc/patch/87fsuhydom.fsf@oldenburg.str.redhat.com/

  • Carlos to review.
• [v3] Fixed inaccuracy of j0f (BZ #28185)

  • https://patchwork.sourceware.org/project/glibc/patch/20210810071218.1585625-1-Paul.Zimmermann@inria.fr/

  • Put value of the input, which is wrong, and needs fixing.
• Locking issues with TLS and dlopen/pthread_create to sync TLS setup.

  • https://sourceware.org/bugzilla/show_bug.cgi?id=19329

  • Except in dlopen we need to take a lock around a particular area.
  • dlopen can exit on failure, and need to make sure lock is unlocked in failure.
    • Code for this is ugly.
  • Szabolcs to create new bug.
• HJ's r_debug patches started going into the branch.

Meeting: 2021-09-13 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 334 patches to review.
• 44860 [v2] nptl: Fix type of pthread_mutexattr_getrobust_np, pthread_mutexattr_setrobust_np (bug 28036)
  • Carlos will review.
• Florian got feedback on pthread_cancel ESRCH changes.
  • Pushed to master and relase/2.34/master.
• sysconf revert patches?
  • Florian reviewed the patches.
  • Final patches have some issues in the test case.
  • The rest is OK.
• Siddhesh has a couple of locale realted patches that need review.
  • 44430 - v2 setlocale needs review (codonell)
  • 44607 - iconvconfig: Fix behaviour with --prefix [BZ #28199] (arjun)
• Carlos to raise locale source file header review with Mike Frysinger.
  • Attempt to get consensus on default headers to use.
• Szabolcs: No patches, but regression report of the latest glibc release has dynamic tls fixes.
  • Introduced a new lock in pthread_create.
  • Florian: Can we get a new lock?

  • The problem: Thread A: rtld lock -> user lock, B: user lock -> rtld lock. Deadlock.

  • https://sourceware.org/bugzilla/show_bug.cgi?id=15686

    • Fix for dyanmic tls bug fix regression.

  • Report: https://sourceware.org/bugzilla/show_bug.cgi?id=19329#c39

• Carlos is looking to review 2767

  • https://patchwork.sourceware.org/project/glibc/list/?series=2767

  • Reports that dotnet runtime is impacted by this on Linux.
• C.UTF-8 is in master, but will not be backported to release/2.34/master due to distribution impact.
  • Distros can either pick it up manually, or when 2.35 releases.
• RISC-V looking at extending this to 4K vector.
  • Arm SVE is passing down linked-list kind of structure that links up the extensions.
  • Kernel dumps register states on the stack.
  • Headers point to extra register state.
  • AT_MINSIGSTKSZ is used there.
  • Florian will post a note about the Arm SVE case as an example to review.
• 44926 - [v9,1/1] Extend struct r_debug to support multiple namespaces [BZ #15971]
  • Florian to review.
• 44924 - [v2] posix: Fix attribute access mode on getcwd [BZ #27476]
  • Florain to review (since he reviewed v1)
• 44897 - Add MADV_POPULATE_READ and MADV_POPULATE_WRITE from Linux 5.14 to bits/mman-linux.h

  • https://patchwork.sourceware.org/project/glibc/patch/alpine.DEB.2.22.394.2109072123510.1731265@digraph.polyomino.org.uk/

  • Asking DJ for review.
• 32-bit Arm atomic issue.

  • https://sourceware.org/pipermail/libc-help/2021-September/006004.html

  • Needs resolving in atomic.h.
• Stopped at 44884.

Meeting: 2021-09-06 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• Reviewed status of pthread_cancel ESRCH patches.
• Looked at sysconf revert. Adhemerval reviewing.

Meeting: 2021-08-30 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 323 patches
• Source attribution cleanups, series 2700 (Carlos to review)
• [v2] setlocale: Fail if iconv module for charset is not present [BZ #27996]
  • Carlos to review.
• HJ would like to move forward with debug interface.
  • Current version is at v5.
  • Series 2714, Extend struct r_debug to support multiple namespaces
  • Noted various ld.so bugs:
    • Bug 27609.

      • https://patchwork.sourceware.org/project/glibc/patch/20210817184546.3330651-1-hjl.tools@gmail.com/

    • elf: Copy l_addr/l_ld when adding ld.so to a new namespace

      • https://patchwork.sourceware.org/project/glibc/list/?series=2675

  • All 4 patches should be reviewed by Florian.
  • Note: Do not want to change symbol size.
    • Used a symbol alias for this.
    • First: generate assembly code, include assembly, place symbol alias after.
• Do we have a template for new locales not under FSF copyright assignment?
  • Carlos: No we don't have a template. Please propose something.
• Some rtld-audit fixes (Series 2577)

  • https://patchwork.sourceware.org/project/glibc/list/?series=2577

  • Looking for reviewer.
  • v3 has the aarch64 fixes.
    • Ask Szabolcs to review aarch64.
• glibc 2.34 suffers a spurious fail for pthread_cancel/pthread_kill
  • Looking at two approaches:
    • Adhemerval's fixes for glibc 2.35
    • Florian's approach for backporting to 2.34
  • What about the pthread self-kill signal case.
    • Can the kernel deliver all the signals?
    • Why is this required?
• C.UTF-8 v8 - Carlos to review.
  • Cleanup the files to make them iso-8859-1/iso-8859-15
    • Use octal sequences

• Review: https://patchwork.sourceware.org/project/glibc/list/?series=2728

• Alredy reviewed: https://patchwork.sourceware.org/project/glibc/list/?series=2723

  • Push?

• Under review: https://patchwork.sourceware.org/project/glibc/list/?series=2716

  • HJ looking to RCA. First 4 patches OK.

• Is this needed? https://patchwork.sourceware.org/project/glibc/list/?series=2713

• Needs v4 - https://patchwork.sourceware.org/project/glibc/list/?series=2711

• Stopping at 44766

Meeting: 2021-08-23 @ 0900h EST5EDT

Cancelled.

Meeting: 2021-08-16 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• Upstream patches 271 (New/Nobody)
• Namespace patch with glibc/binutils/gdb and r_debug
  • Discussed keeping r_debug and bumping r_version
  • Export r_debug_v2 only via DT_DEBUG
• v2 version of glibc change for removing COPY relocations.

  • https://patchwork.sourceware.org/project/glibc/list/?series=2595

  • Needs review from the community.
• Add THP support in glibc's malloc

  • https://patchwork.sourceware.org/project/glibc/list/?series=2660

    • Looking for architecture feedback.
    • Looking for Distro feedback.
  • Enable madvise syscall after successful mmap
  • How do we get feedback from the workload testing?
  • What about MADV_FREE?
    • Not reviewed, but could be related.
  • What about heap_trim? malloc_trim?
  • Can have a follow-up patch to directly use huge pages.
  • On some workloads THP needs a lot of tuning.
    • Can we provide a THP pool?
    • Be as simple as possible.

Meeting: 2021-08-09 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• Upstream patches 298
• LD_AUDIT patches still need review.

  • https://patchwork.sourceware.org/project/glibc/list/?series=2577

  • 20 patches.
• NPTL fixes.

  • https://patchwork.sourceware.org/project/glibc/list/?series=2304

  • 5 patches.
• Debug Interface Problems.
  • Do not support _r_debug in executable.
  • Use DT_DEBUG in dynamic executable.
  • In static executable use _r_debug.
    • Need to remove dlopen from static exectuable
    • Would need to remove dlopen.
    • New dynamic tag.
      • DT_DEBUG_DLMOPEN
        • glibc should not support dlopen in static exectuables
          • Therefore _r_debug should not be there.
        • Have you reviewed Daniel Walker's fixes?

          • https://patchwork.sourceware.org/project/glibc/list/?series=550

          • Ask for direct feedback on MIPS vs other status.

Meeting: 2021-08-02 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 304 patches to review.
• Audit patch series needs review:

  • https://patchwork.sourceware.org/project/glibc/list/?series=2577

• CI/CD failure that is expected to work:

  • https://patchwork.sourceware.org/project/glibc/patch/20210719163846.2954193-5-adhemerval.zanella@linaro.org/

  • Carlos to raise with DJ.
• 64-bit time_t tests improvements

  • https://patchwork.sourceware.org/project/glibc/list/?series=2510

• Next release for glibc 2.35 - Two big items.
  • Removal of _r_debug
    • _r_debug exported for debugging (Bug 28132)

      • https://patchwork.sourceware.org/project/glibc/list/?series=2585

      • Do we want to support _r_debug in static exectuables?
  • Proposal how to fix things to fix dlmopen debugging.
  • Deprecate COPY relocation?
    • Provide option to deprecate COPY relocation.
    • Issue open at the ABI level.
      • Security and performance concerns.
    • Changes for binutils, gcc, and glibc.
• Also we have dlmopen with RTLD_SHARED

  • https://patchwork.sourceware.org/project/glibc/list/?series=2451

• Copy benchtests to different machines

  • https://patchwork.sourceware.org/project/glibc/list/?series=2579

  • Carlos to review.
• Need LAM / TBI review to get API consensus
  • HJ to post for review. Florian raised issues for review.
  • Tag bits in the middle?
• Paul Zimmerman to review accuracy of glibc against other libraries.
  • Update to report for glibc 2.34.
• Static analysis fixes

  • https://patchwork.sourceware.org/project/glibc/list/?series=2555

  • Arjn to review.
• Carlos to review these for Siddhesh:

  • https://patchwork.sourceware.org/project/glibc/patch/20210722132430.1945153-1-siddhesh@sourceware.org/

  • https://patchwork.sourceware.org/project/glibc/patch/20210722132457.1945231-1-siddhesh@sourceware.org/

  • https://patchwork.sourceware.org/project/glibc/patch/20210720023658.1278155-1-siddhesh@sourceware.org/

• In glibc 2.35 Szabolcs will look at MTE and tagged address things.
  • I don't think it will be easy.
  • Some problems exist with arbitrary tagged address.
  • Pointers with arbitrary tags.
  • Pointer comparison doesn't work.
    • Pointer equality fails. User error?
  • Will start discussion upstream.
  • Will look at additional hardware features related to longjmp
    • Data versioning with notes.
• Robbie Harwood's patch needs committing

  • https://patchwork.sourceware.org/project/glibc/patch/20210728182331.1363922-1-rharwood@redhat.com/

Meeting: 2021-07-26 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• 272 patches.
• Short meeting review of the oustanding patches to review.

• https://patchwork.sourceware.org/project/glibc/list/?series=2507

  • Of the audit fixes we want to review one.
  • Regression: elf: Fix audit regression
  • Florian: Will review first patch in series.
• Florian to review C.UTF-8 patches
  • Preparing for another mass rebuild with the patches.
• HJ discovered performance regression on memmove/memcpy
  • Regression in workaround for Skylake server.
  • Implemented a fix. Fix is tested
  • Patches sent out this morning:

    • https://patchwork.sourceware.org/project/glibc/list/?series=2549

    • Carlos to look at this patch.
• Siddhesh says all his patches can wait.
• Carlos to review manual change:

  • https://patchwork.sourceware.org/project/glibc/patch/20210722162733.3185678-1-siddhesh@sourceware.org/

Meeting: 2021-07-19 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• Starting review 311 patches.
• malloc debug hooks break very old emacs binaries that rely on malloc hooks.
• New patches required to migrate malloc_set_state / malloc_get_state
• Siddhesh to work on v10 with reallocarray not included in list of interposers.
  • New v10 has malloc_*_state
• rt/tst-cpuclock2-time64 still unreliable
  • Want to clean this up for 32-bit trybot.
• Florian: Should we add the 64-bit time_t aliases?
  • 8 new symbols.
  • Don't want setsockopt and getsockopt
    • 6 new symbols.
    • Carlos: How many patches?

      • https://patchwork.sourceware.org/project/glibc/list/?series=2415

• ABI:
  • Additional time64 aliases --- Adhemerval to review.
  • v10 malloc hook removal --- Carlos to reivew.
  • x86.h addition --- Carlos to review for HJ.
• non-ABI:
  • C.UTF-8 --- What about U+FFFD? Can we use it for default_missing?
  • Adhemerval: 4 patches just fixes for the testsuite.

    • https://patchwork.sourceware.org/project/glibc/list/?series=2423 --- New version.

    • https://patchwork.sourceware.org/project/glibc/list/?series=2489

    • https://patchwork.sourceware.org/project/glibc/list/?series=2490

Meeting: 2021-07-12 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

• Limits patch (Carlos will review)

  • https://patchwork.sourceware.org/project/glibc/patch/87a6mrbsnk.fsf@oldenburg.str.redhat.com/

• x86.h patch:
  • Old patch:

    • https://patchwork.sourceware.org/project/glibc/patch/20210605135947.469959-1-hjl.tools@gmail.com/

  • New patch:

    • https://patchwork.sourceware.org/project/glibc/patch/20210605135947.469959-1-hjl.tools@gmail.com/

• lld fix is updated then it helps the most users
  • For static pie.
  • Users matter downstream.
  • Carlos will follow up with comment on patch.
• LD_AUDIT for Rice?
  • Review?
• Opt-out of security features
  • Avoiding loading PIE objects.
  • Vtable hardening.
  • Discussion on viability of patches to implement such a request.
• Need internal clone, clone2, clone3 review (Adhemerval will review).

Meeting: 2021-07-05 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

Meeting: 2021-07-05 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

No notes for this meeting.

Meeting: 2021-06-28 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

• Started with 243 patches.
• libanl needs review as pthread using library.
• C.UTF-8
  • Push this week.
• 43936 libanl merge
  • Review.
• Adhemerval to review libutil merge.
• Florian may need to repost libnss_files/libnss_dns.
  • Moving libresolv is an ABI change.
  • Moving the libnss_* change is important.
• clone3 review for HJ required.
• Carlos to review:

  • https://patchwork.sourceware.org/project/glibc/list/?series=2345

  • https://patchwork.sourceware.org/project/glibc/list/?series=2252

• Adhemerval to review:

  • https://patchwork.sourceware.org/project/glibc/list/?series=2363

• Siddhesh:
  • DJ reviewing malloc hooks removal for v2.
    • There is one ABI change that needs to happen.
      • Needs review.
      • Need to review this before release.

      • Series: https://patchwork.sourceware.org/project/glibc/list/?series=2369

Meeting: 2021-06-21 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

• glibc 286 patches.
• Lukasz has reviewed 64-bit time_t changes.
  • Adhemerval has review delegated.

  • https://sourceware.org/pipermail/libc-alpha/2021-June/127727.html

    • Additional fixes for release.
    • Avoids CRIO problems and optimizes usage when run on older kernels.
• SA_RESTART change can be pushed later this week.
  • Should switch to SA_ONSTACK also? Want to write a test case.
  • SA_RESTART does not fix bz for longstanding cancellation issues, but it helps.
• ABI changes in flight:
  • librt review.
  • libanl to move into libc.
  • libnss_files
  • libnss_dns
  • libutil to move into libc.
• Florian wants to Review ABI before release.
• HJ is looking at desirable for release "clone3 wrappers":

  • https://patchwork.sourceware.org/project/glibc/list/?series=2252

  • PTHREAD_STAKC_MIN fixes to mirror existing dyanmic stack size fixes.
    • HJ to work on this patch for consistency.
• gconv split out with .d directories.
  • Ask DJ to review gconv split out .d patches?
• HWCAP things on Arm had a regression in glibc 2.34
  • This is for july when the ABI is frozen and look at regression bugs.

  • https://sourceware.org/bugzilla/show_bug.cgi?id=27046

• Carlos needs to review:

  • https://patchwork.sourceware.org/project/glibc/patch/20210125135619.9695-1-hjl.tools@gmail.com/

  • https://patchwork.sourceware.org/project/glibc/patch/20210202145733.545020-1-hjl.tools@gmail.com/

• Need review for Florian:

  • https://sourceware.org/pipermail/libc-alpha/2021-June/127727.html

  • https://sourceware.org/pipermail/libc-alpha/2021-June/127727.html

• Carlos to post to libc-alpha that wiki page is up for blockers.
• Review starting at 43935
  • libutil (small, self contained)

    • https://patchwork.sourceware.org/project/glibc/list/?series=2334

There was a quick discussion about the public LD_AUDIT request after patch review.

• Any detailed discussions need to happen on libc-alpha in public.
• Discussion of the Rice University post here:

  • https://sourceware.org/pipermail/libc-alpha/2021-June/127636.html

• LD_BIND_NOW? How do we handle it.
  • Input how to fix it?
  • We need BIND_NOW to have something to work with SVE.
    • What do we do with SVE
  • NEON support broken on aarch64.
    • Bump the LA_VERSION on Arm64
    • Only supports version 2.
    • Don't know how to fix this for SVE.
    • Fixing it for NEON and SVE both is desirable.
  • Is BIND_NOW just an optimization or semantic issue?
  • Bump LAV_CURRENT to 2 on all arches.
    • Start calling la_symbind in more cases.
    • Call early in the bind now scenario.
      • For the bindnow call sites we add a check afterwards that the callback didn't request PLT_ENTER/PLT_EXIT hooks.
      • If the hook check fails, we report a dlsym error or relocation error.
      • Can we call the callbacks that early?
      • Yes, already relocated.

Meeting: 2021-06-14 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

• Start at 291 patches.
• 64-bit time_t patch review.
• Process startup issue. Seen by HPC developers.
• Question: Related to unversioned library installs.

  • https://patchwork.sourceware.org/project/glibc/list/?series=2293

  • Haven't talked to Gentoo/Debian yet.
• Start review at 43844

• https://patchwork.sourceware.org/project/glibc/patch/87czsook3i.fsf@oldenburg.str.redhat.com/

• Carlos to create 2.34 release page. (Now done).
• Patchwork has a way to update only one patch?

  • https://patchwork.sourceware.org/project/glibc/patch/20210611172439.248245-1-adhemerval.zanella@linaro.org/

• Follow up upstream with patchwork to post a new patch, just one v3 for a series.

• https://patchwork.sourceware.org/project/glibc/list/?series=2304

  • Change how pthreads synchronize with detach/join
  • No ABI, can review into July.
• ABI changes:
  • Add close_range support on Linux
  • New POSIX spawn file actions.
  • _Fork() from POSIX.
• 43819 gconv configuration parsing cleanups. No ABI change.
• glibc 2.34 release blocker tracking bug.
  • Link release page to tree-view.
• 43815 - Consolidated by Siddhesh working on them.
• 43803 - Do not install shared objects under versioned.

Meeting: 2021-06-07 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on freenode.

Review new patches and restart review at the top.

Notes:

• HJ raised upstream issue requiring review: Removal of COPY relocs.
  • Brief discussion about COPY relocs and where the conversation will take place.
  • Carlos suggested we need an upstream meeting between ABI stakeholders.
  • Discussed status of Non-PIE issues briefly and directed conversation to upstream.
• Discussed briefly GNU Tools Cauldron at LPC since this would present an opportunity to discuss feature and patch status.
• Suggested DJ review the iconv split up patches from Siddhesh.
• Adhemerval noted that for 43664 that Szabolcs may want to double check compiler builtin status for Wilco's patch.
• Stopped at 43663 which will be reviewed by Florian since v4 fixes all previous comments.

Meeting: 2021-05-31 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on freenode.

Review new patches and restart review at the top.

Notes:

• Start at top of list.
• Current patch queue count is 251 patches needding review.
• Started at 43622.
• Series 2241 "nptl: pthread cancellation refactor" needs review before the thread stack changes can get reworked.
• 43558 to review for Carlos.
• 43497, Carlos to ask Jonathan Wakely to repost v3 with a different title and the same in-reply-to chain.
• 43389, 33388 - Superseded and removed.
• Stopped at 41649. 197 patches in queue.

Meeting: 2021-05-24 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on freenode.

Review new patches and restart review at the top.

Notes:

• Reviewed libpthread merge. Two patches left to review. Adhemerval doing review.
• Two x86 patches for misaligned stack need review.
• 64-bit time_t patches should be reviewed this week, 25 patches + 1 patch for header export.
• One RFC patch for slow tls after dlopen, should review before 2.34 release.
• Two 64-bit time_t test patches need possible rework, to look at after 64_bit time_t changes.

Meeting: 2021-05-17 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on freenode.

Review new patches and restart review at the top.

Notes:

• 308 patches in queue.
• Meeting URL has changed to avoid Jitsi server compatibility issues.
• Lukasz's task is to provided y2038 support for 32-bit processors.
• Last year some customers were now requiring to have a y2038 solution.
• Some system designs are so ahead they need to support y2038.
• Some problems with the refactor with ABI symbols.
• Newest version is compilable is on github.

  • https://github.com/lmajewski/y2038_glibc

  • https://github.com/lmajewski/y2038_glibc/commits/y2038_edge

• Not fixing utmp.
• Review Adhemerval's changes.
• 7 weeks.
  • 20 patches for 64-bit time_t
  • 8 patches for libpthread removal.
    • Deal with librt removal.
    • Some impact on timer handling.

Meeting: 2021-05-10 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Review new patches and restart review at the top.

Notes:

• Total of 313 patches in the queue (new/nobody).
• Discussed making 64-bit time_t (15-16 patches) a serious 2.34 feature.
• Reviewed up to patch 42023.
• Paul would like a quick discussion about the match component.

Meeting: 2021-05-03 @ 0900h EST5EDT

Cancelled.

Meeting: 2021-04-26 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Notes:

• 333 - state new, delegate nobody.
• 43062 execveat system call wrapper.
• 42197 fix italian locale capitalization
• Paul wants to discuss plans for math component.
• Szabolcs - reviews complete for dynamic tls fixes, need comment reviews.

Meeting: 2021-04-19 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Meeting: 2021-04-12 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Review new patches and restart review at 42561.

Meeting: 2021-04-05 @ 0900h EST5EDT

Cancelled.

Meeting: 2021-03-29 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Review new patches and restart review at 42244.

Notes:

• Total patch list is at 388 patches, so approximately +30 patches from last time.
• Discussed libpthread merge and the status of the patches. Moving forward well.

Meeting: 2021-03-22 @ 0900h EST5EDT

Cancelled.

Meeting: 2021-03-15 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Review new patches and restart review at 42023.

Notes:

• 352 patches in State=New Delegate=Nobody.
• Discussed auto-posting committed patches to list using patchwork to drive that.

• Asked DJ to look at https://patchwork.sourceware.org/project/glibc/list/?series=1817

• 42282 - 42334: Any review? Some sparse review. Settle the filesystem 2038 issue? On disk file format issue for out-of-range dates. Repost test as a distinct series.
• 42277 - Review x86-64 Avoid RTM abort inside a RTM region. Still need reviewer.
• 42244. Stopped here.

Meeting: 2021-03-08 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Review new patches and restart review at 41481.

Notes:

• Manually review State=Under Review, Delegate=Nobody (15 patches).
• Reviewed the patches without delegate and moved back to NEW for review.
• 356 patches in queue for current state=new delegate=nobody.
• 15 patches were delegate=nobody state=under review.
• Stopped at 42023 "powerpc: backtrace cleanup."

• Guest made a comment "https://sourceware.org/glibc/wiki/ThreadPropertiesAPI" which sparked a discussion about TLS issues that need fixing.

Meeting: 2021-03-01 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Review new patches and restart review at 41785.

Notes:

• IBM: Talk to Tulio and Paul Murphy about patch review for IBM.
• Changes requested for 41576, 41572 - Raise with Fangrui Song discuss coverage and what support looks like.
• Stopped at 41481.

Meeting: 2021-02-22 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Review new patches and restart review at 41628.

Notes:

• No reviewers found for TLS P&C issues yet, review next week.

• Next week the 64-bit time_t patches for final support will be posted for review.

Meeting: 2021-02-15 @ 0900h EST5EDT

Cancelled.

Meeting: 2021-02-08 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Notes:

• Patch queue was 430 patches at the start of the meeting.
• Closed the meeting with 412 patches. Up +5 patches from last week after review.
• Ended meeting at 41628 (though Szabolcs was going to close that patch).

Meeting: 2021-02-01 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Notes:

• All release blockers reviewed. There were none left.
• Started reviewing the queue.
• Stopped at patch ID 41767. There were 407 patches left in the queue.

Meeting: 2021-01-25 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Will review release blocker patches and desirable patches.

Notes:

• All release blockers reviewed.
• Decided that hard freeze should happen.
• Moving SIGSTKSZ issues to be pushed as soon as 2.34 opens. Needs warning NEWS item for upcoming deprecation.
• Discussed upcoming features.

Meeting: 2021-01-18 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Will review release blocker patches and desirable patches.

Notes:

• Moved DSO sorting to glibc 2.34 to resolve issues with dual sorting transition.
• Carlos to review _SC_MINSIGSTKSZ and deprecate _SC_SIGSTKSZ_SOURCE.
• Florian to review COMMON_CPUID_INDEX_MAX handshake.
• Florian to review Fix getdents64 fallback on mips64-n32
• Fix static PIE ifunc resolvers.
• Adhemerval to email HJ and Szabolcs on status.
• Florian Weimer to ping Martin Sebor on PR/98512.
• Florian to raise issue around check for x86 ISA v2 and v3 and virt.
• What about deadlines for the release?
  • Keep only those issues that are ABI regressions.
• How do we shorten the release window?
  • Discuss on libc-alpha with new thread topic.

Meeting: 2021-01-11 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Will review release blocker patches and desirable patches.

Notes:

• Hosted by Siddhesh
• Adhemerval to run the call as Release Manager
• AArch64 static PIE needs a fix and patch reviewer should be found.

• Adhemerval Notes

Meeting: 2021-01-04 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

Queue is clean and we are reviewing patches.

Notes:

• Currently reviewing patches starting at patch ID 41361
• Last meeting NEW queue size was 424 patches.
• Reviewed patches for the release.
  • Release blockers patchwork patch review complete.
  • Desirable for release pathcwork patch review complete.
  • All patches have delegates for review or are in progress.
• Marking LibOS RFC patchwork patches as dropped
  • GNU Cauldron 2019 feedback was the patches need updating.
  • LibOS implementation needs reworking to be supported by upstream.
  • Marking all patches as dropped.
• Build failures with gcc 11 / glibc mainline need fixing before release.

Meeting: 2020-12-14 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

The goal is to review the entire queue for a clean and manageable state before returning to start tackling the patches. This ensures that we can run automation across the queue without worrying about patches that don't need to be handled, and to make people aware of our efforts.

Notes:

• Currently at patch ID 33866, with only 558 patches in the queue.
• We are 72% of the way through the full patch queue.
• After we walk the full queue once doing cleanup we'll start handling patch-by-patch review.
• Completed the full queue review.
• Started working the patch queue from the top of the list downward. Made it to patch ID 41361.

Meeting: 2020-12-07 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

The goal is to review the entire queue for a clean and manageable state before returning to start tackling the patches. This ensures that we can run automation across the queue without worrying about patches that don't need to be handled, and to make people aware of our efforts.

Notes:

• Currently at patch ID 40823, which is 10% of the way through the patch list.
• Estimate that in 9 more meetings we get through the queue. Completion on 2021-02-15 (after glibc 2.33 release).
• No meetings on December 21st, or December 28th, taking two weeks off for the holidays.
• Ended meeting at patch ID 33866.

Meeting: 2020-11-30 @ 0900h EST5EDT

Video/Audio: https://jitsi.member.fsf.org/glibc-patch-review

IRC: #glibc on freenode.

The initial goal of several of the first meetings is to get the patchwork queue down to a clean manageable state. Along with writing automation to keep it in a clean state.

Notes:

• Added "Patch IDs" to the list of things to enable in patchwork for review.
• Discussed the process and the problems with using patchwork.
• Started reviewing the list of patches and got the queue down to 1239.
• Process is to skip patches from people who are known to actively maintain their queue.
• Dug deeper into queues from submitters with fewer patches or people who are not expected to be deeply involved in the process.
• Delegated some patches to reviewers that were on the call.
• Ended meeting at patch ID 40823, reviewed 125 of 1239 (10% review).
• Discussed patch sending problems and issues with patches sent to the list which are not understood by patchwork.

• Arjun noted git imap-send to send patches to your imap drafts folder and then send them on to the list e.g. git format-patch --stdout HEAD^ | git imap-send