Bug 9717 - Build error on hppa with linuxthreads: missing TYPE argument to __libc_tsd_define, __libc_tsd_{get;set}
Summary: Build error on hppa with linuxthreads: missing TYPE argument to __libc_tsd_de...
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: ports (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Carlos O'Donell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-07 14:08 UTC by Arthur Loiret
Modified: 2014-07-02 06:59 UTC (History)
1 user (show)

See Also:
Host: hppa-linux-gnu
Target: hppa-linux-gnu
Build: hppa-linux-gnu
Last reconfirmed:
fweimer: security-


Attachments
proposed patch for ports (637 bytes, patch)
2009-01-07 14:10 UTC, Arthur Loiret
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arthur Loiret 2009-01-07 14:08:59 UTC
Hi,

hppa linuxthreads build is broken since:

2008-11-07  Jakub Jelinek  <jakub@redhat.com>
[...]
        * bits/libc-tsd.h (__libc_tsd_define, __libc_tsd_address,
        __libc_tsd_get, __libc_tsd_set): Add TYPE argument, use it as the type
        of the thread variable instead of void *.
[...]

Because of missing TYPE argument in
sysdeps/unix/sysv/linux/hppa/linuxthreads/malloc-machine.h.
Comment 1 Arthur Loiret 2009-01-07 14:10:51 UTC
Created attachment 3643 [details]
proposed patch for ports
Comment 2 Carlos O'Donell 2009-01-07 22:49:56 UTC
I'll look into this next week.
Comment 3 Arthur Loiret 2009-01-31 11:21:46 UTC
Any news on this?
Comment 4 Carlos O'Donell 2009-02-09 20:28:04 UTC
Thanks for the ping.

I assume you are building a linuxthreads configuration with tls enabled,
otherwise bits/libc-tst.h would not be used. I'm going to checkin the patch
knowing that it breaks non-tls linuxthreads builds, and that such a
configuration is no longer valid.

I also noticed that this patch is already in the debian sources. In the future
please mention if the patch is already in use in a distribution since it helps
when I'm doing the analysis.

Checked in.
Comment 5 Sourceware Commits 2009-02-09 20:28:09 UTC
Subject: Bug 9717

CVSROOT:	/cvs/glibc
Module name:	ports
Changes by:	carlos@sourceware.org	2009-02-09 20:27:56

Modified files:
	.              : ChangeLog.hppa 
	sysdeps/unix/sysv/linux/hppa/linuxthreads: malloc-machine.h 

Log message:
	2009-02-09  Arthur Loiret  <aloiret@debian.org>
	
	[BZ #9717]
	
	* sysdeps/unix/sysv/linux/hppa/linuxthreads/malloc-machine.h
	(MALLOC): Adjust __libc_tsd_define arguments.
	(tsd_setspecific, tsd_getspecific): Adjust __libc_tsd_{set,get}
	arguments.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/ports/ChangeLog.hppa.diff?cvsroot=glibc&r1=1.49&r2=1.50
http://sourceware.org/cgi-bin/cvsweb.cgi/ports/sysdeps/unix/sysv/linux/hppa/linuxthreads/malloc-machine.h.diff?cvsroot=glibc&r1=1.1&r2=1.2