Bug 730 - libio fmemopen broken
Summary: libio fmemopen broken
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: libc (show other bugs)
Version: 2.3.4
: P2 normal
Target Milestone: ---
Assignee: Roland McGrath
URL:
Keywords:
Depends on:
Blocks: libc235
  Show dependency tree / graph
 
Reported: 2005-02-16 04:32 UTC by Roland McGrath
Modified: 2018-04-20 13:37 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland McGrath 2005-02-16 04:32:41 UTC 
This trunk change is needed on the 2.3 branch.

2005-01-27  Jakub Jelinek  <jakub@redhat.com>

	* stdio-common/tst-fmemopen2.c: Include string.h.

2005-01-19  Jakub Jelinek  <jakub@redhat.com>

	* libio/iofopncook.c (_IO_cookie_seekoff): Add prototype.

2005-01-05  Ulrich Drepper  <drepper@redhat.com>

	* libio/iofopncook.c (_IO_cookie_seekoff): Define.  Mark offset as
	invalid to disable optimizations in fileops which won't work here.
	(_IO_cookie_jumps): Use it.
	(_IO_old_cookie_jumps): Likewise.
	* libio/fmemopen.c (fmemopen_seek): Result must be returned in *P,
	not the return value.
	* stdio-common/Makefile (tests): Add tst-fmemopen2.
	* stdio-common/tst-fmemopen2.c: New file.
Comment 1 Sourceware Commits 2005-02-16 09:45:25 UTC 
Subject: Bug 730

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-02-16 09:45:11

Modified files:
	libio          : fmemopen.c 
	stdio-common   : Makefile 

Log message:
	2005-01-05  Ulrich Drepper  <drepper@redhat.com>
	
	[BZ #730]
	* libio/iofopncook.c (_IO_cookie_seekoff): Define.  Mark offset as
	invalid to disable optimizations in fileops which won't work here.
	(_IO_cookie_jumps): Use it.
	(_IO_old_cookie_jumps): Likewise.
	* libio/fmemopen.c (fmemopen_seek): Result must be returned in *P,
	not the return value.
	* stdio-common/Makefile (tests): Add tst-fmemopen2.
	* stdio-common/tst-fmemopen2.c: New file.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/libio/fmemopen.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.8&r2=1.8.4.1
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/stdio-common/Makefile.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.90&r2=1.90.4.1
Comment 2 Sourceware Commits 2005-02-16 09:45:28 UTC 
Subject: Bug 730

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-02-16 09:45:16

Added files:
	stdio-common   : tst-fmemopen2.c 

Log message:
	2005-01-27  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #730]
	* stdio-common/tst-fmemopen2.c: Include string.h.
	2005-01-05  Ulrich Drepper  <drepper@redhat.com>
	
	[BZ #730]
	* libio/iofopncook.c (_IO_cookie_seekoff): Define.  Mark offset as
	invalid to disable optimizations in fileops which won't work here.
	(_IO_cookie_jumps): Use it.
	(_IO_old_cookie_jumps): Likewise.
	* libio/fmemopen.c (fmemopen_seek): Result must be returned in *P,
	not the return value.
	* stdio-common/Makefile (tests): Add tst-fmemopen2.
	* stdio-common/tst-fmemopen2.c: New file.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/stdio-common/tst-fmemopen2.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=NONE&r2=1.3.2.1
Comment 3 Sourceware Commits 2005-02-16 09:45:38 UTC 
Subject: Bug 730

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-02-16 09:45:21

Modified files:
	libio          : iofopncook.c 

Log message:
	2005-01-19  Jakub Jelinek  <jakub@redhat.com>
	
	[BZ #730]
	* libio/iofopncook.c (_IO_cookie_seekoff): Add prototype.
	2005-01-05  Ulrich Drepper  <drepper@redhat.com>
	
	[BZ #730]
	* libio/iofopncook.c (_IO_cookie_seekoff): Define.  Mark offset as
	invalid to disable optimizations in fileops which won't work here.
	(_IO_cookie_jumps): Use it.
	(_IO_old_cookie_jumps): Likewise.
	* libio/fmemopen.c (fmemopen_seek): Result must be returned in *P,
	not the return value.
	* stdio-common/Makefile (tests): Add tst-fmemopen2.
	* stdio-common/tst-fmemopen2.c: New file.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/libio/iofopncook.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.21&r2=1.21.4.1
Comment 4 Roland McGrath 2005-04-05 23:59:22 UTC 
These changes are in the 2.3 branch as well as the trunk now.