Bug 3471 - Line stepping and intruction stepping scrolling is gross.
Summary: Line stepping and intruction stepping scrolling is gross.
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Mike Cvet
URL:
Keywords:
Depends on:
Blocks: 1633 3346
  Show dependency tree / graph
 
Reported: 2006-11-07 14:05 UTC by Mike Cvet
Modified: 2006-11-10 21:47 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Cvet 2006-11-07 14:05:19 UTC 
Instead of simply highlighting the next line, the SourceWindow jumps around to 
find the currently-executing function and then highlighting the appropriate 
line. It should simply just highlight the next line without going all crazy.
Comment 1 Mike Cvet 2006-11-10 21:47:50 UTC 
Log message:
        2006-11-10  Mike Cvet  <mcvet@redhat.com>
        
        * SourceBuffer.java (setCurrentLine): Mark only the innermost frame.
        (createTags): Strip spaces before creating TextMark. Fixes #3499.
        Check for nulls before parsing.
        (setScope): Use an iterator to iterate through Vector. Check to see if
        the source file needs to be loaded. Fixes #3503.
        (highlightLine): Added. Tags and unTags based on StackFrame.
        (SourceBuffer): Initialize functions Vector.
        (loadFile): Check for nulls in source. Call createTags() on frames
        with debuginfo.
        
        * SourceWindow.java (doStep): Call removeTags() after unblocking.
        (updateShownStackFrame): Won't load a file if not needed. Scrolls by
        line number instead of TextMark when possible. Fixes #3470, #3471.
        (SourceWindowListener.currentStackChanged): Update currentFrame.
        (populateStackBrowser): Lots of new case handling. Makes sure that
        currently selected frames are updated properly.
        (removeTags): Added. Remove relevant StackFrame TextTags from the
        source text.
        (doStep): Call removeTags().
        (doRun): Call removeTags().
        
        * SourceView.java (mouseMotionEvent): Don't attempt a Variable reading
        if the SourceWindow is not stopped. Fixes #3504.