Bug 32444 - gdb.ada/packed_array_assign.exp: value of pra fails on aarch64 since 1411185a57ed246558f0f97d7faf0dc050de3708
Summary: gdb.ada/packed_array_assign.exp: value of pra fails on aarch64 since 1411185a...
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: ada (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: 16.1
Assignee: Tom Tromey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-11 09:45 UTC by Christophe Lyon
Modified: 2024-12-12 13:39 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Lyon 2024-12-11 09:45:57 UTC
As reported in https://sourceware.org/pipermail/gdb-testers/2024q4/175239.html
since commit g:1411185a57ed246558f0f97d7faf0dc050de3708 (https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=1411185a57ed246558f0f97d7faf0dc050de3708), we have noticed a new failure on aarch64:

FAIL: gdb.ada/packed_array_assign.exp: value of pra

gdb.log says:
[...]
(gdb) break aggregates.run_test
Breakpoint 1 at 0x1830: file /home/tcwg-buildslave/workspace/tcwg_gnu_3/gdb/gdb/testsuite/gdb.ada/packed_array_assign/aggregates.adb, line 23.
(gdb) run 
Starting program: /home/tcwg-buildslave/workspace/tcwg_gnu_3/abe/builds/aarch64-unknown-linux-gnu/aarch64-unknown-linux-gnu/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.ada/packed_array_assign/tester 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/aarch64-linux-gnu/libthread_db.so.1".

Breakpoint 1, aggregates.run_test () at /home/tcwg-buildslave/workspace/tcwg_gnu_3/gdb/gdb/testsuite/gdb.ada/packed_array_assign/aggregates.adb:23
23	      Do_Nothing (PRA'Address);
(gdb) get_compiler_info: gcc-11-4-0
print pra :=  ((packed_array_assign_x => 2, packed_array_assign_y => 0, packed_array_assign_w => 17), pr, (packed_array_assign_x => 7, packed_array_assign_y => 1, packed_array_assign_w => 23))
warning: Extra components in aggregate ignored.
$1 = ((packed_array_assign_w => 0, packed_array_assign_x => 0, packed_array_assign_y => 0), (packed_array_assign_w => 0, packed_array_assign_x => 0, packed_array_assign_y => 0), (packed_array_assign_w => 0, packed_array_assign_x => 0, packed_array_assign_y => 0))
(gdb) FAIL: gdb.ada/packed_array_assign.exp: value of pra
Comment 2 Sourceware Commits 2024-12-12 13:38:28 UTC
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=439334eba0dafe61a01b9b9404f0bbaa6e25c853

commit 439334eba0dafe61a01b9b9404f0bbaa6e25c853
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Dec 11 06:54:27 2024 -0700

    Fix GNAT version check in gdb.ada
    
    Commit 1411185a ("Introduce and use gnat_version_compare") changed the
    Ada tests to use a new proc for version checking.  Unfortunately this
    patch inadvertently reversed the sense of the test in
    packed_array_assign.exp.
    
    After fixing this, I went through that patch again and looked for
    other problems.  I found one spot where the wrong syntax was used, and
    some others where I believe the sense of the test was inverted.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32444
    Approved-By: Andrew Burgess <aburgess@redhat.com>
Comment 3 Tom Tromey 2024-12-12 13:39:08 UTC
Fixed.