Bug 32107 - Drop obsolete -Werror hack in buildrun.cxx
Summary: Drop obsolete -Werror hack in buildrun.cxx
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: runtime (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-21 06:12 UTC by Sam James
Modified: 2024-09-04 14:49 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James 2024-08-21 06:12:16 UTC 
A decade ago, systemtap kindly added a workaround for an issue in our (Gentoo) packaging where we stripped out -Werror too aggressively: https://bugs.gentoo.org/522908.

In buildrun.cxx:
```
// A bit of obfuscation for Gentoo's sake.
// We *need* -Werror for stapconf to work correctly.
// https://bugs.gentoo.org/show_bug.cgi?id=522908
#define WERROR ("-W" "error")
```

Our packaging has long since been fixed. It should be OK to drop the workaround now.

I added 5.1 to Gentoo earlier too and dropped all of our seds for -Werror and switched to the new --disable-Werror option (thanks!)
Comment 1 Sam James 2024-08-21 06:49:42 UTC 
I sent a patch at https://inbox.sourceware.org/systemtap/9ad9aa9fedaf1d9b26fae42afedeec80ea18c58d.1724222681.git.sam@gentoo.org/T/#u but please note I couldn't test it properly.
Comment 2 Frank Ch. Eigler 2024-09-04 14:49:14 UTC 
commit 731a73ce505e