For the PowerPC port of gold: % gold/ld-new -m elf32ppc -shared /dev/null -o test gold/ld-new: error: /dev/null: file is empty gold/ld-new: internal error in add_output_section_to_load, at gold/output.cc:4097 Note - the input file does not appear to be relevant. This example uses /dev/null, but the same bug has been reported with other, non-empty input files: https://bugzilla.redhat.com/show_bug.cgi?id=2234396
Caused by commit 5a97377e5513, specifically this code added to Target_powerpc::do_relax + if (parameters->options().output_is_position_independent()) + this->rela_dyn_size_ + = this->rela_dyn_section(layout)->current_data_size(); The problem here is that if .rela.dyn isn't already created then the call to rela_dyn_section creates is, and as this comment says // Annoyingly, we need to make these sections now whether or // not we need them. If we delay until do_relax then we // need to mess with the relaxation machinery checkpointing.
The master branch has been updated by Alan Modra <amodra@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d537f77ef3b18a5fbfd598643aaad957652e9608 commit d537f77ef3b18a5fbfd598643aaad957652e9608 Author: Alan Modra <amodra@gmail.com> Date: Fri Aug 25 09:12:18 2023 +0930 PR30794, PowerPC gold: internal error in add_output_section_to_load Caused by commit 5a97377e5513, specifically this code added to Target_powerpc::do_relax + if (parameters->options().output_is_position_independent()) + this->rela_dyn_size_ + = this->rela_dyn_section(layout)->current_data_size(); The problem here is that if .rela.dyn isn't already created then the call to rela_dyn_section creates it, and as this comment in Target_powerpc::do_finalize_sections says: // Annoyingly, we need to make these sections now whether or // not we need them. If we delay until do_relax then we // need to mess with the relaxation machinery checkpointing. We can't be creating sections in do_relax. PR 30794 * powerpc.cc (Target_powerpc::do_relax): Only set rela_dyn_size_ for size == 64, and assert that rela_dyn_ already exists. Tidy code setting plt_thread_safe, which also only needs to be set when size == 64 for ELFv1.
The binutils-2_41-branch branch has been updated by Alan Modra <amodra@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=60834ae1eb7b4f87598cfa79abdc72221415ac9e commit 60834ae1eb7b4f87598cfa79abdc72221415ac9e Author: Alan Modra <amodra@gmail.com> Date: Fri Aug 25 09:12:18 2023 +0930 PR30794, PowerPC gold: internal error in add_output_section_to_load Caused by commit 5a97377e5513, specifically this code added to Target_powerpc::do_relax + if (parameters->options().output_is_position_independent()) + this->rela_dyn_size_ + = this->rela_dyn_section(layout)->current_data_size(); The problem here is that if .rela.dyn isn't already created then the call to rela_dyn_section creates it, and as this comment in Target_powerpc::do_finalize_sections says: // Annoyingly, we need to make these sections now whether or // not we need them. If we delay until do_relax then we // need to mess with the relaxation machinery checkpointing. We can't be creating sections in do_relax. PR 30794 * powerpc.cc (Target_powerpc::do_relax): Only set rela_dyn_size_ for size == 64, and assert that rela_dyn_ already exists. Tidy code setting plt_thread_safe, which also only needs to be set when size == 64 for ELFv1. (cherry picked from commit d537f77ef3b18a5fbfd598643aaad957652e9608)
Fixed.