Bug 30538 - [gdb/testsuite, aarch64] FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints is 11
Summary: [gdb/testsuite, aarch64] FAIL: gdb.python/py-rbreak.exp: check number of retu...
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 13.1
: P2 normal
Target Milestone: 14.1
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-12 07:22 UTC by Tom de Vries
Modified: 2023-06-12 11:07 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom de Vries 2023-06-12 07:22:43 UTC
With a gdb 13.1 based package on SLE-15 aarch64,  I run into:
...
(gdb) PASS: gdb.python/py-rbreak.exp: nosharedlibrary
py sl = gdb.rbreak("^[^_]",minsyms=False)^M
Breakpoint 2 at 0x4004ac: file ../sysdeps/aarch64/crti.S, line 63.^M
Breakpoint 3 at 0x4005cc: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak-func2.c, line \
21.^M
Breakpoint 4 at 0x4005d4: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak-func2.c, line \
27.^M
Breakpoint 5 at 0x4005dc: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak-func2.c, line \
33.^M
Breakpoint 6 at 0x400564: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak.c, line 21.^M
Breakpoint 7 at 0x40056c: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak.c, line 27.^M
Breakpoint 8 at 0x400574: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak.c, line 33.^M
Breakpoint 9 at 0x40057c: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak.c, line 39.^M
Breakpoint 10 at 0x400584: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak.c, line 45.^M
Breakpoint 11 at 0x40058c: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak.c, line 51.^M
Breakpoint 12 at 0x4005a4: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak.c, line 63.^M
Breakpoint 13 at 0x400594: file /home/abuild/rpmbuild/BUILD/gdb-13.2/gdb/testsuite/gdb.python/py-rbreak.c, line 57.^M
(gdb) py print(len(sl))^M
12^M
(gdb) FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints is 11
...

This is the unexpected one:
...
Breakpoint 2 at 0x4004ac: file ../sysdeps/aarch64/crti.S, line 63.^M
...

Looking in the glibc sources, it's function "call_weak_fn".
Comment 1 Sourceware Commits 2023-06-12 10:59:56 UTC
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9f82823f8972fbd4bba0230b27828d87f0548cbc

commit 9f82823f8972fbd4bba0230b27828d87f0548cbc
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Jun 12 13:00:09 2023 +0200

    [gdb/testsuite] Relax breakpoint count check in gdb.python/py-rbreak.exp
    
    With a gdb 13.2 based package on SLE-15 aarch64,  I run into:
    ...
    (gdb) PASS: gdb.python/py-rbreak.exp: nosharedlibrary
    py sl = gdb.rbreak("^[^_]",minsyms=False)^M
    Breakpoint 2 at 0x4004ac: file ../sysdeps/aarch64/crti.S, line 63.^M
      ...
    (gdb) py print(len(sl))^M
    12^M
    (gdb) FAIL: gdb.python/py-rbreak.exp: check number of returned breakpoints is 11
    ...
    
    The FAIL is due to:
    - the glibc object crti.o containing debug information for function
      call_weak_fn, and
    - the test-case not expecting this.
    
    The debug information is there due to compiling glibc using a binutils which
    contains commit 591cc9fbbfd ("gas/Dwarf: record functions").
    
    I've run into a similar issue before, see commit 3fbbcf473a5 ("[gdb/testsuite]
    Fix regexp in py-rbreak.exp").
    
    The fix I applied there was to use a regexp "^[^_]" to filter out
    __libc_csu_fini and __libc_csu_init, but that doesn't work for call_weak_fn.
    
    Fix this by:
    - reverting the regexp to "", and
    - rewriting the check to require at least 11 functions, rather than a precise
      match.
    
    Tested on x86_64-linux.
    
    PR testsuite/30538
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30538
Comment 2 Tom de Vries 2023-06-12 11:07:11 UTC
Fixed.