Bug 30473 - Emit DAP Process event
Summary: Emit DAP Process event
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: dap (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: 15.1
Assignee: Tom Tromey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-19 15:07 UTC by Tom Tromey
Modified: 2023-12-11 15:45 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Tromey 2023-05-19 15:07:55 UTC
DAP specifies a Process event that should be emitted
when starting or attaching.  gdb currently does not do this.
Comment 1 Tom Tromey 2023-10-06 15:55:38 UTC
See https://github.com/microsoft/debug-adapter-protocol/issues/439
... requested clarification of the meaning of "system process".
Comment 2 Tom Tromey 2023-10-06 20:30:30 UTC
I have a patch to add this, but I wonder when it should be sent.
For "attach" it is currently sent after a bunch of other events
(new thread, new module).  That's probably too late but the spec
doesn't really say.
Comment 4 Sourceware Commits 2023-11-28 15:56:20 UTC
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=14e461bed44258fb872731a79ca5e82b70781d09

commit 14e461bed44258fb872731a79ca5e82b70781d09
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Oct 6 14:30:46 2023 -0600

    Emit DAP "process" event
    
    DAP specifies a "process" event that is sent when a process is started
    or attached to.  gdb was not emitting this (several DAP clients appear
    to ignore it entirely), but it looked easy and harmless to implement.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30473
Comment 5 Tom Tromey 2023-11-28 15:57:01 UTC
Fixed.
Comment 6 Sourceware Commits 2023-12-11 15:45:37 UTC
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9a099bc220fbc97e9ccff6a7e1861e11665e8899

commit 9a099bc220fbc97e9ccff6a7e1861e11665e8899
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Dec 11 07:50:46 2023 -0700

    Add DAP items to NEWS
    
    Now that DAP is in GDB 14, significant changes to it should be noted
    in NEWS.  This patch adds a note for a fix that's already gone in.  I
    started a new section in NEWS because more changes are coming.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30473
    Approved-By: Eli Zaretskii <eliz@gnu.org>